dongjinleekr commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775197551
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##
@@ -136,6 +136,18 @@ public B setRetryCou
garydgregory commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001101249
> The issue is that currently some tests are still using JUnit 4. For that
there is the [System Rules](https://github.com/stefanbirkner/system-rules)
project, but I d
garydgregory commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775190696
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##
@@ -136,6 +136,18 @@ public B setRetryCou
dongjinleekr commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775189022
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##
@@ -136,6 +136,18 @@ public B setRetryCou
Marcono1234 commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001090717
The issue is that currently some tests are still using JUnit 4. For that
there is the [System Rules](https://github.com/stefanbirkner/system-rules)
project, but I did
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775176529
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/StrSubstitutorTest.java
##
@@ -249,4 +249,37 @@ public void
testTopLevelLo
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775176529
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/StrSubstitutorTest.java
##
@@ -249,4 +249,37 @@ public void
testTopLevelLo
KristjanESPERANTO commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001077412
Then you will never find a reference to the current release notes in the
master branch. If that's the way you want it, I don't understand it, but that's
okay too
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775173387
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/StrSubstitutorTest.java
##
@@ -249,4 +249,37 @@ public void
tes
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775173387
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/lookup/StrSubstitutorTest.java
##
@@ -249,4 +249,37 @@ public void
tes
Gamebuster19901 commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001075553
> For the `StatusLogger`, removing the log will mean a user hitting this
limit won't know about it, which makes it harder for them to fix. Their logs
will just be
Gamebuster19901 edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001072402
> I am in favor of reading the cap from a property and returning the lookup
as is, i.e., no error logging via `StatusLogger`.
~~I agree with no error
Gamebuster19901 edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001072402
> I am in favor of reading the cap from a property and returning the lookup
as is, i.e., no error logging via `StatusLogger`.
~~I agree with no error
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775172956
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean s
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775170590
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean substitute(f
garydgregory commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001072849
> Isn't there a mechanism we can hook into to take a snapshot of existing
properties before and restoring them after a test method?
Yes, there's an app for that
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001072449
@vy Could you elaborate on why you prefer this?
For the system property, can we come up with a case where people will
actually need/want >10 (or some other limit) level
Gamebuster19901 commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001072402
> I am in favor of reading the cap from a property and returning the lookup
as is, i.e., no error logging via `StatusLogger`.
I agree with no error logging f
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775170010
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean substitute(f
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001070873
> When will the changes be transferred from the release-2.x branch to the
master branch?
[Never, since every release will have its own
content.](https://lists.apache.org
vy commented on pull request #658:
URL: https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001070661
Isn't there a mechanism we can hook into to take a snapshot of existing
properties before and restoring them after a test method?
--
This is an automated message from the Apa
vy commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001070245
I am in favor of reading the cap from a property and returning the lookup as
is, i.e., no error logging via `StatusLogger`.
--
This is an automated message from the Apache Gi
[
https://issues.apache.org/jira/browse/LOG4J2-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici closed LOG4J2-3271.
-
> When compiling 2.17.0 java8 error
> -
>
> Key: LOG
[
https://issues.apache.org/jira/browse/LOG4J2-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici resolved LOG4J2-3266.
---
Resolution: Information Provided
> ${CTX :ThreadName} does not work
>
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775165870
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean s
Gamebuster19901 commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775165870
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -986,12 +986,20 @@ protected boolean s
[
https://issues.apache.org/jira/browse/LOG4J2-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carter Kozak reassigned LOG4J2-3289:
Assignee: Carter Kozak
> log4j-to-slf4j should not re-format the result of Message.getFor
[
https://issues.apache.org/jira/browse/LOG4J2-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carter Kozak closed LOG4J2-3289.
> log4j-to-slf4j should not re-format the result of Message.getFormattedMessage
>
[
https://issues.apache.org/jira/browse/LOG4J2-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carter Kozak resolved LOG4J2-3289.
--
Resolution: Fixed
> log4j-to-slf4j should not re-format the result of Message.getFormattedMess
[
https://issues.apache.org/jira/browse/LOG4J2-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465244#comment-17465244
]
ASF subversion and git services commented on LOG4J2-3289:
-
Commi
carterkozak merged pull request #659:
URL: https://github.com/apache/logging-log4j2/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
jvz merged pull request #10:
URL: https://github.com/apache/logging-log4j-scala/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
carterkozak opened a new pull request #659:
URL: https://github.com/apache/logging-log4j2/pull/659
https://issues.apache.org/jira/browse/LOG4J2-3289
By passing a parameter array to slf4j, we hinted that the message string was
a template and should be substituted, however the result o
Carter Kozak created LOG4J2-3289:
Summary: log4j-to-slf4j should not re-format the result of
Message.getFormattedMessage
Key: LOG4J2-3289
URL: https://issues.apache.org/jira/browse/LOG4J2-3289
Project
garydgregory commented on a change in pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#discussion_r775151693
##
File path:
log4j-kafka/src/main/java/org/apache/logging/log4j/kafka/appender/KafkaAppender.java
##
@@ -136,6 +136,18 @@ public B setRetryCou
srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001011990
The error messages are a little harder to understand now, since the logged
error string will be whatever was being handled by `substitute` when the limit
was exceeded,
srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001011990
The error messages are a little harder to understand now, since the logged
error string will be whatever was being handled by `substitute` when the limit
was exceeded,
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001011990
The error messages are a little harder to understand now, since the logged
string will be whatever was being handled by `substitute` when the limit was
exceeded, instead of t
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001010713
Updated to avoid throwing a potentially unhandled exception. Also moved the
max depth constant into the substitute method, and fixed a conflict with the
base branch.
--
Th
dongjinleekr commented on pull request #640:
URL: https://github.com/apache/logging-log4j2/pull/640#issuecomment-1001001300
Hi @garydgregory,
After some trial and error, I concluded that maintaining the ignored package
list in an array would be better than a file-based approach. Here
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775127430
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int
BUILD UNSTABLE
Build URL
https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/552/
Project:
release-2.x
Date of build:
Sat, 25 Dec 2021 09:09:59 +
Build duration:
1 hr 0 min and counting
JUnit Tests
Name: (root) Failed: 0 test(s), P
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775127430
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int
srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-100189
> Should we return the input, or the pieces that we could successfully
replace
Neither string is likely to be the output the author wanted I think. If this
case
srdo commented on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-100189
> Should we return the input, or the pieces that we could successfully
replace
Neither string is likely to be the output the author wanted I think. If this
case is hit
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775126323
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int
srdo commented on a change in pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#discussion_r775126323
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/StrSubstitutor.java
##
@@ -168,6 +168,11 @@
private static final int
KristjanESPERANTO commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000997057
When will the changes be transferred from the `release-2.x` branch to the
master branch?
The `RELEASE-NOTES.md` in the master branch is still outdated.
-
[
https://issues.apache.org/jira/browse/LOG4J2-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465153#comment-17465153
]
ASF subversion and git services commented on LOG4J2-3211:
-
Commi
49 matches
Mail list logo
