[GitHub] [logging-log4j2] garydgregory commented on pull request #591: LOG4J2-2829 SocketAppender should propagate failures when reconnection fails.

2021-10-23 Thread GitBox
garydgregory commented on pull request #591: URL: https://github.com/apache/logging-log4j2/pull/591#issuecomment-950214555 Are we losing any code coverage due to the removal of tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #591: LOG4J2-2829 SocketAppender should propagate failures when reconnection fails.

2021-10-23 Thread GitBox
garydgregory commented on a change in pull request #591: URL: https://github.com/apache/logging-log4j2/pull/591#discussion_r735020059 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java ## @@ -238,7 +238,10 @@ protected void write(fin

[GitHub] [logging-log4j2] rgoers commented on pull request #591: LOG4J2-2829 SocketAppender should propagate failures when reconnection fails.

2021-10-23 Thread GitBox
rgoers commented on pull request #591: URL: https://github.com/apache/logging-log4j2/pull/591#issuecomment-950213698 This looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (LOG4J2-2025) Support Tomcat JULI's per-webapp JUL logging by implementing java.util.logging.Handler

2021-10-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433362#comment-17433362 ] ASF subversion and git services commented on LOG4J2-2025: - Commi

[GitHub] [logging-log4j2] rgoers merged pull request #437: LOG4J2-2025 jul-log4j bridgehandler

2021-10-23 Thread GitBox
rgoers merged pull request #437: URL: https://github.com/apache/logging-log4j2/pull/437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[jira] [Commented] (LOG4J2-3165) Custom line separator for throwable breaks formatting

2021-10-23 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433359#comment-17433359 ] Volkan Yazici commented on LOG4J2-3165: --- bq. The current tests do demonstrate on b

[GitHub] [logging-log4j2] vy commented on pull request #437: LOG4J2-2025 jul-log4j bridgehandler

2021-10-23 Thread GitBox
vy commented on pull request #437: URL: https://github.com/apache/logging-log4j2/pull/437#issuecomment-950194437 @rgoers, last you indicated to merge this after 2.14.1 release. Would you mind doing it, please? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4j2] lilbigmouth commented on pull request #437: LOG4J2-2025 jul-log4j bridgehandler

2021-10-23 Thread GitBox
lilbigmouth commented on pull request #437: URL: https://github.com/apache/logging-log4j2/pull/437#issuecomment-950164980 Is there any update on this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [logging-log4j-kotlin] sschuberth commented on pull request #20: LoggingFactory: Make logger() used cached loggers by default

2021-10-23 Thread GitBox
sschuberth commented on pull request #20: URL: https://github.com/apache/logging-log4j-kotlin/pull/20#issuecomment-950110677 > Did you notice a problem that this was intended to solve? No, it just felt more natural to me to use the cached loggers by default as a potential performanc