rm5248 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947277364
> It is a benchmarking thing. Your benchmarking tools look good. When are
you thinking you will merge?
I don't have any timeframe for that at the moment. It is mostly
swebb2066 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947167006
It is a benchmarking thing. Your benchmarking tools look good. When are you
thinking you will merge?
Have you run the benchmarks without the std::mutex lock in
Hier
edwgiz commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732296538
##
File path:
log4j-maven-plugins/log4j-maven-plugins-shade-transformer/src/site/site.xml
##
@@ -0,0 +1,52 @@
+
+http://maven.apache.org/DECORATION/
edwgiz commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732293762
##
File path:
log4j-maven-plugins/log4j-maven-plugins-shade-transformer/src/site/markdown/index.md
##
@@ -0,0 +1,81 @@
+
Review comment:
Cou
rm5248 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947155410
Is the objective to have a unit test, or a benchmarking test? Those are two
somewhat differing goals in my mind - a unit test makes sure that things are
working, while a ben
edwgiz commented on pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#issuecomment-947153607
Thanks for positive feedback
Without MANIFEST.MF the build fails
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-jar-plugin:3.2.0:jar (default-jar
BUILD UNSTABLE
Build URL
https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/370/
Project:
release-2.x
Date of build:
Tue, 19 Oct 2021 20:53:06 +
Build duration:
1 hr 0 min and counting
JUnit Tests
Name: (root) Failed: 1 test(s), P
[
https://issues.apache.org/jira/browse/LOG4J2-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430783#comment-17430783
]
Volkan Yazici commented on LOG4J2-3174:
---
[~romainmoreau], thanks so much for the c
[
https://issues.apache.org/jira/browse/LOG4J2-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici closed LOG4J2-3174.
-
> Wrong subject on mail when it depends on the LogEvent
> --
[
https://issues.apache.org/jira/browse/LOG4J2-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430782#comment-17430782
]
ASF subversion and git services commented on LOG4J2-3174:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430781#comment-17430781
]
ASF subversion and git services commented on LOG4J2-3172:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici updated LOG4J2-3174:
--
Fix Version/s: 2.15.0
> Wrong subject on mail when it depends on the LogEvent
> --
[
https://issues.apache.org/jira/browse/LOG4J2-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici resolved LOG4J2-3174.
---
Resolution: Fixed
> Wrong subject on mail when it depends on the LogEvent
>
rgoers commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732242689
##
File path:
log4j-maven-plugins/log4j-maven-plugins-shade-transformer/src/site/markdown/index.md
##
@@ -0,0 +1,81 @@
+
Review comment:
In
vy merged pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
[
https://issues.apache.org/jira/browse/LOG4J2-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430765#comment-17430765
]
ASF subversion and git services commented on LOG4J2-3174:
-
Commi
vy commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r732234714
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -273,10 +273,11 @@ protected MimeMultipart getMimeMultipa
[
https://issues.apache.org/jira/browse/LOG4J2-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici reassigned LOG4J2-3179:
-
Assignee: Volkan Yazici
> Unable to programmatically configure additional fields for Js
[
https://issues.apache.org/jira/browse/LOG4J2-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430763#comment-17430763
]
Volkan Yazici commented on LOG4J2-3179:
---
[~plasm0r], I strongly advise you to migr
[
https://issues.apache.org/jira/browse/LOG4J2-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430762#comment-17430762
]
Volkan Yazici commented on LOG4J2-3179:
---
Does the following work for you?
{code:j
vy commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732216398
##
File path: log4j-maven-plugins/log4j-maven-plugins-shade-transformer/pom.xml
##
@@ -0,0 +1,233 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi=
vy commented on pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#issuecomment-947080992
Fantastic work @edwgiz, thanks so much!
One more question: I am a `MANIFEST.MF` noob, is the empty file necessary?
--
This is an automated message from the Apache Git S
romainmoreau commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r732218121
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -273,10 +273,11 @@ protected MimeMultipart getM
[
https://issues.apache.org/jira/browse/LOG4J2-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Linley updated LOG4J2-3179:
Priority: Major (was: Minor)
> Unable to programmatically configure additional fields for JsonLay
[
https://issues.apache.org/jira/browse/LOG4J2-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Linley updated LOG4J2-3179:
Summary: Unable to programmatically configure additional fields for
JsonLayout plugin using Layout
[
https://issues.apache.org/jira/browse/LOG4J2-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Linley updated LOG4J2-3179:
Description:
Hi
I am unable to programmatically configure the JsonLayout plugin to include
custo
Mark Linley created LOG4J2-3179:
---
Summary: Unable to programmatically configuring additional fields
for JsonLayout plugin using LayoutComponentBuilder.
Key: LOG4J2-3179
URL: https://issues.apache.org/jira/browse/LOG
[
https://issues.apache.org/jira/browse/LOG4J2-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yankai zhang updated LOG4J2-3178:
-
Description:
This is how {{DefaultMergeStrategy#mergConfigurations}} merge logger nodes:
!image
[
https://issues.apache.org/jira/browse/LOG4J2-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yankai zhang updated LOG4J2-3178:
-
Description:
This is how {{DefaultMergeStrategy#mergConfigurations}} merge logger nodes:
!image
[
https://issues.apache.org/jira/browse/LOG4J2-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yankai zhang updated LOG4J2-3178:
-
Description:
This is how {{DefaultMergeStrategy#mergConfigurations}} merge logger nodes:
!image
[
https://issues.apache.org/jira/browse/LOG4J2-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yankai zhang updated LOG4J2-3178:
-
Description:
This is how {{DefaultMergeStrategy#mergConfigurations}} merge logger nodes:
!image
yankai zhang created LOG4J2-3178:
Summary: DefaultMergeStrategy do not merge type of logger node
Key: LOG4J2-3178
URL: https://issues.apache.org/jira/browse/LOG4J2-3178
Project: Log4j 2
Issue
swebb2066 opened a new pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73
This PR provides a tool for measuring the cost of changes to the Logger and
Hierarchy classes.
I have measured the cost of the std::mutex lock in Hierarchy::isDisabled as
approx 1300 ns.
edwgiz closed pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
34 matches
Mail list logo
