carterkozak commented on pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568#issuecomment-904190754
Hoping the smaller methods are inlined more aggressively as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
garydgregory commented on pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568#issuecomment-904185436
Nice. I like that we can simplify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
carterkozak opened a new pull request #568:
URL: https://github.com/apache/logging-log4j2/pull/568
Rerunning the benchmarks on modern java (in this case java 16,
however many optimizations are available in java 11 due to the
compact string optimizations) shows that the previous assumpt
carterkozak commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904155637
Sorry, the `master` branch isn't in the best state, I generally target
`release-2.x` initially and port commits to master. CI builds are running
correctly on that branc
jjmms commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904150662
I have written a test but unable to run it due to errors in Maven build and
test per CI errors:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compil
carterkozak commented on pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567#issuecomment-904089216
Looks reasonable to me. Any chance you can provide a minimal test case?
Something as simple as an additional assert in `RewriteAppenderTest` should do
the trick, we can
jjmms opened a new pull request #567:
URL: https://github.com/apache/logging-log4j2/pull/567
https://issues.apache.org/jira/browse/LOG4J2-3142
When using the `LogEventAdapter` we should return the
`LogEvent.getTimeMillis()` as this is the equivalent timestamp value from
Log4j2 to Lo
[
https://issues.apache.org/jira/browse/LOG4J2-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Meikle updated LOG4J2-3142:
Description:
When invoking {{LogEventAdapter.getTimestamp()}} the result is always 0 even if
the
John Meikle created LOG4J2-3142:
---
Summary: Timestamp always returns 0 for LogEventAdapter
Key: LOG4J2-3142
URL: https://issues.apache.org/jira/browse/LOG4J2-3142
Project: Log4j 2
Issue Type: Bu
[
https://issues.apache.org/jira/browse/LOG4J2-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403351#comment-17403351
]
ASF subversion and git services commented on LOG4J2-3141:
-
Commi
[
https://issues.apache.org/jira/browse/LOG4J2-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carter Kozak resolved LOG4J2-3141.
--
Resolution: Fixed
> Avoid overhead in *Manager.setEndOfBatch(boolean)
> --
[
https://issues.apache.org/jira/browse/LOG4J2-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carter Kozak closed LOG4J2-3141.
> Avoid overhead in *Manager.setEndOfBatch(boolean)
>
[
https://issues.apache.org/jira/browse/LOG4J2-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403349#comment-17403349
]
ASF subversion and git services commented on LOG4J2-3141:
-
Commi
carterkozak merged pull request #566:
URL: https://github.com/apache/logging-log4j2/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
[
https://issues.apache.org/jira/browse/LOG4J2-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on LOG4J2-3141 started by Carter Kozak.
> Avoid overhead in *Manager.setEndOfBatch(boolean)
> -
[
https://issues.apache.org/jira/browse/LOG4J2-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403330#comment-17403330
]
Carter Kozak commented on LOG4J2-3141:
--
https://github.com/apache/logging-log4j2/pu
[
https://issues.apache.org/jira/browse/LOG4J2-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carter Kozak reassigned LOG4J2-3141:
Assignee: Carter Kozak
> Avoid overhead in *Manager.setEndOfBatch(boolean)
>
Carter Kozak created LOG4J2-3141:
Summary: Avoid overhead in *Manager.setEndOfBatch(boolean)
Key: LOG4J2-3141
URL: https://issues.apache.org/jira/browse/LOG4J2-3141
Project: Log4j 2
Issue Typ
18 matches
Mail list logo