[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #559: Bump tomcat-catalina from 8.5.20 to 10.0.10

2021-08-05 Thread GitBox
dependabot[bot] opened a new pull request #559: URL: https://github.com/apache/logging-log4j2/pull/559 Bumps tomcat-catalina from 8.5.20 to 10.0.10. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.to

[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #546: Bump tomcat-catalina from 8.5.20 to 10.0.8

2021-08-05 Thread GitBox
dependabot[bot] commented on pull request #546: URL: https://github.com/apache/logging-log4j2/pull/546#issuecomment-893984027 Superseded by #559. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] dependabot[bot] closed pull request #546: Bump tomcat-catalina from 8.5.20 to 10.0.8

2021-08-05 Thread GitBox
dependabot[bot] closed pull request #546: URL: https://github.com/apache/logging-log4j2/pull/546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [logging-log4j2] carterkozak commented on pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-08-05 Thread GitBox
carterkozak commented on pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-893569664 > My benchmarks were with a single thread only. In practice, is this code executed in multiple log4j2 threads? As usual, the answer is “it depends” :-) in th

[GitHub] [logging-log4j2] carterkozak commented on pull request #555: Improve worst-case NameAbbreviator performance

2021-08-05 Thread GitBox
carterkozak commented on pull request #555: URL: https://github.com/apache/logging-log4j2/pull/555#issuecomment-893543113 ## Azul Zulu JDK 16.0.2, OpenJDK 64-Bit Server VM, 16.0.2+7 ### This PR (as is, using `indexOf(String, int)`) _1_ (run numbers labeled to account for therma

[GitHub] [logging-log4j2] sman-81 edited a comment on pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-08-05 Thread GitBox
sman-81 edited a comment on pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-893394475 Hi again @carterkozak interesting what you've found. Thanks for looking into this. Your research puts a question mark behind the usefulness of my pull request.

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #555: Improve worst-case NameAbbreviator performance

2021-08-05 Thread GitBox
carterkozak commented on a change in pull request #555: URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r683429654 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java ## @@ -285,40 +285,40 @@ public PatternAbbrevi

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2021-08-05 Thread GitBox
sman-81 commented on a change in pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542#discussion_r683419578 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java ## @@ -365,4 +372,51 @@ public void abbreviate(fin

[GitHub] [logging-log4j2] sman-81 commented on a change in pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2021-08-05 Thread GitBox
sman-81 commented on a change in pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542#discussion_r683418964 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java ## @@ -365,4 +372,51 @@ public void abbreviate(fin

[GitHub] [logging-log4j2] sman-81 commented on pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

2021-08-05 Thread GitBox
sman-81 commented on pull request #544: URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-893394475 Hi again @carterkozak interesting what you've found. Thanks for looking into this. Your research puts a question mark behind the usefulness of my pull request. My benc

[GitHub] [logging-log4j2] carterkozak merged pull request #553: LOG4J2-3083 Fix slf4j calling class lookup using both accessors

2021-08-05 Thread GitBox
carterkozak merged pull request #553: URL: https://github.com/apache/logging-log4j2/pull/553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] vy closed pull request #545: Add markdown links to README.md file

2021-08-05 Thread GitBox
vy closed pull request #545: URL: https://github.com/apache/logging-log4j2/pull/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] vy commented on pull request #545: Add markdown links to README.md file

2021-08-05 Thread GitBox
vy commented on pull request #545: URL: https://github.com/apache/logging-log4j2/pull/545#issuecomment-892706763 Looks like a spam. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [logging-log4j2] carterkozak commented on pull request #557: LOG4J2-3133: log4j-slf4j-impl provides new singleton accessors from slf4j-api 1.7.14

2021-08-05 Thread GitBox
carterkozak commented on pull request #557: URL: https://github.com/apache/logging-log4j2/pull/557#issuecomment-892737122 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [logging-log4j2] carterkozak merged pull request #554: LOG4J2-3083 Fix slf4j calling class lookup using both accessors

2021-08-05 Thread GitBox
carterkozak merged pull request #554: URL: https://github.com/apache/logging-log4j2/pull/554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] schlosna commented on a change in pull request #555: Improve worst-case NameAbbreviator performance

2021-08-05 Thread GitBox
schlosna commented on a change in pull request #555: URL: https://github.com/apache/logging-log4j2/pull/555#discussion_r683117411 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java ## @@ -285,40 +285,40 @@ public PatternAbbreviato

[GitHub] [logging-log4j2] vy merged pull request #552: (doc): Fix XML element names in javadoc

2021-08-05 Thread GitBox
vy merged pull request #552: URL: https://github.com/apache/logging-log4j2/pull/552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [logging-log4j2] carterkozak closed pull request #557: LOG4J2-3133: log4j-slf4j-impl provides new singleton accessors from slf4j-api 1.7.14

2021-08-05 Thread GitBox
carterkozak closed pull request #557: URL: https://github.com/apache/logging-log4j2/pull/557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [logging-log4j2] sman-81 commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat

2021-08-05 Thread GitBox
sman-81 commented on pull request #548: URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999 Hi @carterkozak, hi @vy, thank you both for fixing the **reviapi** build failure. I should have spotted this myself. I must admit I've rarely built the whole project a

[GitHub] [logging-log4j2] vy commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat

2021-08-05 Thread GitBox
vy commented on pull request #548: URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893239718 :man_facepalming: @carterkozak, right, thanks for the warning, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

2021-08-05 Thread GitBox
carterkozak commented on a change in pull request #542: URL: https://github.com/apache/logging-log4j2/pull/542#discussion_r682718072 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NameAbbreviator.java ## @@ -365,4 +372,51 @@ public void abbreviate

[GitHub] [logging-log4j2] carterkozak commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat

2021-08-05 Thread GitBox
carterkozak commented on pull request #548: URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-892717422 @vy I think this broke builds on release-2.x for the same reason the PR build is failing, revapi needs the enum ordinal changes to be acknowledged. -- This is an auto

[GitHub] [logging-log4j2] sman-81 edited a comment on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat

2021-08-05 Thread GitBox
sman-81 edited a comment on pull request #548: URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999 Hi @carterkozak, hi @vy, thank you both for fixing the `revapi` build failure which I have reproduced earlier. I should have spotted this myself. I must admit I

[GitHub] [logging-log4j2] sman-81 edited a comment on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat

2021-08-05 Thread GitBox
sman-81 edited a comment on pull request #548: URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999 Hi @carterkozak, hi @vy, thank you both for fixing the `revapi` build failure which I have reproduced earlier. I should have spotted this myself. I must admit I

[CI][SUCCESS] Logging/log4j/release-2.x#322 back to normal

2021-08-05 Thread Mr. Jenkins
BUILD SUCCESS Build URL https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/322/ Project: release-2.x Date of build: Thu, 05 Aug 2021 07:40:21 + Build duration: 1 hr 34 min and counting JUnit Tests Name: liquibase.ext.logging.log4j

[GitHub] [logging-log4j2] sman-81 commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat

2021-08-05 Thread GitBox
sman-81 commented on pull request #548: URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893295999 Hi @carterkozak, hi @vy, thank you both for fixing the **reviapi** build failure. I should have spotted this myself. I must admit I've rarely built the whole project a

[GitHub] [logging-log4j2] vy commented on pull request #548: LOG4J2-2885 Add support for US-style date patterns and micro/nano seconds to FixedDateFormat

2021-08-05 Thread GitBox
vy commented on pull request #548: URL: https://github.com/apache/logging-log4j2/pull/548#issuecomment-893239718 :man_facepalming: @carterkozak, right, thanks for the warning, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (LOG4J2-2885) Date patterns with microseconds do not work

2021-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393689#comment-17393689 ] ASF subversion and git services commented on LOG4J2-2885: - Commi

[jira] [Commented] (LOG4J2-2885) Date patterns with microseconds do not work

2021-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393687#comment-17393687 ] ASF subversion and git services commented on LOG4J2-2885: - Commi