[jira] [Commented] (LOG4J2-3112) Repeated FileNotFoundException from ConfiguratonFileWatcher if log4j config file was deleted

2021-06-24 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369242#comment-17369242 ] Ralph Goers commented on LOG4J2-3112: - Yeah - I should change the doc to read "chang

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #538: Resolve references inside javadoc.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #538: URL: https://github.com/apache/logging-log4j2/pull/538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #537: Lambda improvements:

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #537: URL: https://github.com/apache/logging-log4j2/pull/537 * Use comparator Reverse * Replace anonymous class for lambda. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #536: Make Local variable and parameter final.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #536: URL: https://github.com/apache/logging-log4j2/pull/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #535: Make Local variable and parameter final.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #535: URL: https://github.com/apache/logging-log4j2/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #534: Make Local variable and parameter final.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #534: URL: https://github.com/apache/logging-log4j2/pull/534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #532: Replace loop with bulk method.

2021-06-24 Thread GitBox
carterkozak commented on a change in pull request #532: URL: https://github.com/apache/logging-log4j2/pull/532#discussion_r658181865 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/TypeUtil.java ## @@ -53,9 +54,7 @@ private TypeUtil() { public st

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #532: Replace loop with bulk method.

2021-06-24 Thread GitBox
arturobernalg commented on a change in pull request #532: URL: https://github.com/apache/logging-log4j2/pull/532#discussion_r658178940 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/TypeUtil.java ## @@ -53,9 +54,7 @@ private TypeUtil() { public

[GitHub] [logging-log4j2] vy merged pull request #531: Simplify conditional expression.

2021-06-24 Thread GitBox
vy merged pull request #531: URL: https://github.com/apache/logging-log4j2/pull/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on a change in pull request #532: Replace loop with bulk method.

2021-06-24 Thread GitBox
vy commented on a change in pull request #532: URL: https://github.com/apache/logging-log4j2/pull/532#discussion_r658172667 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/TypeUtil.java ## @@ -53,9 +54,7 @@ private TypeUtil() { public static List

[GitHub] [logging-log4j2] vy merged pull request #533: Make Local variable and parameter final.

2021-06-24 Thread GitBox
vy merged pull request #533: URL: https://github.com/apache/logging-log4j2/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy merged pull request #514: Java 8 Improvements:

2021-06-24 Thread GitBox
vy merged pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #533: Make Local variable and parameter final.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #533: URL: https://github.com/apache/logging-log4j2/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #532: Replace loop with bulk method.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #532: URL: https://github.com/apache/logging-log4j2/pull/532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #531: Simplify conditional expression.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #531: URL: https://github.com/apache/logging-log4j2/pull/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #530: Remove unused import.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #530: URL: https://github.com/apache/logging-log4j2/pull/530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #529: Remove redundant variable which are immediately returned.

2021-06-24 Thread GitBox
arturobernalg opened a new pull request #529: URL: https://github.com/apache/logging-log4j2/pull/529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[jira] [Commented] (LOG4J2-3111) Filter which stops logging if disk space left is lower than a configurable threshold

2021-06-24 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368944#comment-17368944 ] Carter Kozak commented on LOG4J2-3111: -- At work I use the StatusLogger history (war

[jira] [Commented] (LOG4J2-3111) Filter which stops logging if disk space left is lower than a configurable threshold

2021-06-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368939#comment-17368939 ] Volkan Yazici commented on LOG4J2-3111: --- [~rgoers], indeed, dumping the status cha

[GitHub] [logging-log4j2] arturobernalg commented on pull request #514: Java 8 Improvements:

2021-06-24 Thread GitBox
arturobernalg commented on pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-867740270 > @rgoers, I see that you have already approved this PR, yet did not merge it. Later on, @arturobernalg force-pushed new changes. In order to avoid double work, I wil

[GitHub] [logging-log4j2] vy commented on pull request #514: Java 8 Improvements:

2021-06-24 Thread GitBox
vy commented on pull request #514: URL: https://github.com/apache/logging-log4j2/pull/514#issuecomment-867733647 @rgoers, I see that you have already approved this PR, yet did not merge it. Later on, @arturobernalg force-pushed new changes. In order to avoid double work, I will appreciate

[GitHub] [logging-log4j2] vy merged pull request #510: Replace try finally statement with try with resources statement

2021-06-24 Thread GitBox
vy merged pull request #510: URL: https://github.com/apache/logging-log4j2/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on a change in pull request #511: LOG4J2-3109 - Use Standard Charset object (StandardCharsets)

2021-06-24 Thread GitBox
vy commented on a change in pull request #511: URL: https://github.com/apache/logging-log4j2/pull/511#discussion_r658051704 ## File path: log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/StringEncodingBenchmark.java ## @@ -52,11 +53,11 @@ private static final St

[GitHub] [logging-log4j2] vy merged pull request #524: Make Local variable and parameter final.

2021-06-24 Thread GitBox
vy merged pull request #524: URL: https://github.com/apache/logging-log4j2/pull/524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy merged pull request #526: Replace anonymous classes with lambda expressions.

2021-06-24 Thread GitBox
vy merged pull request #526: URL: https://github.com/apache/logging-log4j2/pull/526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy merged pull request #523: Make Local variable and parameter final.

2021-06-24 Thread GitBox
vy merged pull request #523: URL: https://github.com/apache/logging-log4j2/pull/523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy merged pull request #525: Replace null check with Objects/Stream static method.

2021-06-24 Thread GitBox
vy merged pull request #525: URL: https://github.com/apache/logging-log4j2/pull/525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on a change in pull request #528: Bugfix for LOG4J2-3107: SmtpManager.createManagerName ignores port

2021-06-24 Thread GitBox
vy commented on a change in pull request #528: URL: https://github.com/apache/logging-log4j2/pull/528#discussion_r658042296 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java ## @@ -166,9 +172,7 @@ private static String createManagerName(

[jira] [Commented] (LOG4J2-3111) Filter which stops logging if disk space left is lower than a configurable threshold

2021-06-24 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368903#comment-17368903 ] Ralph Goers commented on LOG4J2-3111: - I understand what you are saying but I am not

[jira] [Commented] (LOG4J2-3111) Filter which stops logging if disk space left is lower than a configurable threshold

2021-06-24 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368699#comment-17368699 ] Volkan Yazici commented on LOG4J2-3111: --- I also think such a {{Filter}} is a good

[jira] [Commented] (LOG4J2-3112) Repeated FileNotFoundException from ConfiguratonFileWatcher if log4j config file was deleted

2021-06-24 Thread Andrey Turbanov (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368693#comment-17368693 ] Andrey Turbanov commented on LOG4J2-3112: - As I get from documentation: {quote}