[GitHub] [logging-log4j2] arturobernalg opened a new pull request #523: Make Local variable and parameter final.

2021-06-18 Thread GitBox
arturobernalg opened a new pull request #523: URL: https://github.com/apache/logging-log4j2/pull/523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #524: Make Local variable and parameter final.

2021-06-18 Thread GitBox
arturobernalg opened a new pull request #524: URL: https://github.com/apache/logging-log4j2/pull/524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #481: LOG4J2-3060 Fix integer overflow in DefaultErrorHandler

2021-06-18 Thread GitBox
rgoers commented on a change in pull request #481: URL: https://github.com/apache/logging-log4j2/pull/481#discussion_r654555057 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/DefaultErrorHandler.java ## @@ -84,14 +75,24 @@ public void error(final

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #526: Replace anonymous classes with lambda expressions.

2021-06-18 Thread GitBox
arturobernalg opened a new pull request #526: URL: https://github.com/apache/logging-log4j2/pull/526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] sman-81 opened a new pull request #522: LOG4J2-3107

2021-06-18 Thread GitBox
sman-81 opened a new pull request #522: URL: https://github.com/apache/logging-log4j2/pull/522 @vy I've reiterated the fix using your suggestions. It also contains a unit test. NameUtil.md5 is gone from the implementation, as I see no use in it and its presence complicates testing.

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #525: Replace null check with Objects/Stream static method.

2021-06-18 Thread GitBox
arturobernalg opened a new pull request #525: URL: https://github.com/apache/logging-log4j2/pull/525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] unclesam123 edited a comment on pull request #495: LOG4J2-3075 Fix formatting of nanoseconds in JsonTemplateLayout.

2021-06-18 Thread GitBox
unclesam123 edited a comment on pull request #495: URL: https://github.com/apache/logging-log4j2/pull/495#issuecomment-863813230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [logging-log4j2] unclesam123 commented on pull request #495: LOG4J2-3075 Fix formatting of nanoseconds in JsonTemplateLayout.

2021-06-18 Thread GitBox
unclesam123 commented on pull request #495: URL: https://github.com/apache/logging-log4j2/pull/495#issuecomment-863813230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. Fo

[GitHub] [logging-log4j2] arturobernalg commented on pull request #525: Replace null check with Objects/Stream static method.

2021-06-18 Thread GitBox
arturobernalg commented on pull request #525: URL: https://github.com/apache/logging-log4j2/pull/525#issuecomment-864242637 > While I don't see anything wrong with this, this is another case where I don't really find any advantage to the new code. HI @rgoers IMO it's more readabl

[GitHub] [logging-log4j2] hpple opened a new pull request #521: Remove outdated comment from SystemClock

2021-06-18 Thread GitBox
hpple opened a new pull request #521: URL: https://github.com/apache/logging-log4j2/pull/521 Hi! This comment looks outdated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [logging-log4j2] sman-81 closed pull request #520: LOG4J2-3107: SmtpManager.createManagerName ignores port

2021-06-18 Thread GitBox
sman-81 closed pull request #520: URL: https://github.com/apache/logging-log4j2/pull/520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [logging-log4j2] rgoers commented on pull request #525: Replace null check with Objects/Stream static method.

2021-06-18 Thread GitBox
rgoers commented on pull request #525: URL: https://github.com/apache/logging-log4j2/pull/525#issuecomment-864159417 While I don't see anything wrong with this, this is another case where I don't really find any advantage to the new code. -- This is an automated message from the Apache G

[GitHub] [logging-log4j2] vy commented on pull request #495: LOG4J2-3075 Fix formatting of nanoseconds in JsonTemplateLayout.

2021-06-18 Thread GitBox
vy commented on pull request #495: URL: https://github.com/apache/logging-log4j2/pull/495#issuecomment-863830426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[jira] [Commented] (LOG4J2-2803) Create standardized scopes and dependency injection API

2021-06-18 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365659#comment-17365659 ] Matt Sicker commented on LOG4J2-2803: - I don't know if I was clear in this, but all

[jira] [Commented] (LOG4J2-3106) Add possibility to get console messages immediately

2021-06-18 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365394#comment-17365394 ] Pavel_K commented on LOG4J2-3106: - I think, I've found out the reason. When I use 'mvnDe

[jira] [Commented] (LOG4J2-3106) Add possibility to get console messages immediately

2021-06-18 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365312#comment-17365312 ] Pavel_K commented on LOG4J2-3106: - [~vy]Yes, I tried. However, I need a solution to see

[jira] [Commented] (LOG4J2-3106) Add possibility to get console messages immediately

2021-06-18 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365303#comment-17365303 ] Volkan Yazici commented on LOG4J2-3106: --- As I said, I can reproduce the issue – do

[jira] [Commented] (LOG4J2-3106) Add possibility to get console messages immediately

2021-06-18 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365299#comment-17365299 ] Pavel_K commented on LOG4J2-3106: - [~vy] If you can it reproduce, then I think the probl

[jira] [Commented] (LOG4J2-3106) Add possibility to get console messages immediately

2021-06-18 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365297#comment-17365297 ] Volkan Yazici commented on LOG4J2-3106: --- [~Pavel_K], I did and I can indeed reprod

[jira] [Commented] (LOG4J2-3106) Add possibility to get console messages immediately

2021-06-18 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365292#comment-17365292 ] Pavel_K commented on LOG4J2-3106: - [~vy] Can you say: # Have you followed the steps I l

[jira] [Closed] (LOG4J2-3106) Add possibility to get console messages immediately

2021-06-18 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-3106. - Resolution: Not A Problem > Add possibility to get console messages immediately > --

[jira] [Commented] (LOG4J2-3106) Add possibility to get console messages immediately

2021-06-18 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365289#comment-17365289 ] Volkan Yazici commented on LOG4J2-3106: --- [~Pavel_K], I agree with [~rgoers]. It se

[jira] [Commented] (LOG4J2-3060) Integer overflow in DefaultErrorHandler

2021-06-18 Thread Zhuravlev Sergey (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365284#comment-17365284 ] Zhuravlev Sergey commented on LOG4J2-3060: -- Link to PR on github: https://gith