[GitHub] [logging-log4j2] rgoers commented on pull request #515: Update dependabot to track github action and dockerfile dependencies

2021-06-14 Thread GitBox
rgoers commented on pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861141743 @jvz We already have that. This PR adds configuration for docker and actions. Before deciding whether to accept the PR I need to know exactly what that configuration causes

[GitHub] [logging-log4j2] jvz edited a comment on pull request #516: workflow: add action to handle stale PRs

2021-06-14 Thread GitBox
jvz edited a comment on pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861097008 I think the best stale bot setting would be notifying PR authors when they have merge conflicts to fix the issue. I don't think we get enough PRs to worry about closing

[GitHub] [logging-log4j2] jvz commented on pull request #516: workflow: add action to handle stale PRs

2021-06-14 Thread GitBox
jvz commented on pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-861097008 I think the best stale not setting would be notifying PR authors when they have merge conflicts to fix the issue. I don't think we get enough PRs to worry about closing old one

[GitHub] [logging-log4j2] jvz commented on pull request #515: Update dependabot to track github action and dockerfile dependencies

2021-06-14 Thread GitBox
jvz commented on pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861085384 We have a Docker file for building that we don't really use for anything. I think we do a pretty good job of updating dependencies normally, but a Dependabot config for Maven p

[GitHub] [logging-log4j2] rgoers commented on pull request #515: Update dependabot to track github action and dockerfile dependencies

2021-06-14 Thread GitBox
rgoers commented on pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-861036923 dependency changes of what? I understand that the line specifying Maven lets the plugin know to look at the pom.xml to look for dependencies. I have no idea what it means to

[GitHub] [logging-log4j2] chenrui333 commented on pull request #515: Update dependabot to track github action and dockerfile dependencies

2021-06-14 Thread GitBox
chenrui333 commented on pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860950452 > Thanks but that didn't really answer my question. What does enabling it for actions and dockerfiles do? What is the benefit? Like I said, the benefit would be mo

[GitHub] [logging-log4j2] rgoers commented on pull request #515: Update dependabot to track github action and dockerfile dependencies

2021-06-14 Thread GitBox
rgoers commented on pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860868545 Thanks but that didn't really answer my question. What does enabling it for actions and dockerfiles do? What is the benefit? -- This is an automated message from the Apach

[GitHub] [logging-log4j2] chenrui333 edited a comment on pull request #516: workflow: add action to handle stale PRs

2021-06-14 Thread GitBox
chenrui333 edited a comment on pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535 yeah, you can add some labels of having stale bot ignoring the `in progress` PRs. We actually have some more complicated flow in the homebrew side, https:/

[GitHub] [logging-log4j2] chenrui333 edited a comment on pull request #516: workflow: add action to handle stale PRs

2021-06-14 Thread GitBox
chenrui333 edited a comment on pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535 yeah, you can add some labels of having stale bot ignoring the `in progress` PRs. We actually have some more complicated flow in the homebrew side, https:/

[GitHub] [logging-log4j2] chenrui333 edited a comment on pull request #516: workflow: add action to handle stale PRs

2021-06-14 Thread GitBox
chenrui333 edited a comment on pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535 yeah, you can add some labels of having stale bot ignoring the `in progress` PRs. We actually have some more complicated flow in the homebrew side, https:/

[GitHub] [logging-log4j2] chenrui333 commented on pull request #516: workflow: add action to handle stale PRs

2021-06-14 Thread GitBox
chenrui333 commented on pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860849535 yeah, you can add some labels of having stale bot ignoring the `in progress` PRs. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [logging-log4j2] chenrui333 edited a comment on pull request #515: Update dependabot to track github action and dockerfile dependencies

2021-06-14 Thread GitBox
chenrui333 edited a comment on pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860848911 > Can you please explain why we want to do this? To be honest, I don't find much value in dependabot in the first place. All it really tells me is what the most c

[GitHub] [logging-log4j2] chenrui333 commented on pull request #515: Update dependabot to track github action and dockerfile dependencies

2021-06-14 Thread GitBox
chenrui333 commented on pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860848911 > Can you please explain why we want to do this? To be honest, I don't find much value in dependabot in the first place. All it really tells me is what the most current

[GitHub] [logging-log4j2] rgoers commented on pull request #515: Update dependabot to track github action and dockerfile dependencies

2021-06-14 Thread GitBox
rgoers commented on pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515#issuecomment-860841886 Can you please explain why we want to do this? To be honest, I don't find much value in dependabot in the first place. All it really tells me is what the most current versio

[GitHub] [logging-log4j2] rgoers edited a comment on pull request #516: workflow: add action to handle stale PRs

2021-06-14 Thread GitBox
rgoers edited a comment on pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860839914 I'm not sure I agree with this. It seems too simplistic. Sometimes PRs are good but we are slow to apply them. Prior to every release I review all the PRs and close

[GitHub] [logging-log4j2] rgoers commented on pull request #516: workflow: add action to handle stale PRs

2021-06-14 Thread GitBox
rgoers commented on pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516#issuecomment-860839914 I'm not sure I agree with this. It seems too simplistic. Sometimes PRs are good but we are slow to apply them. Prior to every release I review all the PRs and close those I

[GitHub] [logging-log4j2] chenrui333 opened a new pull request #515: chore(dependabot): track github action and dockerfile dependencies

2021-06-14 Thread GitBox
chenrui333 opened a new pull request #515: URL: https://github.com/apache/logging-log4j2/pull/515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [logging-log4j2] chenrui333 opened a new pull request #516: workflow: add stale PRs handling

2021-06-14 Thread GitBox
chenrui333 opened a new pull request #516: URL: https://github.com/apache/logging-log4j2/pull/516 It would be good to add some stale action to handle the stale PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the