[GitHub] [logging-log4j2] arturobernalg opened a new pull request #512: Reuse multiple equivalent occurrences of the same expression

2021-06-04 Thread GitBox
arturobernalg opened a new pull request #512: URL: https://github.com/apache/logging-log4j2/pull/512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #511: Use Standard Charset object (StandardCharsets)

2021-06-04 Thread GitBox
arturobernalg opened a new pull request #511: URL: https://github.com/apache/logging-log4j2/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #510: Replace try finally statement with try with resources statement

2021-06-04 Thread GitBox
arturobernalg opened a new pull request #510: URL: https://github.com/apache/logging-log4j2/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] arturobernalg closed pull request #509: Replace try finally statement with try with resources statement

2021-06-04 Thread GitBox
arturobernalg closed pull request #509: URL: https://github.com/apache/logging-log4j2/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #509: Replace try finally statement with try with resources statement

2021-06-04 Thread GitBox
arturobernalg opened a new pull request #509: URL: https://github.com/apache/logging-log4j2/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[GitHub] [logging-log4j2] rgoers commented on pull request #506: Make Local variable and parameter final

2021-06-04 Thread GitBox
rgoers commented on pull request #506: URL: https://github.com/apache/logging-log4j2/pull/506#issuecomment-855148181 I just looked at the style guidelines and was surprised to see that it doesn't say anything about final. I know Gary had a thing about making stuff final. For the most part

[jira] [Resolved] (LOG4J2-3102) Asynchronous Logger WAITS indefinitely after end of main method

2021-06-04 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak resolved LOG4J2-3102. -- Fix Version/s: 2.15.0 Resolution: Fixed I've committed the fix to release-2.x in prepar

[jira] [Commented] (LOG4J2-3102) Asynchronous Logger WAITS indefinitely after end of main method

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357604#comment-17357604 ] ASF subversion and git services commented on LOG4J2-3102: - Commi

[jira] [Commented] (LOG4J2-3102) Asynchronous Logger WAITS indefinitely after end of main method

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357603#comment-17357603 ] ASF subversion and git services commented on LOG4J2-3102: - Commi

[GitHub] [logging-log4j2] carterkozak closed pull request #507: LOG4J2-3102: AsyncAppender background thread is a daemon

2021-06-04 Thread GitBox
carterkozak closed pull request #507: URL: https://github.com/apache/logging-log4j2/pull/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [logging-log4j2] carterkozak commented on pull request #507: LOG4J2-3102: AsyncAppender background thread is a daemon

2021-06-04 Thread GitBox
carterkozak commented on pull request #507: URL: https://github.com/apache/logging-log4j2/pull/507#issuecomment-854982427 rebased and committed directly. Conflict is my own fault for merging another fix with a release note! -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (LOG4J2-2940) High CPU at Java 11 due to the use of StackWalker from StackLocator.getCallerClass

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357483#comment-17357483 ] ASF subversion and git services commented on LOG4J2-2940: - Commi

[jira] [Commented] (LOG4J2-2940) High CPU at Java 11 due to the use of StackWalker from StackLocator.getCallerClass

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357482#comment-17357482 ] ASF subversion and git services commented on LOG4J2-2940: - Commi

[jira] [Commented] (LOG4J2-2940) High CPU at Java 11 due to the use of StackWalker from StackLocator.getCallerClass

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357485#comment-17357485 ] ASF subversion and git services commented on LOG4J2-2940: - Commi

[jira] [Commented] (LOG4J2-2940) High CPU at Java 11 due to the use of StackWalker from StackLocator.getCallerClass

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357484#comment-17357484 ] ASF subversion and git services commented on LOG4J2-2940: - Commi

[GitHub] [logging-log4j2] carterkozak closed pull request #505: Fix incorrect LogManager accessor used by LOG4J2-2940

2021-06-04 Thread GitBox
carterkozak closed pull request #505: URL: https://github.com/apache/logging-log4j2/pull/505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [logging-log4j2] carterkozak commented on pull request #505: Fix incorrect LogManager accessor used by LOG4J2-2940

2021-06-04 Thread GitBox
carterkozak commented on pull request #505: URL: https://github.com/apache/logging-log4j2/pull/505#issuecomment-854874004 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [logging-log4j2] arturobernalg commented on pull request #506: Make Local variable and parameter final

2021-06-04 Thread GitBox
arturobernalg commented on pull request #506: URL: https://github.com/apache/logging-log4j2/pull/506#issuecomment-854854147 > runtime HI @carterkozak The idea behind this is keep the code simple, avoid possible programing errors by changes the reference or reassigned the variable.

[GitHub] [logging-log4j2] carterkozak commented on pull request #506: Make Local variable and parameter final

2021-06-04 Thread GitBox
carterkozak commented on pull request #506: URL: https://github.com/apache/logging-log4j2/pull/506#issuecomment-854839601 Can you describe why this is necessary? I had thought that java 8+ "effectively final" variables were equivalent at runtime, but I may be mistaken. -- This is an auto

[jira] [Commented] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357437#comment-17357437 ] ASF subversion and git services commented on LOG4J2-3103: - Commi

[jira] [Commented] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357436#comment-17357436 ] ASF subversion and git services commented on LOG4J2-3103: - Commi

[jira] [Resolved] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak resolved LOG4J2-3103. -- Resolution: Fixed Merged into master and 2.x, thanks for the report :-) > ComodificationExcep

[jira] [Closed] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak closed LOG4J2-3103. > ComodificationException in concurrent access to LoggerContext::stop > --

[jira] [Updated] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak updated LOG4J2-3103: - Fix Version/s: 2.15.0 > ComodificationException in concurrent access to LoggerContext::stop > --

[jira] [Commented] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357426#comment-17357426 ] ASF subversion and git services commented on LOG4J2-3103: - Commi

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #504: LOG4J2-3080 Use SimpleMessage in Log4j 1 Category whenever possible

2021-06-04 Thread GitBox
garydgregory commented on a change in pull request #504: URL: https://github.com/apache/logging-log4j2/pull/504#discussion_r645655510 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/Category.java ## @@ -507,11 +508,27 @@ public void log(final String fqcn, final Prior

[jira] [Commented] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357418#comment-17357418 ] ASF subversion and git services commented on LOG4J2-3103: - Commi

[GitHub] [logging-log4j2] carterkozak merged pull request #508: LOG4J2-3103: Make listeners in LoggerContext a CopyOnWriteArrayList

2021-06-04 Thread GitBox
carterkozak merged pull request #508: URL: https://github.com/apache/logging-log4j2/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[jira] [Assigned] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak reassigned LOG4J2-3103: Assignee: Carter Kozak > ComodificationException in concurrent access to LoggerContext::s

[jira] [Created] (LOG4J2-3103) ComodificationException in concurrent access to LoggerContext::stop

2021-06-04 Thread Mike (Jira)
Mike created LOG4J2-3103: Summary: ComodificationException in concurrent access to LoggerContext::stop Key: LOG4J2-3103 URL: https://issues.apache.org/jira/browse/LOG4J2-3103 Project: Log4j 2 Issue

[GitHub] [logging-log4j2] mglazer opened a new pull request #508: Make listeners in LoggerContext a CopyOnWriteArrayList

2021-06-04 Thread GitBox
mglazer opened a new pull request #508: URL: https://github.com/apache/logging-log4j2/pull/508 This particular case fails quite often in integration tests where you have multiple separate threads potentially creating and destroying the singleton LoggerContext independently. Sinc

[GitHub] [logging-log4j2] carterkozak opened a new pull request #507: LOG4J2-3102: AsyncAppender background thread is a daemon

2021-06-04 Thread GitBox
carterkozak opened a new pull request #507: URL: https://github.com/apache/logging-log4j2/pull/507 https://issues.apache.org/jira/browse/LOG4J2-3102 We didn't preserve the daemon flag in https://github.com/apache/logging-log4j2/pull/452/files#diff-6b30d73942796a35c3bcf93d46127d03cb69

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #506: Make Local variable and parameter final

2021-06-04 Thread GitBox
arturobernalg opened a new pull request #506: URL: https://github.com/apache/logging-log4j2/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[jira] [Assigned] (LOG4J2-3102) Asynchronous Logger WAITS indefinitely after end of main method

2021-06-04 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak reassigned LOG4J2-3102: Assignee: Carter Kozak > Asynchronous Logger WAITS indefinitely after end of main method

[GitHub] [logging-log4j2] carterkozak opened a new pull request #505: Fix incorrect LogManager accessor used by LOG4J2-2940

2021-06-04 Thread GitBox
carterkozak opened a new pull request #505: URL: https://github.com/apache/logging-log4j2/pull/505 The `getContext()` accessor with no args has been used as a fallback for Log4jLoggerFactory slf4j implementations for a while, but it's much more likely to be used now that LOG4J2-2940 is

[jira] [Commented] (LOG4J2-3102) Asynchronous Logger WAITS indefinitely after end of main method

2021-06-04 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357348#comment-17357348 ] Carter Kozak commented on LOG4J2-3102: -- Thanks for the bug report! It looks like w

[jira] [Commented] (LOG4J2-3080) Messages logged inconsistently when using JsonTemplateLayout.

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357240#comment-17357240 ] ASF subversion and git services commented on LOG4J2-3080: - Commi

[GitHub] [logging-log4j2] vy opened a new pull request #504: LOG4J2-3080 Use SimpleMessage in Log4j 1 Category whenever possible

2021-06-04 Thread GitBox
vy opened a new pull request #504: URL: https://github.com/apache/logging-log4j2/pull/504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (LOG4J2-3080) Messages logged inconsistently when using JsonTemplateLayout.

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357236#comment-17357236 ] ASF subversion and git services commented on LOG4J2-3080: - Commi

[jira] [Commented] (LOG4J2-3092) JSON Template Layout JsonWriter formattableBuffer Memory leak

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357197#comment-17357197 ] ASF subversion and git services commented on LOG4J2-3092: - Commi

[jira] [Closed] (LOG4J2-3092) JSON Template Layout JsonWriter formattableBuffer Memory leak

2021-06-04 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-3092. - > JSON Template Layout JsonWriter formattableBuffer Memory leak > --

[jira] [Resolved] (LOG4J2-3092) JSON Template Layout JsonWriter formattableBuffer Memory leak

2021-06-04 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3092. --- Resolution: Fixed > JSON Template Layout JsonWriter formattableBuffer Memory leak >

[jira] [Commented] (LOG4J2-3092) JSON Template Layout JsonWriter formattableBuffer Memory leak

2021-06-04 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357195#comment-17357195 ] Volkan Yazici commented on LOG4J2-3092: --- [~xmh51], thanks for checking and the rep

[jira] [Commented] (LOG4J2-3092) JSON Template Layout JsonWriter formattableBuffer Memory leak

2021-06-04 Thread xmh51 (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357187#comment-17357187 ] xmh51 commented on LOG4J2-3092: --- After checking, the issue _does not_ appear, thanks:D >

[GitHub] [logging-log4j2] vy merged pull request #502: Improvements:

2021-06-04 Thread GitBox
vy merged pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on a change in pull request #502: Improvements:

2021-06-04 Thread GitBox
vy commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644751295 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static FileExtension

[GitHub] [logging-log4j2] arturobernalg commented on a change in pull request #502: Improvements:

2021-06-04 Thread GitBox
arturobernalg commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644923664 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static Fi

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #502: Improvements:

2021-06-04 Thread GitBox
rgoers commented on a change in pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502#discussion_r644304021 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.java ## @@ -95,7 +95,7 @@ public static FileExten

[GitHub] [logging-log4j2] vy merged pull request #502: Improvements:

2021-06-04 Thread GitBox
vy merged pull request #502: URL: https://github.com/apache/logging-log4j2/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please