arturobernalg opened a new pull request #502:
URL: https://github.com/apache/logging-log4j2/pull/502
* Use Standard Charset object
* Remove Unnecessary enum modifier
* Make final var
* Avoid String concat loop. Use StringBuilder
* Remove Unnecessary interface modifier
* Simpli
BUILD FAILURE
Build URL
https://ci-builds.apache.org/job/Logging/job/chainsaw/job/master/24/
Project:
master
Date of build:
Wed, 02 Jun 2021 01:42:00 +
Build duration:
1 min 34 sec and counting
JUnit Tests
Name: org.apache.log4j.chainsaw Failed:
vy merged pull request #501:
URL: https://github.com/apache/logging-log4j2/pull/501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy merged pull request #497:
URL: https://github.com/apache/logging-log4j2/pull/497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy merged pull request #500:
URL: https://github.com/apache/logging-log4j2/pull/500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
arturobernalg opened a new pull request #501:
URL: https://github.com/apache/logging-log4j2/pull/501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about thi
[
https://issues.apache.org/jira/browse/LOG4J2-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354937#comment-17354937
]
Aivaras Dziaugys commented on LOG4J2-3101:
--
[~rgoers] Thank you for clarifying,
rgoers commented on pull request #500:
URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851929320
Unless code is really unreadable I really don't care about cosmetic changes.
Gary loves to rename variables to me more "clear". To me, beauty is in the eye
of the beholder.
[
https://issues.apache.org/jira/browse/LOG4J2-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354925#comment-17354925
]
Ralph Goers commented on LOG4J2-3101:
-
Well, I guess my memory isn't so good. In LOG
[
https://issues.apache.org/jira/browse/LOG4J2-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354925#comment-17354925
]
Ralph Goers edited comment on LOG4J2-3101 at 6/1/21, 8:14 AM:
vy merged pull request #499:
URL: https://github.com/apache/logging-log4j2/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
vy commented on pull request #499:
URL: https://github.com/apache/logging-log4j2/pull/499#issuecomment-851891854
Thanks @arturobernalg!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
vy commented on pull request #500:
URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851889225
@rgoers, from a performance perspective, I indeed don't expect any
difference. This said, I agree with @arturobernalg on readability. If that is
okay with you, I want to merge t
vy merged pull request #498:
URL: https://github.com/apache/logging-log4j2/pull/498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
14 matches
Mail list logo
