[jira] [Reopened] (LOG4J2-3101) SizeBasedTriggeringPolicy does not update date on rollover

2021-05-31 Thread Aivaras Dziaugys (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aivaras Dziaugys reopened LOG4J2-3101: -- Solution suggested in comment does not work, documentation contradicts the response comme

[jira] [Commented] (LOG4J2-3101) SizeBasedTriggeringPolicy does not update date on rollover

2021-05-31 Thread Aivaras Dziaugys (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354793#comment-17354793 ] Aivaras Dziaugys commented on LOG4J2-3101: -- [~rgoers] If it is intended behavio

[GitHub] [logging-log4j2] rgoers commented on pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-05-31 Thread GitBox
rgoers commented on pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851704246 If I thought it was is easier or would result in a performance gain I wouldn't have asked the question. -- This is an automated message from the Apache Git Service. To res

[GitHub] [logging-log4j2] arturobernalg edited a comment on pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-05-31 Thread GitBox
arturobernalg edited a comment on pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851630497 > What is the benefit of this change? The current code seems pretty clear and efficient. HI @rgoers Don't you think it's more easy to read and unders

[GitHub] [logging-log4j2] arturobernalg commented on pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-05-31 Thread GitBox
arturobernalg commented on pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500#issuecomment-851630497 > What is the benefit of this change? The current code seems pretty clear and efficient. HI @rgoers Don't you think it's more easy to read and understand wh

[jira] [Resolved] (LOG4J2-3101) SizeBasedTriggeringPolicy does not update date on rollover

2021-05-31 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-3101. - Resolution: Invalid It is invalid to specify %d{} in a file pattern that only uses the SizeBase

[jira] [Commented] (LOG4J2-3096) Custom filters don't work when used context-wide

2021-05-31 Thread Mauricio lopez (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354516#comment-17354516 ] Mauricio lopez commented on LOG4J2-3096: Many, many thanks Ralph! All good! > C

[jira] [Updated] (LOG4J2-3101) SizeBasedTriggeringPolicy does not update date on rollover

2021-05-31 Thread Aivaras Dziaugys (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aivaras Dziaugys updated LOG4J2-3101: - Description: Using _RollingFile_ appender with _SizeBasedTriggeringPolicy_ does not upda

[jira] [Created] (LOG4J2-3101) SizeBasedTriggeringPolicy does not update date on rollover

2021-05-31 Thread Aivaras Dziaugys (Jira)
Aivaras Dziaugys created LOG4J2-3101: Summary: SizeBasedTriggeringPolicy does not update date on rollover Key: LOG4J2-3101 URL: https://issues.apache.org/jira/browse/LOG4J2-3101 Project: Log4j 2

[jira] [Commented] (LOG4J2-3040) ShutdownCallbackRegistry should be part of log4j-api, not log4j-core

2021-05-31 Thread Grzegorz Grzybek (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354357#comment-17354357 ] Grzegorz Grzybek commented on LOG4J2-3040: -- Thanks for answer [~rgoers]. Feel f

[GitHub] [logging-log4j2] arturobernalg opened a new pull request #500: Use Math.max() or Math.min() instead of doing it manually

2021-05-31 Thread GitBox
arturobernalg opened a new pull request #500: URL: https://github.com/apache/logging-log4j2/pull/500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[jira] [Commented] (LOG4J2-3098) DelectAction malfunctioning when filePattern uses archive path with year and month

2021-05-31 Thread TIAGO CAVALEIRO (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354334#comment-17354334 ] TIAGO CAVALEIRO commented on LOG4J2-3098: - Appreciate the quick reply [~rgoers]

[GitHub] [logging-log4j2] arturobernalg commented on pull request #498: Replace assert calls with simpler but equivalent calls.

2021-05-31 Thread GitBox
arturobernalg commented on pull request #498: URL: https://github.com/apache/logging-log4j2/pull/498#issuecomment-851352035 > Thanks so much for these improvements @arturobernalg! I have requested two changes for using `Set`-based comparison. If you don't feel like fixing them, let me know

[jira] [Commented] (LOG4J2-3098) DelectAction malfunctioning when filePattern uses archive path with year and month

2021-05-31 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354310#comment-17354310 ] Volkan Yazici commented on LOG4J2-3098: --- [~rgoers], is this subtle behavior alread

[jira] [Updated] (LOG4J2-3098) DelectAction malfunctioning when filePattern uses archive path with year and month

2021-05-31 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3098: -- Component/s: Appenders > DelectAction malfunctioning when filePattern uses archive path with y

[GitHub] [logging-log4j2] vy commented on a change in pull request #498: Replace assert calls with simpler but equivalent calls.

2021-05-31 Thread GitBox
vy commented on a change in pull request #498: URL: https://github.com/apache/logging-log4j2/pull/498#discussion_r642319968 ## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTempCompressedFilePatternTest.java ## @@ -147,8 +148

[GitHub] [logging-log4j2] arturobernalg commented on pull request #497: log4j-api - Minor improvements:

2021-05-31 Thread GitBox
arturobernalg commented on pull request #497: URL: https://github.com/apache/logging-log4j2/pull/497#issuecomment-851324163 > Thanks for your contribution @arturobernalg! Really appreciated! If you address the small remarks I have raised, I can merge your changes. HI @vy Thank yo

[GitHub] [logging-log4j2] vy commented on a change in pull request #497: log4j-api - Minor improvements:

2021-05-31 Thread GitBox
vy commented on a change in pull request #497: URL: https://github.com/apache/logging-log4j2/pull/497#discussion_r642304654 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/spi/MutableThreadContextStack.java ## @@ -231,13 +230,10 @@ public boolean equals(final Ob

[jira] [Commented] (LOG4J2-3094) How to use log4j2 to send syslog to multiple addresses and ports.

2021-05-31 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354264#comment-17354264 ] Volkan Yazici commented on LOG4J2-3094: --- [~angelyouyou], would you mind closing th

[jira] [Commented] (LOG4J2-3095) Category.setLevel should accept null value

2021-05-31 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354262#comment-17354262 ] Volkan Yazici commented on LOG4J2-3095: --- [~kennymacleod.atl], would you mind closi