[jira] [Commented] (LOG4J2-3086) Kotlin logging interface mixin is very slow

2021-05-02 Thread Raman Gupta (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338196#comment-17338196 ] Raman Gupta commented on LOG4J2-3086: - https://github.com/apache/logging-log4j-kotli

[GitHub] [logging-log4j-kotlin] rocketraman opened a new pull request #19: Add caching for logger lookups via interface mixin

2021-05-02 Thread GitBox
rocketraman opened a new pull request #19: URL: https://github.com/apache/logging-log4j-kotlin/pull/19 I realized the mixin was super-slow because the property delegate creates a new logger every time it is used. See https://issues.apache.org/jira/browse/LOG4J2-3086. The only workar

[jira] [Created] (LOG4J2-3086) Kotlin logging interface mixin is very slow

2021-05-02 Thread Raman Gupta (Jira)
Raman Gupta created LOG4J2-3086: --- Summary: Kotlin logging interface mixin is very slow Key: LOG4J2-3086 URL: https://issues.apache.org/jira/browse/LOG4J2-3086 Project: Log4j 2 Issue Type: Impro

[GitHub] [logging-log4j-kotlin] rocketraman edited a comment on pull request #17: Kotlin provided scope

2021-05-02 Thread GitBox
rocketraman edited a comment on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830980096 @jvz No idea why CI is failing but its not limited to this branch. The other PRs I recently submitted failed with the same non-error. -- This is an automa

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #17: Kotlin provided scope

2021-05-02 Thread GitBox
rocketraman commented on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830980096 @jvz No idea why CI is failing but its not limited to this branch. The other PRs I recently submitted failed with the same error. -- This is an automated message

[jira] [Commented] (LOG4J2-2816) NullPointerException from AsyncLogger

2021-05-02 Thread Jacob Shields (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338136#comment-17338136 ] Jacob Shields commented on LOG4J2-2816: --- The previous PR was based off of {{master

[GitHub] [logging-log4j2] jacobrshields edited a comment on pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions (3.x)

2021-05-02 Thread GitBox
jacobrshields edited a comment on pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487#issuecomment-830916668 Thanks for the quick response, Gary. To clarify, the build passes locally. The failure is on the CI build. I would expect the CI build to work independently of

[GitHub] [logging-log4j2] jacobrshields closed pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions (3.x)

2021-05-02 Thread GitBox
jacobrshields closed pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [logging-log4j2] jacobrshields commented on pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions (3.x)

2021-05-02 Thread GitBox
jacobrshields commented on pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487#issuecomment-830916668 Thanks for the quick response, Gary. To clarify, the build passes locally. The failure is on the CI build. I would expect the CI build to work regardless of my own Ma

[GitHub] [logging-log4j2] jacobrshields opened a new pull request #488: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-05-02 Thread GitBox
jacobrshields opened a new pull request #488: URL: https://github.com/apache/logging-log4j2/pull/488 [LOG4J2-2816](https://issues.apache.org/jira/browse/LOG4J2-2816) # Problem If `RingBufferLogEventTranslator#translateTo` throws an exception for any reason, Disruptor's `RingBu

[GitHub] [logging-log4j2] garydgregory commented on pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-05-02 Thread GitBox
garydgregory commented on pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487#issuecomment-830871192 If you want this fix for the 2.x line, master is the wrong branch as it will become 3.0.0. The 2.x line is from release-2.x. Check your Maven toolchain XML file, it mi

[jira] [Commented] (LOG4J2-2816) NullPointerException from AsyncLogger

2021-05-02 Thread Jacob Shields (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338120#comment-17338120 ] Jacob Shields commented on LOG4J2-2816: --- I finally cleared the Corporate CLA with

[GitHub] [logging-log4j2] jacobrshields commented on pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-05-02 Thread GitBox
jacobrshields commented on pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487#issuecomment-830869512 CI is failing with this error. Any ideas how to fix this? ``` [ERROR] javac: invalid flag: --release ``` -- This is an automated message from the Apache

[GitHub] [logging-log4j2] jacobrshields opened a new pull request #487: LOG4J2-2816: Handle Disruptor event translation exceptions

2021-05-02 Thread GitBox
jacobrshields opened a new pull request #487: URL: https://github.com/apache/logging-log4j2/pull/487 # Problem If `RingBufferLogEventTranslator#translateTo` throws an exception for any reason, Disruptor's `RingBuffer#translateAndPublish` will still publish the sequence in a `finally

[GitHub] [logging-log4j-kotlin] rocketraman merged pull request #18: Remove deprecated jcenter repo

2021-05-02 Thread GitBox
rocketraman merged pull request #18: URL: https://github.com/apache/logging-log4j-kotlin/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4j-kotlin] rocketraman merged pull request #15: Throwables params should always be nullable

2021-05-02 Thread GitBox
rocketraman merged pull request #15: URL: https://github.com/apache/logging-log4j-kotlin/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4j-kotlin] rocketraman merged pull request #16: Fix missing traceEntry call for runInTrace

2021-05-02 Thread GitBox
rocketraman merged pull request #16: URL: https://github.com/apache/logging-log4j-kotlin/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [logging-log4j-kotlin] jvz commented on pull request #17: Kotlin provided scope

2021-05-02 Thread GitBox
jvz commented on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830836699 If you don't have a "re-run" link on the GitHub Check, then try adding an empty commit or possibly closing then reopening the PR to retrigger CI. -- This is an automated

[GitHub] [logging-log4j-kotlin] rocketraman commented on pull request #17: Kotlin provided scope

2021-05-02 Thread GitBox
rocketraman commented on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830834412 > Seems like a good idea. Are there CI updates needed here, though? Some build failure. Weird I'm not seeing any errors in the build logs, just the abort at

[GitHub] [logging-log4j-kotlin] jvz commented on pull request #17: Kotlin provided scope

2021-05-02 Thread GitBox
jvz commented on pull request #17: URL: https://github.com/apache/logging-log4j-kotlin/pull/17#issuecomment-830830676 Seems like a good idea. Are there CI updates needed here, though? Some build failure. -- This is an automated message from the Apache Git Service. To respond to the mess