[GitHub] [logging-log4cxx] nturner commented on pull request #62: GZCompressAction: leave file uncompressed if fork of gzip fails

2021-04-17 Thread GitBox
nturner commented on pull request #62: URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821885212 Sorry, that was an older patch. Here's the same commit on my local 0.11.0 branch: diff --git a/src/examples/cpp/trivial.cpp b/src/examples/cpp/trivial.cpp index 6

[GitHub] [logging-log4cxx] nturner commented on pull request #62: GZCompressAction: leave file uncompressed if fork of gzip fails

2021-04-17 Thread GitBox
nturner commented on pull request #62: URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821884895 Here's the patch I made to the the "trivial" example test program to facilitate testing: diff --git a/src/examples/cpp/trivial.cpp b/src/examples/cpp/trivial.cpp

[GitHub] [logging-log4cxx] nturner commented on pull request #62: GZCompressAction: leave file uncompressed if fork of gzip fails

2021-04-17 Thread GitBox
nturner commented on pull request #62: URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821884724 Here's the minimal test config I used when validating this change (by hand): $ cat src/examples/cpp/trace-rolling.xml http://jakarta.apache.org/log4j/";>

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #63: Use new LOG4CXX_SOURCE_DIR in the event that this is not the top-leve…

2021-04-17 Thread GitBox
ams-tschoening commented on a change in pull request #63: URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615268201 ## File path: CMakeLists.txt ## @@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake) project(log4cxx VERSION ${log4cxx_VER} LANGUAG

[jira] [Resolved] (LOG4J2-2737) Broken link for apache-log4j-2.12.1-bin.tar.gz

2021-04-17 Thread Sebb (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved LOG4J2-2737. -- Resolution: Fixed Seems to have been fixed > Broken link for apache-log4j-2.12.1-bin.tar.gz > ---

[jira] [Created] (LOG4J2-3076) Broken link to Wiki

2021-04-17 Thread Sebb (Jira)
Sebb created LOG4J2-3076: Summary: Broken link to Wiki Key: LOG4J2-3076 URL: https://issues.apache.org/jira/browse/LOG4J2-3076 Project: Log4j 2 Issue Type: Bug Reporter: Sebb https://lo

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #63: Use new LOG4CXX_SOURCE_DIR in the event that this is not the top-leve…

2021-04-17 Thread GitBox
swebb2066 commented on a change in pull request #63: URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615247287 ## File path: CMakeLists.txt ## @@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake) project(log4cxx VERSION ${log4cxx_VER} LANGUAGES CX

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #63: Use new LOG4CXX_SOURCE_DIR in the event that this is not the top-leve…

2021-04-17 Thread GitBox
rm5248 commented on a change in pull request #63: URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615247114 ## File path: CMakeLists.txt ## @@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake) project(log4cxx VERSION ${log4cxx_VER} LANGUAGES CXX)

[GitHub] [logging-log4cxx] swebb2066 commented on a change in pull request #63: Use new LOG4CXX_SOURCE_DIR in the event that this is not the top-leve…

2021-04-17 Thread GitBox
swebb2066 commented on a change in pull request #63: URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615246571 ## File path: CMakeLists.txt ## @@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake) project(log4cxx VERSION ${log4cxx_VER} LANGUAGES CX

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #63: Use new LOG4CXX_SOURCE_DIR in the event that this is not the top-leve…

2021-04-17 Thread GitBox
ams-tschoening commented on a change in pull request #63: URL: https://github.com/apache/logging-log4cxx/pull/63#discussion_r615231666 ## File path: CMakeLists.txt ## @@ -3,6 +3,11 @@ include(src/cmake/projectVersionDetails.cmake) project(log4cxx VERSION ${log4cxx_VER} LANGUAG

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #62: GZCompressAction: leave file uncompressed if fork of gzip fails

2021-04-17 Thread GitBox
ams-tschoening commented on pull request #62: URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-821788124 @nturner How did you configure using compression, programmatically or using XML configs? In the latter case, please provide your example here or in linke [JIRA](https