[GitHub] [logging-log4j2] wuqian0808 commented on pull request #428: Avoid kafka thread leak - LOG4J2-2916

2020-11-08 Thread GitBox
wuqian0808 commented on pull request #428: URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-723732760 @rgoers Could u help to advise? Or is there anything else should I do? This is an automated message from

[jira] [Commented] (LOG4J2-2850) LocalizedMessageFactory creates new message with baseName as messagePattern

2020-11-08 Thread Sandeep Barnwal (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228012#comment-17228012 ] Sandeep Barnwal commented on LOG4J2-2850: - Pull Request  : [https://github.com/a

[GitHub] [logging-log4j2] sandeepbarnwal opened a new pull request #436: OG4J2-2850: LocalizedMessageFactory creates new message with baseName as messagePattern

2020-11-08 Thread GitBox
sandeepbarnwal opened a new pull request #436: URL: https://github.com/apache/logging-log4j2/pull/436 newMessage method in LocalizedMessageFactory uses incorrect constructor. it creates the new message with baseName as messagePattern. I have changed it to point to the appropriate construct

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #428: Avoid kafka thread leak - LOG4J2-2916

2020-11-08 Thread GitBox
wuqian0808 commented on pull request #428: URL: https://github.com/apache/logging-log4j2/pull/428#issuecomment-723548897 > @wuqian0808 could you fix the filename of the test file? Without the .java extension, I'm pretty sure the compiler or Maven will complain. File name changed --