[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #425: Update KafkaManager.java

2020-09-21 Thread GitBox
gengyuanzhe commented on pull request #425: URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623 In my opition, `org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close the kafka producer when `reconfigure()`. The `close()` should not be invok

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-21 Thread GitBox
gengyuanzhe commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695798876 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [logging-log4j2] jvz commented on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-21 Thread GitBox
jvz commented on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695817855 The failed tests are flaky from before and unrelated to this PR. This is an automated message from the Apache G

[GitHub] [logging-log4cxx] rm5248 merged pull request #41: Don't remove generated files on clean

2020-09-21 Thread GitBox
rm5248 merged pull request #41: URL: https://github.com/apache/logging-log4cxx/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] gengyuanzhe edited a comment on pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-21 Thread GitBox
gengyuanzhe edited a comment on pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#issuecomment-695747057 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [logging-log4j2] jvz commented on pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-21 Thread GitBox
jvz commented on pull request #423: URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695821455 Nothing left for you as far as I can tell. We can see if anyone else wants to review before merging. I'm currently working on some build-related fixes/improvements before I mer

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #425: Update KafkaManager.java

2020-09-21 Thread GitBox
wuqian0808 commented on pull request #425: URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696016546 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-21 Thread GitBox
gengyuanzhe commented on pull request #423: URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695820947 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [logging-log4j2] gengyuanzhe edited a comment on pull request #425: Update KafkaManager.java

2020-09-21 Thread GitBox
gengyuanzhe edited a comment on pull request #425: URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623 In my opition, `org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close the kafka producer when `reconfigure()`. The `close()` should not b

[jira] [Commented] (LOG4J2-2932) Under OSGi Log4j uses brute force to scan for plugins causing multiple issues

2020-09-21 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199585#comment-17199585 ] Ralph Goers commented on LOG4J2-2932: - None of the active committers use OSGi much s

[jira] [Created] (LOG4J2-2932) Under OSGi Log4j uses brute force to scan for plugins causing multiple issues

2020-09-21 Thread Todor Boev (Jira)
Todor Boev created LOG4J2-2932: -- Summary: Under OSGi Log4j uses brute force to scan for plugins causing multiple issues Key: LOG4J2-2932 URL: https://issues.apache.org/jira/browse/LOG4J2-2932 Project: L

[jira] [Commented] (LOG4J2-2930) Add plugin for encrypting/decrypting log events

2020-09-21 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199556#comment-17199556 ] Matt Sicker commented on LOG4J2-2930: - Potentially useful library: https://github.co

[jira] [Comment Edited] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199537#comment-17199537 ] Geng Yuanzhe edited comment on LOG4J2-2918 at 9/21/20, 5:21 PM: --

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199537#comment-17199537 ] Geng Yuanzhe commented on LOG4J2-2918: -- [~dennysfredericci] You can try the follow

[jira] [Comment Edited] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199491#comment-17199491 ] Geng Yuanzhe edited comment on LOG4J2-2918 at 9/21/20, 5:17 PM: --

[jira] [Comment Edited] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199491#comment-17199491 ] Geng Yuanzhe edited comment on LOG4J2-2918 at 9/21/20, 5:17 PM: --

[GitHub] [logging-log4j2] gengyuanzhe edited a comment on pull request #425: Update KafkaManager.java

2020-09-21 Thread GitBox
gengyuanzhe edited a comment on pull request #425: URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623 In my opition, `org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close the kafka producer when `reconfigure()`. The `close()` should not b

[jira] [Comment Edited] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199491#comment-17199491 ] Geng Yuanzhe edited comment on LOG4J2-2918 at 9/21/20, 5:17 PM: --

[jira] [Comment Edited] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199491#comment-17199491 ] Geng Yuanzhe edited comment on LOG4J2-2918 at 9/21/20, 4:43 PM: --

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199491#comment-17199491 ] Geng Yuanzhe commented on LOG4J2-2918: -- The reason is for AsyncLoggerConfig, the fi

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199479#comment-17199479 ] Ralph Goers commented on LOG4J2-2918: - That will reconfigure using the configuration

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199469#comment-17199469 ] Matt Sicker commented on LOG4J2-2918: - Can you try calling {{LoggerContext.reconfigu

[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #425: Update KafkaManager.java

2020-09-21 Thread GitBox
gengyuanzhe commented on pull request #425: URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696154623 In my opition, `org.apache.logging.log4j.kafka.appender.KafkaManager#releaseSub` should close the kafka producer when `reconfigure()`. The `close()` should not be invok

[jira] [Updated] (LOG4J2-2931) Configuring CompositeFilter via properties will generate error due to invalid arguments

2020-09-21 Thread Oliver Limberg (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Limberg updated LOG4J2-2931: --- Description: The attached test will produce the following errors: {noformat} ERROR filters c

[jira] [Updated] (LOG4J2-2931) Configuring CompositeFilter via properties will generate error due to invalid arguments

2020-09-21 Thread Oliver Limberg (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Limberg updated LOG4J2-2931: --- Description: The attached test will produce the following errors:   {noformat} ERROR filter

[jira] [Created] (LOG4J2-2931) Configuring CompositeFilter via properties will generate error due to invalid arguments

2020-09-21 Thread Oliver Limberg (Jira)
Oliver Limberg created LOG4J2-2931: -- Summary: Configuring CompositeFilter via properties will generate error due to invalid arguments Key: LOG4J2-2931 URL: https://issues.apache.org/jira/browse/LOG4J2-2931

[GitHub] [logging-log4j2] wuqian0808 commented on pull request #425: Update KafkaManager.java

2020-09-21 Thread GitBox
wuqian0808 commented on pull request #425: URL: https://github.com/apache/logging-log4j2/pull/425#issuecomment-696016546 Configure kafkaappender in log4j2.xml, then call below steps serveral times. The kafka thread will increase. LoggerContext.getContext(false).reconfigure();

[GitHub] [logging-log4j2] wuqian0808 opened a new pull request #425: Update KafkaManager.java

2020-09-21 Thread GitBox
wuqian0808 opened a new pull request #425: URL: https://github.com/apache/logging-log4j2/pull/425 Avoid kafka thread leak during loggercontext reconfigure multiple times. This is an automated message from the Apache Git Servi

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-21 Thread Dennys Fredericci (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199270#comment-17199270 ] Dennys Fredericci commented on LOG4J2-2918: --- Hi All, If we don't call the {{C