[jira] [Comment Edited] (LOG4J2-2909) Version Upgrade of log4j2 jars from 2.10.0 to 2.13.2 cause TPS degradation

2020-09-18 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198666#comment-17198666 ] Ralph Goers edited comment on LOG4J2-2909 at 9/19/20, 6:14 AM: ---

[jira] [Commented] (LOG4J2-2909) Version Upgrade of log4j2 jars from 2.10.0 to 2.13.2 cause TPS degradation

2020-09-18 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198666#comment-17198666 ] Ralph Goers commented on LOG4J2-2909: - I will say it one more time.  Log4j 2's log4j

[GitHub] [logging-log4j2] gengyuanzhe commented on a change in pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-18 Thread GitBox
gengyuanzhe commented on a change in pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491272078 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java ## @@ -345,14 +355,17 @@ public static HtmlLayout cr

[GitHub] [logging-log4j2] gengyuanzhe commented on a change in pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-18 Thread GitBox
gengyuanzhe commented on a change in pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491272078 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java ## @@ -345,14 +355,17 @@ public static HtmlLayout cr

[GitHub] [logging-log4j2] gengyuanzhe commented on a change in pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-18 Thread GitBox
gengyuanzhe commented on a change in pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491272078 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java ## @@ -345,14 +355,17 @@ public static HtmlLayout cr

[CI][UNSTABLE] Logging/log4j/master#160 has test failures

2020-09-18 Thread Mr. Jenkins
BUILD UNSTABLE Build URL https://ci-builds.apache.org/job/Logging/job/log4j/job/master/160/ Project: master Date of build: Fri, 18 Sep 2020 22:05:04 + Build duration: 1 hr 18 min and counting JUnit Tests Name: liquibase.ext.logging.log4j2 Failed:

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-18 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198572#comment-17198572 ] Ralph Goers commented on LOG4J2-2918: - This is a user error Matt. You cannot call re

[GitHub] [logging-log4j2] jvz commented on a change in pull request #392: [LOG4J2-2902] Add missing LoaderUtil permissions check

2020-09-18 Thread GitBox
jvz commented on a change in pull request #392: URL: https://github.com/apache/logging-log4j2/pull/392#discussion_r491215413 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/util/LoaderUtilTest.java ## @@ -55,4 +63,53 @@ public void systemClassLoader() {

[GitHub] [logging-log4j2] jvz commented on a change in pull request #392: [LOG4J2-2902] Add missing LoaderUtil permissions check

2020-09-18 Thread GitBox
jvz commented on a change in pull request #392: URL: https://github.com/apache/logging-log4j2/pull/392#discussion_r491215215 ## File path: log4j-api/src/test/java/org/apache/logging/log4j/util/LoaderUtilTest.java ## @@ -55,4 +63,53 @@ public void systemClassLoader() {

[GitHub] [logging-log4j2] jvz commented on pull request #420: (doc) Fix typos in manual

2020-09-18 Thread GitBox
jvz commented on pull request #420: URL: https://github.com/apache/logging-log4j2/pull/420#issuecomment-695107002 Thanks for the PR! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [logging-log4j2] jvz merged pull request #420: (doc) Fix typos in manual

2020-09-18 Thread GitBox
jvz merged pull request #420: URL: https://github.com/apache/logging-log4j2/pull/420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [logging-log4j2] jvz commented on a change in pull request #419: [LOG4J2-2889] HtmlLayout support datePattern and timezone

2020-09-18 Thread GitBox
jvz commented on a change in pull request #419: URL: https://github.com/apache/logging-log4j2/pull/419#discussion_r491213545 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/layout/HtmlLayout.java ## @@ -345,14 +355,17 @@ public static HtmlLayout createLayo

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-18 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198559#comment-17198559 ] Matt Sicker commented on LOG4J2-2918: - And yes, it does seem like there's some unexp

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-18 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198558#comment-17198558 ] Matt Sicker commented on LOG4J2-2918: - Based on the way the unit tests work in log4j

[jira] [Assigned] (LOG4J2-2927) ErrorHandlers on Appenders cannot be configured.

2020-09-18 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers reassigned LOG4J2-2927: --- Assignee: Ralph Goers > ErrorHandlers on Appenders cannot be configured. >

[jira] [Created] (LOG4J2-2927) ErrorHandlers on Appenders cannot be configured.

2020-09-18 Thread Ralph Goers (Jira)
Ralph Goers created LOG4J2-2927: --- Summary: ErrorHandlers on Appenders cannot be configured. Key: LOG4J2-2927 URL: https://issues.apache.org/jira/browse/LOG4J2-2927 Project: Log4j 2 Issue Type:

[jira] [Created] (LOG4NET-651) Installed log4net 2.0.10 version through nuget manager, in my package dll product version display as 2.0.9.

2020-09-18 Thread Senthil Kumar Kuthalingam (Jira)
Senthil Kumar Kuthalingam created LOG4NET-651: - Summary: Installed log4net 2.0.10 version through nuget manager, in my package dll product version display as 2.0.9. Key: LOG4NET-651 URL: https://issues

[jira] [Commented] (LOG4J2-2913) Bundle Lookup Bug

2020-09-18 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198287#comment-17198287 ] Geng Yuanzhe commented on LOG4J2-2913: -- Can you provide the complete *log4j2.xml co

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-18 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198272#comment-17198272 ] Geng Yuanzhe commented on LOG4J2-2918: -- [~mattsicker] should we add some code that

[GitHub] [logging-log4net] NicholasNoise commented on pull request #67: Fix CA2000, CA2237, CA3075

2020-09-18 Thread GitBox
NicholasNoise commented on pull request #67: URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694766793 @fluffynuts Is 2.0.11 planned to release any time soon? This is an automated message from the

[GitHub] [logging-log4net] NicholasNoise commented on pull request #67: Fix CA2000, CA2237, CA3075

2020-09-18 Thread GitBox
NicholasNoise commented on pull request #67: URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694750050 I prefer spaces too by its _looks-the-same-everywhere_ feature. > StyleCop isn't enough StyleCop and FxCop grant a build validation with right ruleset (SA1

[jira] [Comment Edited] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-18 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198189#comment-17198189 ] Geng Yuanzhe edited comment on LOG4J2-2918 at 9/18/20, 8:47 AM: --

[jira] [Commented] (LOG4J2-2918) NPE on reconfigure method call with async configuration

2020-09-18 Thread Geng Yuanzhe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198189#comment-17198189 ] Geng Yuanzhe commented on LOG4J2-2918: -- I've test your case, and you should just re

[GitHub] [logging-log4net] fluffynuts merged pull request #67: Fix CA2000, CA2237, CA3075

2020-09-18 Thread GitBox
fluffynuts merged pull request #67: URL: https://github.com/apache/logging-log4net/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [logging-log4net] fluffynuts commented on pull request #67: Fix CA2000, CA2237, CA3075

2020-09-18 Thread GitBox
fluffynuts commented on pull request #67: URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-694708069 hm, I don't mind, really, what style is adopted -- in the file where I saw whitespace changes, it looked like the original code was spaces and your changes were tabs. Now