[
https://issues.apache.org/jira/browse/LOG4J2-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192677#comment-17192677
]
Ali Murtaza commented on LOG4J2-2909:
-
Hi [~rgoers],
Can we schedule a meeting on t
[
https://issues.apache.org/jira/browse/LOG4J2-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geng Yuanzhe updated LOG4J2-2919:
-
Description:
Hi Team,
I found a problem where LOG4J2-1121 try to fix, but left the scenario fo
[
https://issues.apache.org/jira/browse/LOG4J2-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192671#comment-17192671
]
Geng Yuanzhe commented on LOG4J2-2919:
--
Hi, [~rpopma] [~rgoers]
I found the LOG4J2
[
https://issues.apache.org/jira/browse/LOG4J2-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geng Yuanzhe updated LOG4J2-2919:
-
Description:
Hi Team,
I found a problem where LOG4J2-1121 try to fix, but left the scenario fo
[
https://issues.apache.org/jira/browse/LOG4J2-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geng Yuanzhe updated LOG4J2-2919:
-
Description:
Hi Team,
I found a problem where LOG4J2-1121 try to fix, but left the scenario fo
[
https://issues.apache.org/jira/browse/LOG4J2-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geng Yuanzhe updated LOG4J2-2919:
-
Description:
Hi Team, I found
I found a *concurrent* bug when reading the source code of lo
[
https://issues.apache.org/jira/browse/LOG4J2-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geng Yuanzhe updated LOG4J2-2919:
-
Description:
Hi Team,
I found a *concurrent* bug when reading the source code of log4j2-c
[
https://issues.apache.org/jira/browse/LOG4J2-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192651#comment-17192651
]
Ali Murtaza edited comment on LOG4J2-2909 at 9/9/20, 6:19 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192651#comment-17192651
]
Ali Murtaza edited comment on LOG4J2-2909 at 9/9/20, 6:19 AM:
[
https://issues.apache.org/jira/browse/LOG4J2-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192651#comment-17192651
]
Ali Murtaza commented on LOG4J2-2909:
-
Hi [~rgoers]
This is the maximum we can get
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689067307
If you're able to write a unit test that would fail without your PR and
passes with your PR, that would help a lot in preventing regressions.
Otherwise, one or more of the comm
fluffynuts commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-689052738
LGTM; when I have a moment, I'd like to pull down to my machine & build
again to double-check; I'm taking a day off from work tomorrow, so perhaps
Thursday (:
-
gengyuanzhe commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-689044288
@jvz Truly appreciate your reply. I'm newer for this project. I wonder what
should I do next for this PR or issue?
--
gengyuanzhe edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688581496
@rgoers @jvz Can you help me review my PR? And CI maven build failed, does
it matter? I build the code **without my commit** and get the same test error.
-
jvz commented on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688978041
Right, those test failures are caused by a commit I made yesterday or two
days ago that I need to revert (haven't had a chance to do so yet). As long as
your PR isn't introduci
gengyuanzhe edited a comment on pull request #416:
URL: https://github.com/apache/logging-log4j2/pull/416#issuecomment-688581496
@rgoers @jvz Can you help me review my pr? And CI maven build failed, does
it matter? I build the code **without my commit** and get the same test error.
-
NicholasNoise commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688843984
> @cremor
>
> Some of those are the same as are now manually defined in the
log4net.csproj and some are different. This might be confusing for developers
who d
cremor commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688832079
Not directly related to this PR, but since you are modifying the
preprocessor symbols (constants) here I thought I should mention this:
SDK style projects already define va
NicholasNoise commented on a change in pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#discussion_r484872716
##
File path: src/log4net/Appender/FileAppender.cs
##
@@ -1409,7 +1429,10 @@ virtual protected void OpenFile(string fileName, bool
append)
NicholasNoise commented on pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67#issuecomment-688829338
@fluffynuts
This is an automated message from the Apache Git Service.
To respond to the message, plea
NicholasNoise commented on pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66#issuecomment-688829374
@fluffynuts
This is an automated message from the Apache Git Service.
To respond to the message, plea
NicholasNoise opened a new pull request #67:
URL: https://github.com/apache/logging-log4net/pull/67
Fix CA2000, CA2237, CA3075
This is an automated message from the Apache Git Service.
To respond to the message, please log on
NicholasNoise opened a new pull request #66:
URL: https://github.com/apache/logging-log4net/pull/66
ams-tschoening commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r484703370
##
File path: .gitattributes
##
@@ -0,0 +1 @@
+* text eol=lf
Review comment:
Looking at the docs, this setting doesn't support the spec
24 matches
Mail list logo
