[GitHub] [logging-log4net] fluffynuts commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-03 Thread GitBox
fluffynuts commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-686943609 @NicholasNoise please have a look over the changes I've made to see that you're happy with them. Also, since I know building for the older targets can be a mission,

[jira] [Comment Edited] (LOGCXX-510) Build problems using CMAKE and Visual Studio 2019 Community

2020-09-03 Thread Robert Middleton (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190471#comment-17190471 ] Robert Middleton edited comment on LOGCXX-510 at 9/4/20, 1:51 AM: -

[jira] [Commented] (LOGCXX-510) Build problems using CMAKE and Visual Studio 2019 Community

2020-09-03 Thread Robert Middleton (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190471#comment-17190471 ] Robert Middleton commented on LOGCXX-510: - I tried this out on my side, and somet

[jira] [Commented] (LOGCXX-504) vcpkg build integration

2020-09-03 Thread Robert Middleton (Jira)
[ https://issues.apache.org/jira/browse/LOGCXX-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190469#comment-17190469 ] Robert Middleton commented on LOGCXX-504: - Looking into some vcpkg stuff shows th

[GitHub] [logging-log4cxx] rm5248 merged pull request #35: Changed some docs and model dependencies for tests etc. using MVN.

2020-09-03 Thread GitBox
rm5248 merged pull request #35: URL: https://github.com/apache/logging-log4cxx/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4net] triumlabs opened a new pull request #65: Fix: RollingFileAppender does not work on Android and iOS

2020-09-03 Thread GitBox
triumlabs opened a new pull request #65: URL: https://github.com/apache/logging-log4net/pull/65 However netstandard contains cross-process Mutex, Android and iOS platform does not support it. Therefore, current implementation of RollingFileAppender cannot be used on these platforms.

[GitHub] [logging-log4net] cremor commented on pull request #59: Update build system

2020-09-03 Thread GitBox
cremor commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-686390781 I'm using the `DebugAppender` to get my logs to the Visual Studio output window. This works fine for me (both with the old .NET Standard 1.3 log4net assembly and with the new

[GitHub] [logging-log4net] NicholasNoise commented on pull request #59: Update build system

2020-09-03 Thread GitBox
NicholasNoise commented on pull request #59: URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-686386567 > Ok, the breaking change for the removed `ImmediateFlush` property in .NET Standard 1.3 is not fixed. But I think that's ok since it was not functional anyway.

[GitHub] [logging-log4net] NicholasNoise edited a comment on pull request #63: Implemented proper support of netstandard2.0

2020-09-03 Thread GitBox
NicholasNoise edited a comment on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-686364191 > > Yes, it's a PITA to get the environment required to build all targets (I've not only done it more than once, but struggled to find off-premise CI to do

[GitHub] [logging-log4net] NicholasNoise commented on pull request #63: Implemented proper support of netstandard2.0

2020-09-03 Thread GitBox
NicholasNoise commented on pull request #63: URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-686364191 > > Yes, it's a PITA to get the environment required to build all targets (I've not only done it more than once, but struggled to find off-premise CI to do so!) --