rgoers commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-686268036
Thanks. Those should be fixed now.
This is an automated message from the Apache Git Service.
To respond to th
cremor commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-686260395
@rgoers Now the link https://logging.apache.org/log4net/ works, but the link
which is on https://logging.apache.org, which is
https://logging.apache.org/log4net/2.x/index.htm
[
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189749#comment-17189749
]
Robert Middleton commented on LOGCXX-510:
-
That looks pretty good to me - I'll ta
BUILD UNSTABLE
Build URL
https://ci-builds.apache.org/job/Logging/job/log4j/job/master/147/
Project:
master
Date of build:
Wed, 02 Sep 2020 18:25:06 +
Build duration:
1 hr 37 min and counting
JUnit Tests
Name: liquibase.ext.logging.log4j2 Failed:
fluffynuts commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685954452
Thanks for sorting it out @rgoers. I'll try to be better prepared next time.
This is an automated message
rgoers commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685947511
FWIW, the documentation for publishing the web site is at
https://cwiki.apache.org/confluence/display/LOGGING/Managing+the+Git+Hosted+Web+Site.
So you would run your build to
rgoers commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685945845
Please try it again.
This is an automated message from the Apache Git Service.
To respond to the message, ple
fluffynuts commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685937486
@cremor thanks for reporting; logging sites are in a bit of a state of
upheaval right now (as far as I understand). Good people are On It.
--
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685935299
> Reflecting my previous experience adding or dropping targets are rarely
considered as breaking\major change, minor at best.
it's breaking for people who de
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685935299
> Reflecting my previous experience adding or dropping targets are rarely
considered as breaking\major change, minor at best.
it's breaking for people who de
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685935299
> Reflecting my previous experience adding or dropping targets are rarely
considered as breaking\major change, minor at best.
it's breaking for people who de
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685935299
> Reflecting my previous experience adding or dropping targets are rarely
considered as breaking\major change, minor at best.
it's breaking for people who depend on it;
jazpearson commented on pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-685875512
Would be great to see this merged as this is blocking us,
This is an automated message from the Apache Gi
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685726181
>
>
> I'd be very careful about dropping target frameworks. This is a breaking
change. All projects using that framework will no longer be able to use the
newe
cremor commented on pull request #62:
URL: https://github.com/apache/logging-log4net/pull/62#issuecomment-685723562
I'm not sure if this belongs to the changes made in this PR, but
https://logging.apache.org/log4net/ (with is the top Google result if you
search for "log4net") currently lea
cremor edited a comment on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-685715057
@fluffynuts Thanks for the pointer to #63 and for the precompiled NuGet
package from that PR! I just tested it and it indeed fixes all of the points I
mentioned above.
cremor commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685717421
> Also I've dropped `net35-client` and `net40-client` as target frameworks,
because unable to compile against. Should we bring them back and test somehow
or deprecate and dro
cremor commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-685715057
@fluffynuts Thanks for the pointer to #63 and for the precompiled NuGet
package from that PR! I just tested it and it indeed fixes all of the points I
mentioned above.
NicholasNoise edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685695290
@fluffynuts Thank you for quick response!
I made this PR from non-personal fork, but already requested branch setting
change to an admin of organization (shou
NicholasNoise edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685695290
@fluffynuts Thank you for quick response!
I made this PR from non-personal fork, but already requested branch setting
change to an admin of organization (shou
NicholasNoise commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685695290
@fluffynuts Thank you for quick response!
I made this PR from non-personal fork, but already requested branch setting
change to an admin of organization (should be g
SymbioticKilla commented on pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64#issuecomment-685614850
I hope it is fine. If not than sorry => close/delete it.
Thanks!
This is an automated message from
SymbioticKilla opened a new pull request #64:
URL: https://github.com/apache/logging-log4net/pull/64
…(LOG4NET-575)
This patch fixes a security vulnerabiliy reported by Karthik Balasundaram.
The security
vulnerability was found in the way how log4net parses xml configuration
file
fluffynuts commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-685547877
@cremor could you see if the changes here fix this:
https://github.com/apache/logging-log4net/pull/63
Perhaps:
1. clone the PR branch
2. build (if you have no
cremor commented on pull request #59:
URL: https://github.com/apache/logging-log4net/pull/59#issuecomment-685486982
@jvz Thanks. Does this mean I should create tickets for the points in my
last comment?
This is an automated
vy edited a comment on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-685462219
@ramazanpolat,
1. Unless there is a reason to do so, I would avoid custom classes to
represent the logging structure. In your case a simple `logger.info(new
MapMessage
vy commented on pull request #335:
URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-685462219
1. Unless there is a reason to do so, I would avoid custom classes to
represent the logging structure. In your case a simple `logger.info(new
MapMessage(Map.of("message", messag
fluffynuts edited a comment on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685442735
@NicholasNoise I really appreciate the PR & the time taken to produce
multi-target tests! Good job.
There are two changes I'd like to make -- either we can c
fluffynuts commented on pull request #63:
URL: https://github.com/apache/logging-log4net/pull/63#issuecomment-685442735
@NicholasNoise I really appreciate the PR & the time taken to produce
multi-target tests! Good job.
There are two changes I'd like to make -- either we can collabor
[
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189028#comment-17189028
]
Thorsten Schöning edited comment on LOGCXX-510 at 9/2/20, 7:34 AM:
[
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thorsten Schöning updated LOGCXX-510:
-
Attachment: cmake_settings_using_vs_gui 02.png
> Build problems using CMAKE and Visual St
[
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189028#comment-17189028
]
Thorsten Schöning edited comment on LOGCXX-510 at 9/2/20, 7:04 AM:
[
https://issues.apache.org/jira/browse/LOGCXX-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189028#comment-17189028
]
Thorsten Schöning commented on LOGCXX-510:
--
> 2. The directories for APR and APR
33 matches
Mail list logo
