[GitHub] [logging-log4j2] tbwork commented on pull request #396: Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

tbwork commented on pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674697992 @rgoers Hi, rgoers. How to understand your comments: **_The Lookups would be loaded again as normal as Plugins during configuration._** If all pre-loaded looku

[jira] [Commented] (LOG4J2-2905) when we set the property "monitorInterval" and appenders/loggers are getting messed-up

[ https://issues.apache.org/jira/browse/LOG4J2-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178756#comment-17178756 ] Ananda Reddy C commented on LOG4J2-2905: Hi Ralph, Yes, your understanding is r

[jira] [Updated] (LOG4J2-2909) Version Upgrade of log4j2 jars from 2.10.0 to 2.13.2 cause TPS degradation

[ https://issues.apache.org/jira/browse/LOG4J2-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Murtaza updated LOG4J2-2909: Attachment: (was: log4j.PNG) > Version Upgrade of log4j2 jars from 2.10.0 to 2.13.2 cause TPS

[GitHub] [logging-log4j2] tbwork commented on a change in pull request #396: Load pre-loaded lookups via SPI, rather than hard-code in Interpolator.

tbwork commented on a change in pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471211570 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java ## @@ -16,20 +16,13 @@ */ package org.apache.logging

[GitHub] [logging-log4j2] tbwork commented on a change in pull request #396: Reconstruct lookup load mechanism from plugin mode to SPI mode.

tbwork commented on a change in pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471237765 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/BuiltInLookupCategory.java ## @@ -0,0 +1,116 @@ +package org.apache.loggi

[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #403: Bump plexus-compiler-javac-errorprone from 2.8.5 to 2.8.7

dependabot[bot] opened a new pull request #403: URL: https://github.com/apache/logging-log4j2/pull/403 Bumps plexus-compiler-javac-errorprone from 2.8.5 to 2.8.7. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name

[GitHub] [logging-log4j2] tbwork removed a comment on pull request #396: Reconstruct lookup load mechanism from plugin mode to SPI mode.

tbwork removed a comment on pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674637748 @rgoers Hi, rgoers. It seems my first pull request was what you want? Here is my plan: 1. Keep all the old lookup loaded as plugins. 2. Provide a SPI mode for c

[GitHub] [logging-log4j2] tbwork edited a comment on pull request #396: Reconstruct lookup load mechanism from plugin mode to SPI mode.

tbwork edited a comment on pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674639216 @rgoers I propably misunderstood your opinion: **_In essence, StrLookup would become the service interface and every plugin to be pre-loaded would be listed in

[GitHub] [logging-log4j2] tbwork commented on pull request #396: Reconstruct lookup load mechanism from plugin mode to SPI mode.

tbwork commented on pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674639216 @rgoers I propably misunderstood your opinion: **_In essence, StrLookup would become the service interface and every plugin to be pre-loaded would be listed in the se

[GitHub] [logging-log4j2] tbwork commented on pull request #396: Reconstruct lookup load mechanism from plugin mode to SPI mode.

tbwork commented on pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-674637748 @rgoers Hi, rgoers. It seems my first pull request was what you want? Here is my plan: 1. Keep all the old lookup loaded as plugins. 2. Provide a SPI mode for custom lo

[GitHub] [logging-log4j2] tbwork commented on a change in pull request #396: Reconstruct lookup load mechanism from plugin mode to SPI mode.

tbwork commented on a change in pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471211554 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java ## @@ -39,157 +32,95 @@ /** Constant for the prefi

[GitHub] [logging-log4j2] tbwork commented on a change in pull request #396: Reconstruct lookup load mechanism from plugin mode to SPI mode.

tbwork commented on a change in pull request #396: URL: https://github.com/apache/logging-log4j2/pull/396#discussion_r471209697 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/JndiLookup.java ## @@ -40,6 +39,24 @@ /** JNDI resource path prefix

[jira] [Updated] (LOG4J2-2653) Migrate to JUnit 5

[ https://issues.apache.org/jira/browse/LOG4J2-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-2653: Description: JUnit 5 has a ton of neat features that make writing tests easier and more expressiv

[jira] [Commented] (LOG4J2-2653) Migrate to JUnit 5

[ https://issues.apache.org/jira/browse/LOG4J2-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178644#comment-17178644 ] Matt Sicker commented on LOG4J2-2653: - As I get further in to this, I realize this w

[GitHub] [logging-log4j2] fmarchioni opened a new pull request #402: Added two articles recently published

fmarchioni opened a new pull request #402: URL: https://github.com/apache/logging-log4j2/pull/402 I've added two fresh articles based on the latest releases of WildFly application Server and Spring Boot 2. This is an automat