tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671695782
@rgoers ok.
This is an automated message from the Apache Git Service.
To respond to the message, please log
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671515763
Yes, that is exactly what I mean. Feel free to modify this PR to do that. In
essence, StrLookup would become the service interface and every plugin to be
pre-loaded w
rgoers commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671515763
Yes, that is exactly what I mean. Feel free to modify this PR to do that.
This is an automated message from
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671478573
@rgoers Do you mean all the pre-loaded Lookups should be loaded via
ServiceLoader? I am glad to contribute to this part if you do not mind. :)
-
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671473790
@rgoers Agree! This PR is intended to do that as you proposed. Hope this
could be supported ASAP :) . Have a nice day.
-
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose, which is to allow a way for users to hook into a Lookup that
is configure
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose, which is to allow a way for users to hook into a Lookup that
is configure
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose, which is to allow a way for user's to hook into a Lookup that
is configur
rgoers edited a comment on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose, which is to allow a way for users to hook into a Lookup that
is configure
rgoers commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671447712
@jvz I dislike ServiceLookup as it is describing its implementation method,
not its purpose.
This is an au
rgoers commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671433053
The only concern I have with this is the overhead of ServiceLoader during
startup. I recently had to make ServiceLoader run asynchronously during startup
while loading Custo
[
https://issues.apache.org/jira/browse/LOG4J2-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174350#comment-17174350
]
Ralph Goers commented on LOG4J2-2905:
-
Please provide your log4j configuration. When
jvz commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671368699
No worries about the Travis check. The GitHub Actions checks are the
important ones. We need to disable our old Travis checks.
Ananda Reddy C created LOG4J2-2905:
--
Summary: when we set the property "monitorInterval" and
appenders/loggers are getting messed-up
Key: LOG4J2-2905
URL: https://issues.apache.org/jira/browse/LOG4J2-2905
[
https://issues.apache.org/jira/browse/LOG4J2-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174222#comment-17174222
]
Tommy.Tesla commented on LOG4J2-2904:
-
[~rgoers] Hi, Goers, I've post a PR. But the
tbwork commented on pull request #396:
URL: https://github.com/apache/logging-log4j2/pull/396#issuecomment-671263947
What's wrong with the CI? The change should have nothing to do with the
error. :)
This is an automated mes
ams-tschoening commented on pull request #35:
URL: https://github.com/apache/logging-log4cxx/pull/35#issuecomment-671254462
I don't like those markdown-tables too much, seem pretty difficult to
maintain in my opinion. But I'm fine with that approach as well. The following
sentence makes me
17 matches
Mail list logo
