[GitHub] [logging-log4cxx] rm5248 commented on pull request #35: Changed some docs and model dependencies for tests etc. using MVN.

2020-08-08 Thread GitBox
rm5248 commented on pull request #35: URL: https://github.com/apache/logging-log4cxx/pull/35#issuecomment-670952319 If we do want to move away from maven in the not-too-distant future, something like this may be more appropriate for the dependencies: https://github.com/apache/logging-log4c

[GitHub] [logging-log4cxx] rm5248 commented on pull request #34: Fixed an infinite loop in "Transcoder::encode"

2020-08-08 Thread GitBox
rm5248 commented on pull request #34: URL: https://github.com/apache/logging-log4cxx/pull/34#issuecomment-670947833 Looks good to me - I went and added a test case as well to validate that it works correctly, if you want to take a look.

[jira] [Commented] (LOG4J2-2653) Migrate to JUnit 5

2020-08-08 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173672#comment-17173672 ] Matt Sicker commented on LOG4J2-2653: - One thing I discovered a few days ago while e

[jira] [Commented] (LOG4J2-2904) Provide a way to add customized StrLookUps in Interpolator initialization.

2020-08-08 Thread Tommy.Tesla (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173650#comment-17173650 ] Tommy.Tesla commented on LOG4J2-2904: - Ok, glad to do that. > Provide a way to add

[GitHub] [logging-log4cxx] ams-tschoening closed pull request #30: Documentation changes for release

2020-08-08 Thread GitBox
ams-tschoening closed pull request #30: URL: https://github.com/apache/logging-log4cxx/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #30: Documentation changes for release

2020-08-08 Thread GitBox
ams-tschoening commented on pull request #30: URL: https://github.com/apache/logging-log4cxx/pull/30#issuecomment-670854807 Closing here in favour of #35, that contains all the commits here already. This is an automated messa

[GitHub] [logging-log4cxx] ams-tschoening opened a new pull request #35: Changed some docs and model dependencies for tests etc. using MVN.

2020-08-08 Thread GitBox
ams-tschoening opened a new pull request #35: URL: https://github.com/apache/logging-log4cxx/pull/35 This is an improved version o #30, which DOES NOT remove the page about dependencies. Reason is that without that page, one needs to model the dependencies otherwise and that is not as easy

[jira] [Commented] (LOGCXX-398) Infinite loop in Transcoder::encode(const LogString& src, std::wstring& dst)

2020-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/LOGCXX-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173610#comment-17173610 ] Thorsten Schöning commented on LOGCXX-398: -- How could log4cxx handle that except

[GitHub] [logging-log4cxx] ams-tschoening opened a new pull request #34: Fixed an infinite loop in "Transcoder::encode"

2020-08-08 Thread GitBox
ams-tschoening opened a new pull request #34: URL: https://github.com/apache/logging-log4cxx/pull/34 Transcoder::encode(const LogString&, std::wstring&)" by appending LOSSCHAR. The most likely alternative would be to throw on any invalid input instead, but that's not the case right now and

[jira] [Updated] (LOGCXX-455) LogLog::setQuietMode(true) does not suppress exception reporting

2020-08-08 Thread Jira
[ https://issues.apache.org/jira/browse/LOGCXX-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thorsten Schöning updated LOGCXX-455: - Fix Version/s: 0.11.0 > LogLog::setQuietMode(true) does not suppress exception reporting