[jira] [Commented] (LOG4J2-2884) Failover does not work incase of primary appender fails

2020-07-29 Thread Zeeshan (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167641#comment-17167641 ] Zeeshan commented on LOG4J2-2884: -- [~rgoers], Thanks for the reply, let me try with TC

[CI][SUCCESS] Logging/log4j/release-2.x#66 back to normal

2020-07-29 Thread Mr. Jenkins
GENERAL INFO BUILD SUCCESS Build URL: https://ci-builds.apache.org/job/Logging/job/log4j/job/release-2.x/66/ Project: release-2.x Date of build: Wed, 29 Jul 2020 19:38:52 + Build duration: 1 hr 11 min and counting CHANGE SET Revision by Matt Sicker: (Add verification step for par

[jira] [Commented] (LOG4J2-2875) StreamClosed IOException after first time based rolling

2020-07-29 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167490#comment-17167490 ] Ralph Goers commented on LOG4J2-2875: - I am not sure why changing useCurrentTime fro

[jira] [Commented] (LOG4J2-2884) Failover does not work incase of primary appender fails

2020-07-29 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167453#comment-17167453 ] Ralph Goers commented on LOG4J2-2884: - You are using udp to connect with the syslog

[GitHub] [logging-log4j2] liyuj commented on pull request #171: Add two new LuceneAppender which writes logging events to a lucene index library.

2020-07-29 Thread GitBox
liyuj commented on pull request #171: URL: https://github.com/apache/logging-log4j2/pull/171#issuecomment-665560243 > Do we want to apply this? I'm not really sure why one would want to log directly to Lucene instead of to Solr or ElasticSearch. I think it's a simplified solution tha

[jira] [Commented] (LOG4J2-2902) LoaderUtil#getClassLoaders throws a SecurityException trying to access system class loader

2020-07-29 Thread Ryan Schmitt (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167412#comment-17167412 ] Ryan Schmitt commented on LOG4J2-2902: -- https://github.com/apache/logging-log4j2/pu

[GitHub] [logging-log4j2] remkop commented on pull request #208: [LOG4J2-2399] support for async formatting on reusable messages

2020-07-29 Thread GitBox
remkop commented on pull request #208: URL: https://github.com/apache/logging-log4j2/pull/208#issuecomment-665536829 I did not have time to do an in-depth review today, would need to take another detailed look. It has been a while since I looked, perhaps @bjlaub can clarify whether

[jira] [Created] (LOG4J2-2902) LoaderUtil#getClassLoaders throws a SecurityException trying to access system class loader

2020-07-29 Thread Ryan Schmitt (Jira)
Ryan Schmitt created LOG4J2-2902: Summary: LoaderUtil#getClassLoaders throws a SecurityException trying to access system class loader Key: LOG4J2-2902 URL: https://issues.apache.org/jira/browse/LOG4J2-2902

[GitHub] [logging-log4j2] Lemongrass3110 commented on pull request #173: [LOG4J2-2332] Unresolved variables in any file appender

2020-07-29 Thread GitBox
Lemongrass3110 commented on pull request #173: URL: https://github.com/apache/logging-log4j2/pull/173#issuecomment-665525997 @rgoers I tried to resolve the conflicts as good as possible. Do you want me to move the new classes from `org.apache.logging.log4j.core.config.plugins.validation.

[GitHub] [logging-log4j2] garydgregory commented on pull request #208: [LOG4J2-2399] support for async formatting on reusable messages

2020-07-29 Thread GitBox
garydgregory commented on pull request #208: URL: https://github.com/apache/logging-log4j2/pull/208#issuecomment-665636379 On Wed, Jul 29, 2020 at 5:02 AM Remko Popma wrote: > I did not have time to do an in-depth review today, would need to take > another detailed look. >

[jira] [Commented] (LOG4J2-2900) Method Exit Breakpoints very slow in Eclipse when using Log4j2

2020-07-29 Thread dave debugger (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167382#comment-17167382 ] dave debugger commented on LOG4J2-2900: --- Thanks, I think you're right.  I just ope

[jira] [Commented] (LOG4J2-2900) Method Exit Breakpoints very slow in Eclipse when using Log4j2

2020-07-29 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167372#comment-17167372 ] Ralph Goers commented on LOG4J2-2900: - I have no idea how to debug this. Even if I u

[jira] [Updated] (LOG4J2-2900) Method Exit Breakpoints very slow in Eclipse when using Log4j2

2020-07-29 Thread dave debugger (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dave debugger updated LOG4J2-2900: -- Summary: Method Exit Breakpoints very slow in Eclipse when using Log4j2 (was: Method Breakpoi

[jira] [Updated] (LOG4J2-2900) Method Breakpoints very slow in Eclipse when using Log4j2

2020-07-29 Thread dave debugger (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dave debugger updated LOG4J2-2900: -- Description: I've noticed that if I set a Method breakpoint, of type Exit, in Eclipse with an

[jira] [Updated] (LOG4J2-2901) Reconfiguration failed during backend server startup

2020-07-29 Thread Dejan (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan updated LOG4J2-2901: -- Description: I upgraded both components from log4j-api an log4j-core from 2.11.2 to 2.13.3 and started gettin

[jira] [Updated] (LOG4J2-2901) Reconfiguration failed during backend server startup

2020-07-29 Thread Dejan (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan updated LOG4J2-2901: -- Description: I upgraded both components from log4j-api an log4j-core from 2.11.2 to 2.13.3 and started gettin

[jira] [Created] (LOG4J2-2901) Reconfiguration failed during backend server startup

2020-07-29 Thread Dejan (Jira)
Dejan created LOG4J2-2901: - Summary: Reconfiguration failed during backend server startup Key: LOG4J2-2901 URL: https://issues.apache.org/jira/browse/LOG4J2-2901 Project: Log4j 2 Issue Type: Bug

[GitHub] [logging-log4j2] rgoers closed pull request #131: [LOG4J2-2118] Modify MutableLogEvent to preserve message format string.

2020-07-29 Thread GitBox
rgoers closed pull request #131: URL: https://github.com/apache/logging-log4j2/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers commented on pull request #171: Add two new LuceneAppender which writes logging events to a lucene index library.

2020-07-29 Thread GitBox
rgoers commented on pull request #171: URL: https://github.com/apache/logging-log4j2/pull/171#issuecomment-665438604 Do we want to apply this? I'm not really sure why one would want to log directly to Lucene instead of to Solr or ElasticSearch.

[GitHub] [logging-log4j2] carterkozak commented on pull request #329: ThrowableProxy pre-warms its cache using the detected stack

2020-07-29 Thread GitBox
carterkozak commented on pull request #329: URL: https://github.com/apache/logging-log4j2/pull/329#issuecomment-665417612 I had forgotten about this change. I'm a little bit afraid of changes to ThrowableProxy because there are a number of cases when multiple classes with the same fully qu

[GitHub] [logging-log4j2] remkop commented on a change in pull request #208: [LOG4J2-2399] support for async formatting on reusable messages

2020-07-29 Thread GitBox
remkop commented on a change in pull request #208: URL: https://github.com/apache/logging-log4j2/pull/208#discussion_r461938239 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java ## @@ -355,4 +356,41 @@ public void clear()

[GitHub] [logging-log4j2] rgoers closed pull request #128: LOG4J2-2110 adding a ServletContext parameter to allow the contextIni…

2020-07-29 Thread GitBox
rgoers closed pull request #128: URL: https://github.com/apache/logging-log4j2/pull/128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers commented on pull request #195: LOG4J2-2389 fix the CacheEntry map in ThrowableProxy#toExtendedStackTrace to be put and gotten with same key

2020-07-29 Thread GitBox
rgoers commented on pull request #195: URL: https://github.com/apache/logging-log4j2/pull/195#issuecomment-664813872 Closing since ThrowableProxy was completely refactored and the change I see here has been made to the source. --

[GitHub] [logging-log4j2] garydgregory commented on pull request #244: New iso date time formats

2020-07-29 Thread GitBox
garydgregory commented on pull request #244: URL: https://github.com/apache/logging-log4j2/pull/244#issuecomment-665353745 Wel, it looks like the PR is/was ready to go now it's stale. This is an automated message from the Apa

[GitHub] [logging-log4j2] carterkozak commented on pull request #390: LOG4J2-2899: Fix log4j-1.2-api LogEventWrapper thread data accessors

2020-07-29 Thread GitBox
carterkozak commented on pull request #390: URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-664675299 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [logging-log4j2] rgoers commented on pull request #131: [LOG4J2-2118] Modify MutableLogEvent to preserve message format string.

2020-07-29 Thread GitBox
rgoers commented on pull request #131: URL: https://github.com/apache/logging-log4j2/pull/131#issuecomment-665439353 Closing due to the comments by @carterkozak 2 years ago and no response since. This is an automated message

[GitHub] [logging-log4j2] carterkozak closed pull request #390: LOG4J2-2899: Fix log4j-1.2-api LogEventWrapper thread data accessors

2020-07-29 Thread GitBox
carterkozak closed pull request #390: URL: https://github.com/apache/logging-log4j2/pull/390 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #208: [LOG4J2-2399] support for async formatting on reusable messages

2020-07-29 Thread GitBox
rgoers commented on a change in pull request #208: URL: https://github.com/apache/logging-log4j2/pull/208#discussion_r462022446 ## File path: log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java ## @@ -355,4 +356,41 @@ public void clear()

[GitHub] [logging-log4j2] rgoers commented on pull request #366: Allow clients to set the source manually.

2020-07-29 Thread GitBox
rgoers commented on pull request #366: URL: https://github.com/apache/logging-log4j2/pull/366#issuecomment-664793002 @shawjef3 Based on our comments, what do you want to do with this PR? This is an automated message from the

[GitHub] [logging-log4j2] rgoers commented on pull request #163: Add KeyValueLayout which outputs log messages as key/value pairs.

2020-07-29 Thread GitBox
rgoers commented on pull request #163: URL: https://github.com/apache/logging-log4j2/pull/163#issuecomment-665438922 Closing do to no response to my inquiries 2 years ago. This is an automated message from the Apache Git Serv

[GitHub] [logging-log4j2] rgoers commented on pull request #208: [LOG4J2-2399] support for async formatting on reusable messages

2020-07-29 Thread GitBox
rgoers commented on pull request #208: URL: https://github.com/apache/logging-log4j2/pull/208#issuecomment-665312449 @remkop Do you have an opinion on this? It has been almost 2 years now. This is an automated message from th

[GitHub] [logging-log4j2] rgoers commented on pull request #244: New iso date time formats

2020-07-29 Thread GitBox
rgoers commented on pull request #244: URL: https://github.com/apache/logging-log4j2/pull/244#issuecomment-665310696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [logging-log4j2] rgoers closed pull request #163: Add KeyValueLayout which outputs log messages as key/value pairs.

2020-07-29 Thread GitBox
rgoers closed pull request #163: URL: https://github.com/apache/logging-log4j2/pull/163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers merged pull request #206: [LOG4J2-2400] Initial implementation of RedisAppender.

2020-07-29 Thread GitBox
rgoers merged pull request #206: URL: https://github.com/apache/logging-log4j2/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers commented on pull request #329: ThrowableProxy pre-warms its cache using the detected stack

2020-07-29 Thread GitBox
rgoers commented on pull request #329: URL: https://github.com/apache/logging-log4j2/pull/329#issuecomment-665412865 @carterkozak Have you revisited this. To be honest I looked at the review here but it is hard to tell what effect it might have. It would be great to have some JMH benchmark

[GitHub] [logging-log4j2] rgoers commented on pull request #87: [LOG4J2-928] Mostly wait-free MemoryMappedFileManager

2020-07-29 Thread GitBox
rgoers commented on pull request #87: URL: https://github.com/apache/logging-log4j2/pull/87#issuecomment-665442300 @leventov @remkop @jvz Is there value in accepting this as-is. It has merge conflicts that have to be resolved. I have not checked to see how many there are or how difficult t

[GitHub] [logging-log4j2] rgoers edited a comment on pull request #329: ThrowableProxy pre-warms its cache using the detected stack

2020-07-29 Thread GitBox
rgoers edited a comment on pull request #329: URL: https://github.com/apache/logging-log4j2/pull/329#issuecomment-665412865 @carterkozak Have you revisited this? To be honest I looked at the review here but it is hard to tell what effect it might have. It would be great to have some JMH be

[GitHub] [logging-log4j2] rgoers closed pull request #363: LOG4J2-2859 - Fix typo that mergeFactory should be mergeStrategy

2020-07-29 Thread GitBox
rgoers closed pull request #363: URL: https://github.com/apache/logging-log4j2/pull/363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers merged pull request #358: LOG4J2-2832: Updated strategy name to existing strategy

2020-07-29 Thread GitBox
rgoers merged pull request #358: URL: https://github.com/apache/logging-log4j2/pull/358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers commented on pull request #210: [LOG4J2-2391] Lazily initialize ThrowableProxy data

2020-07-29 Thread GitBox
rgoers commented on pull request #210: URL: https://github.com/apache/logging-log4j2/pull/210#issuecomment-664810752 Any progress? Should this be closed in lieu of a different solution? This is an automated message from the A

[GitHub] [logging-log4j2] rgoers commented on pull request #363: LOG4J2-2859 - Fix typo that mergeFactory should be mergeStrategy

2020-07-29 Thread GitBox
rgoers commented on pull request #363: URL: https://github.com/apache/logging-log4j2/pull/363#issuecomment-665309778 Patch was manually applied. For some reason merging the branch caused test failures in log4j-taglib for me.

[GitHub] [logging-log4j2] rgoers commented on pull request #326: LOG4J2-2750: Extended throwable class loading can be disabled

2020-07-29 Thread GitBox
rgoers commented on pull request #326: URL: https://github.com/apache/logging-log4j2/pull/326#issuecomment-665414709 @carterkozak I added support for requiresLocation() to LoggerConfig and various the various components a few releases ago. However, requiresLocation() should really be used

[GitHub] [logging-log4j2] rgoers commented on pull request #173: [LOG4J2-2332] Unresolved variables in any file appender

2020-07-29 Thread GitBox
rgoers commented on pull request #173: URL: https://github.com/apache/logging-log4j2/pull/173#issuecomment-665438019 @Lemongrass3110 @jvz @garydgregory After all this time I am not sure where this stands. It now has conflicts that need to be resolved. The PR is over 2 years old and we eith

[jira] [Updated] (LOG4J2-2900) Method Breakpoints very slow in Eclipse when using Log4j2

2020-07-29 Thread dave debugger (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dave debugger updated LOG4J2-2900: -- Description: I've noticed that if I set a Method breakpoint, of type Exit, in Eclipse with an

[GitHub] [logging-log4j2] rgoers closed pull request #195: LOG4J2-2389 fix the CacheEntry map in ThrowableProxy#toExtendedStackTrace to be put and gotten with same key

2020-07-29 Thread GitBox
rgoers closed pull request #195: URL: https://github.com/apache/logging-log4j2/pull/195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] Lemongrass3110 commented on pull request #173: [LOG4J2-2332] Unresolved variables in any file appender

2020-07-29 Thread GitBox
Lemongrass3110 commented on pull request #173: URL: https://github.com/apache/logging-log4j2/pull/173#issuecomment-665470680 > > > @Lemongrass3110 @jvz @garydgregory After all this time I am not sure where this stands. It now has conflicts that need to be resolved. The PR is over 2

[GitHub] [logging-log4j2] carterkozak closed pull request #210: [LOG4J2-2391] Lazily initialize ThrowableProxy data

2020-07-29 Thread GitBox
carterkozak closed pull request #210: URL: https://github.com/apache/logging-log4j2/pull/210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [logging-log4j2] rgoers commented on pull request #128: LOG4J2-2110 adding a ServletContext parameter to allow the contextIni…

2020-07-29 Thread GitBox
rgoers commented on pull request #128: URL: https://github.com/apache/logging-log4j2/pull/128#issuecomment-665439972 The associated Jira was closed several months ago. This is an automated message from the Apache Git Service.

[GitHub] [logging-log4j2] rgoers merged pull request #381: LOG4J2-2882: Add support for JUL filters

2020-07-29 Thread GitBox
rgoers merged pull request #381: URL: https://github.com/apache/logging-log4j2/pull/381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [logging-log4j2] rgoers commented on pull request #390: LOG4J2-2899: Fix log4j-1.2-api LogEventWrapper thread data accessors

2020-07-29 Thread GitBox
rgoers commented on pull request #390: URL: https://github.com/apache/logging-log4j2/pull/390#issuecomment-664681823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub