[jira] [Work logged] (LOG4J2-2837) Fully asynchronous logging results in two disruptors being created

2020-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2837?focusedWorklogId=459557&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459557 ] ASF GitHub Bot logged work on LOG4J2-2837: -- Author: ASF GitHub Bot

[GitHub] [logging-log4j2] remkop commented on pull request #388: LOG4J2-2837: Disruptor and JUL no longer recursively start the AsyncLoggerDisruptor

2020-07-15 Thread GitBox
remkop commented on pull request #388: URL: https://github.com/apache/logging-log4j2/pull/388#issuecomment-659048207 If you can merge #361, that would be great! Thank you! This is an automated message from the Apache Git Se

[jira] [Work logged] (LOG4J2-2837) Fully asynchronous logging results in two disruptors being created

2020-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2837?focusedWorklogId=459555&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459555 ] ASF GitHub Bot logged work on LOG4J2-2837: -- Author: ASF GitHub Bot

[GitHub] [logging-log4j2] carterkozak commented on pull request #388: LOG4J2-2837: Disruptor and JUL no longer recursively start the AsyncLoggerDisruptor

2020-07-15 Thread GitBox
carterkozak commented on pull request #388: URL: https://github.com/apache/logging-log4j2/pull/388#issuecomment-659046112 I appreciate the reviews, thanks @remkop :-) I still need to finish full test runs locally for these changes, then I'll merge along with #361, likely tomorrow.

[jira] [Work logged] (LOG4J2-2895) Async logging should avoid submitting work from Log4jThread threads

2020-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2895?focusedWorklogId=459554&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459554 ] ASF GitHub Bot logged work on LOG4J2-2895: -- Author: ASF GitHub Bot

[jira] [Work logged] (LOG4J2-2837) Fully asynchronous logging results in two disruptors being created

2020-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2837?focusedWorklogId=459553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459553 ] ASF GitHub Bot logged work on LOG4J2-2837: -- Author: ASF GitHub Bot

[GitHub] [logging-log4j2] remkop commented on pull request #389: LOG4J2-2895: Async logging avoids blocking on Log4jThreads

2020-07-15 Thread GitBox
remkop commented on pull request #389: URL: https://github.com/apache/logging-log4j2/pull/389#issuecomment-659045453 Thanks for taking care of this, Carter! This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4j2] remkop commented on pull request #388: LOG4J2-2837: Disruptor and JUL no longer recursively start the AsyncLoggerDisruptor

2020-07-15 Thread GitBox
remkop commented on pull request #388: URL: https://github.com/apache/logging-log4j2/pull/388#issuecomment-659045322 Thanks for taking care of this, Carter! This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (LOG4J2-2837) Fully asynchronous logging results in two disruptors being created

2020-07-15 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158695#comment-17158695 ] Carter Kozak commented on LOG4J2-2837: -- Proposed change: [https://github.com/apache

[jira] [Work started] (LOG4J2-2895) Async logging should avoid submitting work from Log4jThread threads

2020-07-15 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LOG4J2-2895 started by Carter Kozak. > Async logging should avoid submitting work from Log4jThread threads > ---

[jira] [Work started] (LOG4J2-2837) Fully asynchronous logging results in two disruptors being created

2020-07-15 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LOG4J2-2837 started by Carter Kozak. > Fully asynchronous logging results in two disruptors being created >

[jira] [Commented] (LOG4J2-2895) Async logging should avoid submitting work from Log4jThread threads

2020-07-15 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158694#comment-17158694 ] Carter Kozak commented on LOG4J2-2895: -- Proposed change: https://github.com/apache/

[jira] [Work logged] (LOG4J2-2895) Async logging should avoid submitting work from Log4jThread threads

2020-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2895?focusedWorklogId=459515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459515 ] ASF GitHub Bot logged work on LOG4J2-2895: -- Author: ASF GitHub Bot

[GitHub] [logging-log4j2] carterkozak opened a new pull request #389: LOG4J2-2895: Async logging avoids blocking on Log4jThreads

2020-07-15 Thread GitBox
carterkozak opened a new pull request #389: URL: https://github.com/apache/logging-log4j2/pull/389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (LOG4J2-2895) Async logging should avoid submitting work from Log4jThread threads

2020-07-15 Thread Carter Kozak (Jira)
Carter Kozak created LOG4J2-2895: Summary: Async logging should avoid submitting work from Log4jThread threads Key: LOG4J2-2895 URL: https://issues.apache.org/jira/browse/LOG4J2-2895 Project: Log4j 2

[jira] [Work logged] (LOG4J2-2837) Fully asynchronous logging results in two disruptors being created

2020-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2837?focusedWorklogId=459511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459511 ] ASF GitHub Bot logged work on LOG4J2-2837: -- Author: ASF GitHub Bot

[GitHub] [logging-log4j2] carterkozak opened a new pull request #388: LOG4J2-2837: Disruptor and JUL no longer recursively start the AsyncLoggerDisruptor

2020-07-15 Thread GitBox
carterkozak opened a new pull request #388: URL: https://github.com/apache/logging-log4j2/pull/388 Previously logging initialization would result in an AsyncLoggerContext initializing an AsyncLoggerDisruptor, which would access a logger from JUL, starting the process again. This change

[jira] [Commented] (LOG4J2-2867) ContextDataProvider will cause concurrent threads blocking at the first logging time

2020-07-15 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158672#comment-17158672 ] Carter Kozak commented on LOG4J2-2867: -- I agree, I think a combination of our chang

[jira] [Commented] (LOG4J2-2867) ContextDataProvider will cause concurrent threads blocking at the first logging time

2020-07-15 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158653#comment-17158653 ] Ralph Goers commented on LOG4J2-2867: - That is definitely a good change, but I don't

[jira] [Work logged] (LOG4J2-2867) ContextDataProvider will cause concurrent threads blocking at the first logging time

2020-07-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2867?focusedWorklogId=459497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459497 ] ASF GitHub Bot logged work on LOG4J2-2867: -- Author: ASF GitHub Bot

[jira] [Commented] (LOG4J2-2867) ContextDataProvider will cause concurrent threads blocking at the first logging time

2020-07-15 Thread Carter Kozak (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158650#comment-17158650 ] Carter Kozak commented on LOG4J2-2867: -- I've proposed this change to use a static C

[GitHub] [logging-log4j2] carterkozak opened a new pull request #387: LOG4J2-2867: RingBufferLogEventTranslator uses a static ContextDataInjector

2020-07-15 Thread GitBox
carterkozak opened a new pull request #387: URL: https://github.com/apache/logging-log4j2/pull/387 Previously a new instance was created for each translator, which occurred on every thread. Some applications do not reuse threads efficiently, and shouldn't be over-penalized. -