[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418451027 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXECUT

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418444913 ## File path: src/cmake/FindAPR.cmake ## @@ -33,7 +33,14 @@ find_program(APR_CONFIG_EXECUTABLE mark_as_advanced(APR_CONFIG_EXECUTABLE) if(EXIST

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418444913 ## File path: src/cmake/FindAPR.cmake ## @@ -33,7 +33,14 @@ find_program(APR_CONFIG_EXECUTABLE mark_as_advanced(APR_CONFIG_EXECUTABLE) if(EXIST

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418443118 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -48,5 +55,5 @@ else() endif() endif() -find_package_handle_standard_args(APR-Util DEFAUL

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418442671 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXECUT

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #23: Static linking support for non windows systems

stephen-webb commented on a change in pull request #23: URL: https://github.com/apache/logging-log4cxx/pull/23#discussion_r418442671 ## File path: src/cmake/FindAPR-Util.cmake ## @@ -34,7 +34,14 @@ find_program(APR_UTIL_CONFIG_EXECUTABLE mark_as_advanced(APR_UTIL_CONFIG_EXECUT