[GitHub] [logging-log4cxx] ams-tschoening merged pull request #21: Add support for building log4cxx as a statically linked library on Windows

2020-03-30 Thread GitBox
ams-tschoening merged pull request #21: Add support for building log4cxx as a statically linked library on Windows URL: https://github.com/apache/logging-log4cxx/pull/21 This is an automated message from the Apache Git Servi

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #21: Add support for building log4cxx as a statically linked library on Windows

2020-03-30 Thread GitBox
ams-tschoening commented on issue #21: Add support for building log4cxx as a statically linked library on Windows URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605877990 Then please add `=yes|no|on|off` as necessary/useful for `-D*_STATIC`, so that its in line with th

[GitHub] [logging-log4cxx] stephen-webb commented on issue #21: Add support for building log4cxx as a statically linked library on Windows

2020-03-30 Thread GitBox
stephen-webb commented on issue #21: Add support for building log4cxx as a statically linked library on Windows URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605873078 Correction, =yes is equivalent to existence of a definition On Mon, Mar 30, 2020, 7:10 PM Step

[GitHub] [logging-log4cxx] stephen-webb commented on issue #21: Add support for building log4cxx as a statically linked library on Windows

2020-03-30 Thread GitBox
stephen-webb commented on issue #21: Add support for building log4cxx as a statically linked library on Windows URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605849220 No, they work the same, except the Build shared is on by default. The =on does no more than the ex

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #21: Add support for building log4cxx as a statically linked library on Windows

2020-03-30 Thread GitBox
ams-tschoening commented on issue #21: Add support for building log4cxx as a statically linked library on Windows URL: https://github.com/apache/logging-log4cxx/pull/21#issuecomment-605838327 Any reason why `-DAPU_STATIC` and `-DAPR_STATIC` are not documented with something like `=off|on`

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #21: Add support for building log4cxx as a statically linked library on Windows

2020-03-30 Thread GitBox
ams-tschoening commented on a change in pull request #21: Add support for building log4cxx as a statically linked library on Windows URL: https://github.com/apache/logging-log4cxx/pull/21#discussion_r390155388 ## File path: src/site/apt/building/cmake.apt ## @@ -50,6 +50,1