[GitHub] [logging-log4j2] trejkaz closed pull request #350: Introduce Policeman's Forbidden API Checker

2020-03-15 Thread GitBox
trejkaz closed pull request #350: Introduce Policeman's Forbidden API Checker URL: https://github.com/apache/logging-log4j2/pull/350 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [logging-log4j2] remkop commented on issue #349: Fix erroneous usage of default locale

2020-03-15 Thread GitBox
remkop commented on issue #349: Fix erroneous usage of default locale URL: https://github.com/apache/logging-log4j2/pull/349#issuecomment-599269469 That makes sense. Thank you for the clarification. (Perhaps in that case a test could be created with `Locale.setDefault` where the old

[GitHub] [logging-log4j2] trejkaz commented on issue #349: Fix erroneous usage of default locale

2020-03-15 Thread GitBox
trejkaz commented on issue #349: Fix erroneous usage of default locale URL: https://github.com/apache/logging-log4j2/pull/349#issuecomment-599266980 A config file should be assumed to work the same irrespective of the locale the machine is running in. By parsing numbers in the default local

[GitHub] [logging-log4j2] remkop commented on issue #349: Fix erroneous usage of default locale

2020-03-15 Thread GitBox
remkop commented on issue #349: Fix erroneous usage of default locale URL: https://github.com/apache/logging-log4j2/pull/349#issuecomment-599266708 If providing a test is challenging, can you at least provide a rationale on why the change is necessary? Why is Locale.ROOT better than Locale

[GitHub] [logging-log4j2] trejkaz commented on issue #349: Fix erroneous usage of default locale

2020-03-15 Thread GitBox
trejkaz commented on issue #349: Fix erroneous usage of default locale URL: https://github.com/apache/logging-log4j2/pull/349#issuecomment-599265206 I thought I'd try introducing forbidden-apis, but while looking at the logs, I notice that error-prone is in use already, so it's quite possib

[GitHub] [logging-log4j2] trejkaz opened a new pull request #350: Introduce Policeman's Forbidden API Checker

2020-03-15 Thread GitBox
trejkaz opened a new pull request #350: Introduce Policeman's Forbidden API Checker URL: https://github.com/apache/logging-log4j2/pull/350 This should be interesting. This is an automated message from the Apache Git Service.

[jira] [Commented] (LOG4J2-2588) Unable to reinstate old timeMillis timestamp using log4j2.clock property in JSON layout

2020-03-15 Thread Daniel Kirkdorffer (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059807#comment-17059807 ] Daniel Kirkdorffer commented on LOG4J2-2588: [~siwyd] We handled the issue b

[jira] [Closed] (LOG4J2-2806) Strange usage of WeakMapFactory in LoggerRegistry

2020-03-15 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers closed LOG4J2-2806. --- Resolution: Won't Do Closing at reporters request. > Strange usage of WeakMapFactory in LoggerRegis

[GitHub] [logging-log4j2] trejkaz commented on issue #349: Fix erroneous usage of default locale

2020-03-15 Thread GitBox
trejkaz commented on issue #349: Fix erroneous usage of default locale URL: https://github.com/apache/logging-log4j2/pull/349#issuecomment-599222520 That seems challenging. This is an automated message from the Apache Git Serv

[jira] [Commented] (LOG4J2-2588) Unable to reinstate old timeMillis timestamp using log4j2.clock property in JSON layout

2020-03-15 Thread Simon Wydooghe (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059657#comment-17059657 ] Simon Wydooghe commented on LOG4J2-2588: [~dankirkd] No, afraid not. > Unable t

[GitHub] [logging-log4j2] remkop commented on issue #349: Fix erroneous usage of default locale

2020-03-15 Thread GitBox
remkop commented on issue #349: Fix erroneous usage of default locale URL: https://github.com/apache/logging-log4j2/pull/349#issuecomment-599203151 Could you add a breaking test that passes with your patch? This is an automate

[GitHub] [logging-log4j2] trejkaz opened a new pull request #349: Fix erroneous usage of default locale

2020-03-15 Thread GitBox
trejkaz opened a new pull request #349: Fix erroneous usage of default locale URL: https://github.com/apache/logging-log4j2/pull/349 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (LOG4J2-2806) Strange usage of WeakMapFactory in LoggerRegistry

2020-03-15 Thread Grzegorz Grzybek (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059579#comment-17059579 ] Grzegorz Grzybek commented on LOG4J2-2806: -- I'm not sure anything can be done h