stephen-webb commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-580994002
@rm5248 Can you tell me what I would need to change to install a pkgconfig
file?
-
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373754317
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/proje
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373754082
##
File path: pom.xml
##
@@ -65,7 +65,7 @@
scm:git:http://gitbox.apache.org/repos/asf/logging-
rm5248 commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-580969003
Also: this doesn't install a pkgconfig file at all; that would be needed for
other non-cmake buildsystems to work with.
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373740646
##
File path: src/main/include/CMakeLists.txt
##
@@ -0,0 +1,101 @@
+# Configure
+if(WIN32)
+add_custom_target(configur
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373739795
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/projectVersi
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373738203
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
Review comment:
I
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373737584
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/proje
[
https://issues.apache.org/jira/browse/LOG4J2-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027886#comment-17027886
]
Andrey Turbanov edited comment on LOG4J2-2769 at 2/1/20 12:09 AM:
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373736174
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/projectVersi
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373735942
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
+include(src/cmake/projectVersi
rm5248 commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373735482
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
Review comment:
Is it pos
rm5248 commented on issue #12: Add support for building and testing with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-580961254
Why use Maven at all at that point? What I do for C++ projects is to just
generate the site with Doxygen; it's possible to then make
[
https://issues.apache.org/jira/browse/LOG4J2-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027886#comment-17027886
]
Andrey Turbanov edited comment on LOG4J2-2769 at 1/31/20 11:49 PM:
---
[
https://issues.apache.org/jira/browse/LOG4J2-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027886#comment-17027886
]
Andrey Turbanov edited comment on LOG4J2-2769 at 1/31/20 11:48 PM:
---
[
https://issues.apache.org/jira/browse/LOG4J2-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027886#comment-17027886
]
Andrey Turbanov commented on LOG4J2-2769:
-
Proposed patch:
{code}
Index:
log4j-
Andrey Turbanov created LOG4J2-2769:
---
Summary: AtomicMoveNotSupportedException shouldn't be logged as
ERROR
Key: LOG4J2-2769
URL: https://issues.apache.org/jira/browse/LOG4J2-2769
Project: Log4j 2
bkuker commented on issue #337: Update ConfigurationSource.java
URL: https://github.com/apache/logging-log4j2/pull/337#issuecomment-580948242
Thanks, yes I'll do that Monday!
This is an automated message from the Apache Git Se
jvz commented on issue #12: Add support for building and testing with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-580930215
> While we are at it, it should be discussed if CMAKE should replace
Autotools on Linux as well, leaving only the ANT/MAVEN-parts in plac
rgoers commented on issue #337: Update ConfigurationSource.java
URL: https://github.com/apache/logging-log4j2/pull/337#issuecomment-580913709
Can you create a Jira issue for this. It would also be great to include a
unit test that fails without this fix.
---
bkuker opened a new pull request #337: Update ConfigurationSource.java
URL: https://github.com/apache/logging-log4j2/pull/337
I think this needs to store the data so that resetInputStream() works.
The jmx function LoggerContextAdmin::getConfigText throws a NPE if you have
previously call
ams-tschoening commented on issue #12: Add support for building and testing
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-580837297
From my understanding this is CMAKE without removing anything, while #14 is
CMAKE with removing at least ANT, because in the
jvz commented on issue #12: Add support for building and testing with cmake
URL: https://github.com/apache/logging-log4cxx/pull/12#issuecomment-580815431
Can anything from this be combined with #14? I love the simplification if
possible rather than supporting multiple build systems.
--
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373577204
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundation (ASF) un
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373577696
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software Foundation (ASF) un
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373573832
##
File path: pom.xml
##
@@ -65,7 +65,7 @@
scm:git:http://gitbox.apache.org/repos/asf/logging-log4cxx.gi
jvz commented on a change in pull request #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373572922
##
File path: pom.xml
##
@@ -65,7 +65,7 @@
scm:git:http://gitbox.apache.org/repos/asf/logging-log4cxx.gi
jvz commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-580809182
I ❤️ PRs that have huge negative line counts like this! I'm not super
familiar with the tooling in use, though I'll try this out over the weekend.
jvz commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r373566976
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/
jvz commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r373564119
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/
vy commented on a change in pull request #335: Import of LogstashLayout as
JsonTemplateLayout
URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r373474960
##
File path:
log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l
31 matches
Mail list logo
