[GitHub] [logging-log4cxx] stephen-webb opened a new pull request #14: Replace ant build with cmake

2020-01-30 Thread GitBox
stephen-webb opened a new pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [logging-log4j2] remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580583586 @vy Understood. That makes sense to me. This is an automated message

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580267355 > Not sure I agree... What is the trade-off? What do users gain when they select something other than ThreadLocal? If you'd recall,

[GitHub] [logging-log4j2] remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580261245 Not sure I agree... What is the trade-off? What do users gain when they select something other than ThreadLocal?

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580240386 Triggered by @richardstartin's observation, why don't we allow all 3 co-exist in the code base? After all, the call site doesn't care abou

[jira] [Closed] (LOG4J2-2755) Invalid JSON in JsonLayout

2020-01-30 Thread Christian Kemper (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Kemper closed LOG4J2-2755. Resolution: Invalid Found the issue in an invalid configuration. The incorrect Json Strin

[GitHub] [logging-log4j2] richardstartin commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
richardstartin commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580229964 > I don’t think we’re measuring the cost of GC anywhere, are we? At this scale, there are so many confounding factors w

[jira] [Commented] (LOG4J2-1973) FailoverAppenders fail to start

2020-01-30 Thread Ronan Lanigan (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026627#comment-17026627 ] Ronan Lanigan commented on LOG4J2-1973: --- I've run into this same issue with 2.13.0

[GitHub] [logging-log4j2] remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580215790 > I would be interested to know the marginal cost of G1 in this case. The most interesting metric is MPMC/G1 vs MPMC/other GC I

[GitHub] [logging-log4j2] remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580205695 Well, what is the trade off? What benefits do we gain in return of this worse performance? --

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580197240 And the following question still stands open: Given TLA results constitute the baseline, what is the pool implied maximum performance degr

[GitHub] [logging-log4j2] richardstartin commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
richardstartin commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580196090 To be clear, that’s just a hunch. I haven’t run the benchmarks let alone profiled them.

[jira] [Reopened] (LOG4J2-2457) RollingRandomAccessFileManager ignores new file patterns from programmatic reconfiguration

2020-01-30 Thread Heiko Schwanke (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heiko Schwanke reopened LOG4J2-2457: The patch creates files with .gz extension after reconfiguration, but they are not compressed

[GitHub] [logging-log4j2] vy edited a comment on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
vy edited a comment on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580189684 > The NoOp benchmark should be renamed Allocate Check. > I don't believe that `MpmcArrayQueue` is lock-free Th

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-30 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580189684 > The NoOp benchmark should be renamed Allocate Check. > I don't believe that `MpmcArrayQueue` is lock-free The defini