[GitHub] [logging-log4j2] carterkozak commented on issue #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
carterkozak commented on issue #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-573773269 It looks like we have five occurrences of `instanceof DirectWriteRolloverStrategy` across `RollingFileManager` and `RollingRand

[jira] [Commented] (LOG4J2-2757) JDBCAppender tableName from Main Arguments Lookup

2020-01-13 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014486#comment-17014486 ] Gary D. Gregory commented on LOG4J2-2757: - You should try to use a $$ instead of

[GitHub] [logging-log4j2] ChristophKaser commented on issue #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
ChristophKaser commented on issue #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-573749205 Done: https://issues.apache.org/jira/browse/LOG4J2-2758 This

[jira] [Created] (LOG4J2-2758) RollingFileAppender: NPE when using a custom DirectFileRolloverStrategy without fileName

2020-01-13 Thread Christoph Kaser (Jira)
Christoph Kaser created LOG4J2-2758: --- Summary: RollingFileAppender: NPE when using a custom DirectFileRolloverStrategy without fileName Key: LOG4J2-2758 URL: https://issues.apache.org/jira/browse/LOG4J2-2758

[jira] [Commented] (LOG4J2-2757) JDBCAppender tableName from Main Arguments Lookup

2020-01-13 Thread Petar Petrov (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014439#comment-17014439 ] Petar Petrov commented on LOG4J2-2757: -- Thanks for the feedback [~ggregory] ! That

[jira] [Commented] (LOG4J2-2757) JDBCAppender tableName from Main Arguments Lookup

2020-01-13 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014423#comment-17014423 ] Gary D. Gregory commented on LOG4J2-2757: - [~ppetrov_mp] *Your* {{main()}} meth

[GitHub] [logging-log4j2] carterkozak commented on issue #330: Fixed log message in RollingFileAppender

2020-01-13 Thread GitBox
carterkozak commented on issue #330: Fixed log message in RollingFileAppender URL: https://github.com/apache/logging-log4j2/pull/330#issuecomment-573670803 Good catch,Thanks! I'll get this merged when I have a moment. This is

[GitHub] [logging-log4j2] carterkozak commented on issue #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
carterkozak commented on issue #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-573670239 Thanks @ChristophKaser, would you mind opening a jira issue to accompany this change? -

[GitHub] [logging-log4j2] carterkozak edited a comment on issue #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
carterkozak edited a comment on issue #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331#issuecomment-573670239 Thanks @ChristophKaser, would you mind opening a jira issue to accompany this change? https://issues.apache.org/jira/p

[GitHub] [logging-log4j2] ChristophKaser opened a new pull request #331: Fixed check for RollingFileManager, directWrite

2020-01-13 Thread GitBox
ChristophKaser opened a new pull request #331: Fixed check for RollingFileManager,directWrite URL: https://github.com/apache/logging-log4j2/pull/331 Bugfix: Use the interface DirectFileRolloverStrategy instead of the concrete implementation DirectWriteRolloverStrategy when deciding whether

[jira] [Updated] (LOG4J2-2757) JDBCAppender tableName from Main Arguments Lookup

2020-01-13 Thread Petar Petrov (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petar Petrov updated LOG4J2-2757: - Description: Hi,  I've posted this on StackOverflow, however, I could not really get any soluti

[jira] [Created] (LOG4J2-2757) JDBCAppender tableName from Main Arguments Lookup

2020-01-13 Thread Petar Petrov (Jira)
Petar Petrov created LOG4J2-2757: Summary: JDBCAppender tableName from Main Arguments Lookup Key: LOG4J2-2757 URL: https://issues.apache.org/jira/browse/LOG4J2-2757 Project: Log4j 2 Issue Typ

[jira] [Commented] (LOG4J2-2661) JDBC Append should reconnect when connection is lost in JdbcDatabaseManager.writeInternal()

2020-01-13 Thread Petar Petrov (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014127#comment-17014127 ] Petar Petrov commented on LOG4J2-2661: -- Hi, I've got this issue as well.   {code:j