[GitHub] [logging-log4php] kategray commented on issue #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
kategray commented on issue #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11#issuecomment-547283588 @d-ulyanov It could use some love. I'm working on it :) This is an automated messag

[GitHub] [logging-log4php] kategray removed a comment on issue #3: Add a new filter that matches against a logger name

2019-10-28 Thread GitBox
kategray removed a comment on issue #3: Add a new filter that matches against a logger name URL: https://github.com/apache/logging-log4php/pull/3#issuecomment-547178213 @creature Hello, I'm going through old commits and trying to get everything merged. Would you be able to update t

[GitHub] [logging-log4php] kategray commented on issue #3: Add a new filter that matches against a logger name

2019-10-28 Thread GitBox
kategray commented on issue #3: Add a new filter that matches against a logger name URL: https://github.com/apache/logging-log4php/pull/3#issuecomment-547283004 @rgoers I have created a merge branch that incorporates these changes into the develop branch. If you edit the pull reques

[GitHub] [logging-log4php] d-ulyanov commented on issue #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
d-ulyanov commented on issue #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11#issuecomment-547282930 Funny, I thought that project is dead :) This is an automated message from the Apac

[GitHub] [logging-log4php] rgoers commented on issue #13: tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path

2019-10-28 Thread GitBox
rgoers commented on issue #13: tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path URL: https://github.com/apache/logging-log4php/pull/13#issuecomment-547252891 OK. Please go ahead with that.

[GitHub] [logging-log4php] rgoers commented on issue #12: add throwable information to xml layout if present

2019-10-28 Thread GitBox
rgoers commented on issue #12: add throwable information to xml layout if present URL: https://github.com/apache/logging-log4php/pull/12#issuecomment-547252755 OK. Got ahead and create the unit test. This is an automated mess

[GitHub] [logging-log4php] rgoers commented on issue #15: Support logging of PHP 7 error class

2019-10-28 Thread GitBox
rgoers commented on issue #15: Support logging of PHP 7 error class URL: https://github.com/apache/logging-log4php/pull/15#issuecomment-547252569 Leaving open for now pending feedback. This is an automated message from the Apa

[GitHub] [logging-log4php] rgoers commented on issue #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
rgoers commented on issue #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11#issuecomment-547252097 I agree. Closing. This is an automated message from the Apache Git Service. To respond

[GitHub] [logging-log4php] rgoers closed pull request #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
rgoers closed pull request #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4php] rgoers commented on issue #7: Fix mismatched function signature and function call

2019-10-28 Thread GitBox
rgoers commented on issue #7: Fix mismatched function signature and function call URL: https://github.com/apache/logging-log4php/pull/7#issuecomment-547251946 It appears this was already merged. It would have been prior to the migration to GitHub. Closing based on that. --

[GitHub] [logging-log4php] rgoers closed pull request #7: Fix mismatched function signature and function call

2019-10-28 Thread GitBox
rgoers closed pull request #7: Fix mismatched function signature and function call URL: https://github.com/apache/logging-log4php/pull/7 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [logging-log4php] rgoers merged pull request #14: Replaced the deprecated function split() that will be removed in PHP 7.

2019-10-28 Thread GitBox
rgoers merged pull request #14: Replaced the deprecated function split() that will be removed in PHP 7. URL: https://github.com/apache/logging-log4php/pull/14 This is an automated message from the Apache Git Service. To resp

[GitHub] [logging-log4php] rgoers commented on issue #14: Replaced the deprecated function split() that will be removed in PHP 7.

2019-10-28 Thread GitBox
rgoers commented on issue #14: Replaced the deprecated function split() that will be removed in PHP 7. URL: https://github.com/apache/logging-log4php/pull/14#issuecomment-547251617 Merging based on feedback This is an automat

[GitHub] [logging-log4php] rgoers merged pull request #5: typo fixes

2019-10-28 Thread GitBox
rgoers merged pull request #5: typo fixes URL: https://github.com/apache/logging-log4php/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [logging-log4php] rgoers commented on issue #5: typo fixes

2019-10-28 Thread GitBox
rgoers commented on issue #5: typo fixes URL: https://github.com/apache/logging-log4php/pull/5#issuecomment-547251446 Merging based no review feedback This is an automated message from the Apache Git Service. To respond to the

[GitHub] [logging-log4php] kategray commented on issue #3: Add a new filter that matches against a logger name

2019-10-28 Thread GitBox
kategray commented on issue #3: Add a new filter that matches against a logger name URL: https://github.com/apache/logging-log4php/pull/3#issuecomment-547178213 @creature Hello, I'm going through old commits and trying to get everything merged. Would you be able to update the reque

[GitHub] [logging-log4php] kategray commented on issue #13: tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path

2019-10-28 Thread GitBox
kategray commented on issue #13: tweak log4php file:line column to optionally ignore log4php wrappers and optionally shorten file path URL: https://github.com/apache/logging-log4php/pull/13#issuecomment-547175609 @rgoers Like the other commit, looks good in theory, but I'd like to get a un

[GitHub] [logging-log4php] kategray commented on issue #11: Graylog appender + Gelf layout

2019-10-28 Thread GitBox
kategray commented on issue #11: Graylog appender + Gelf layout URL: https://github.com/apache/logging-log4php/pull/11#issuecomment-547173236 @rgoers it looks like this was already approved and merged - I'd imagine the PR can be closed. -

[GitHub] [logging-log4php] kategray edited a comment on issue #14: Replaced the deprecated function split() that will be removed in PHP 7.

2019-10-28 Thread GitBox
kategray edited a comment on issue #14: Replaced the deprecated function split() that will be removed in PHP 7. URL: https://github.com/apache/logging-log4php/pull/14#issuecomment-547169255 @rgoers Single line fix, in line with the PHP5 deprecation. I'd suggest approval.

[GitHub] [logging-log4php] kategray commented on issue #15: Support logging of PHP 7 error class

2019-10-28 Thread GitBox
kategray commented on issue #15: Support logging of PHP 7 error class URL: https://github.com/apache/logging-log4php/pull/15#issuecomment-547171368 @rgoers my recommendation would be to close this issue as resolved, unless @czjvic's issue specifically requires not checking the type of the e

[GitHub] [logging-log4php] kategray commented on issue #14: Replaced the deprecated function split() that will be removed in PHP 7.

2019-10-28 Thread GitBox
kategray commented on issue #14: Replaced the deprecated function split() that will be removed in PHP 7. URL: https://github.com/apache/logging-log4php/pull/14#issuecomment-547169255 @rgoers Single line fix, in line with the PHP5 deprecation. ---

[GitHub] [logging-log4php] kategray commented on issue #5: typo fixes

2019-10-28 Thread GitBox
kategray commented on issue #5: typo fixes URL: https://github.com/apache/logging-log4php/pull/5#issuecomment-547168971 @rgoers There doesn't appear to be any code issues with this commit - it's just fixing typos. Travis failed because builds are failing. -

[GitHub] [logging-log4php] rgoers merged pull request #22: Update travis configuration and PHPUnit version

2019-10-28 Thread GitBox
rgoers merged pull request #22: Update travis configuration and PHPUnit version URL: https://github.com/apache/logging-log4php/pull/22 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [logging-log4php] rgoers merged pull request #2: Improve documentation of filters

2019-10-28 Thread GitBox
rgoers merged pull request #2: Improve documentation of filters URL: https://github.com/apache/logging-log4php/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [logging-log4php] rgoers commented on issue #2: Improve documentation of filters

2019-10-28 Thread GitBox
rgoers commented on issue #2: Improve documentation of filters URL: https://github.com/apache/logging-log4php/pull/2#issuecomment-547136597 I've looked at these. They all are for documentation so shouldn't cause any problems.

[jira] [Created] (LOGCXX-508) sync

2019-10-28 Thread paul deauna (Jira)
paul deauna created LOGCXX-508: -- Summary: sync Key: LOGCXX-508 URL: https://issues.apache.org/jira/browse/LOGCXX-508 Project: Log4cxx Issue Type: Bug Components: Build, Core Affect

[jira] [Commented] (LOG4J2-2716) Add support for Kubernetes

2019-10-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961313#comment-16961313 ] ASF subversion and git services commented on LOG4J2-2716: - Commi

[jira] [Commented] (LOG4J2-2716) Add support for Kubernetes

2019-10-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961312#comment-16961312 ] ASF subversion and git services commented on LOG4J2-2716: - Commi

[jira] [Created] (LOG4J2-2716) Add support for Kubernetes

2019-10-28 Thread Ralph Goers (Jira)
Ralph Goers created LOG4J2-2716: --- Summary: Add support for Kubernetes Key: LOG4J2-2716 URL: https://issues.apache.org/jira/browse/LOG4J2-2716 Project: Log4j 2 Issue Type: New Feature

[jira] [Comment Edited] (LOG4J2-2342) highlight not working anymore

2019-10-28 Thread Anton (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960837#comment-16960837 ] Anton edited comment on LOG4J2-2342 at 10/28/19 7:59 AM: - {{For

[jira] [Commented] (LOG4J2-2342) highlight not working anymore

2019-10-28 Thread Anton (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960837#comment-16960837 ] Anton commented on LOG4J2-2342: --- {{For those, who is searching for the solution - try this