[GitHub] [logging-log4cxx] bblough commented on issue #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on issue #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#issuecomment-541446258 Pretty-print option added. All changes pushed. This is an automated message from the Apache Gi

[GitHub] [logging-log4cxx] bblough commented on issue #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on issue #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#issuecomment-541432949 For my use case, I think single-line log entries are preferred. But I can see how other use cases might benefit from pretty-printed output. I'll add it as a

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283976 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283267 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283269 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283225 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283190 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] bblough commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
bblough commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334283090 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334277252 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334276904 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334276672 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334277332 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334276925 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #13: Add JSONLayout class

2019-10-13 Thread GitBox
ams-tschoening commented on a change in pull request #13: Add JSONLayout class URL: https://github.com/apache/logging-log4cxx/pull/13#discussion_r334277314 ## File path: src/main/cpp/jsonlayout.cpp ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF