[GitHub] [logging-log4j2] rgoers commented on issue #275: Log4 j2 2621

rgoers commented on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500710403 Presumably shading should provide support for ServiceLoader since it is standard java. We already use it to load Log4J core. The only difficulty will be for people who

[GitHub] [logging-log4j2] remkop commented on issue #275: Log4 j2 2621

remkop commented on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500691086 About the shading issue, how do these changes improve things? This is an automated message from the Apa

[GitHub] [logging-log4j2] rgoers commented on issue #275: Log4 j2 2621

rgoers commented on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500685968 OK. I thought about it. Services implemented with ServiceLoader are only loaded once. That would mean only a single instance of a Layout or Filter could be created. Th

[GitHub] [logging-log4j2] rgoers edited a comment on issue #275: Log4 j2 2621

rgoers edited a comment on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500678405 The modifications necessary for LOG4J2-2604 don't conflict at all with these changes. It would do something similar to what writeServiceFile does, although writ

[GitHub] [logging-log4j2] rgoers commented on issue #275: Log4 j2 2621

rgoers commented on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500678405 The modifications necessary for LOG4J2-2604 don't conflict at all with these changes. It would do something similar to what writeServiceFile does, although writing the

[GitHub] [logging-log4j2] rgoers edited a comment on issue #275: Log4 j2 2621

rgoers edited a comment on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500676166 See https://github.com/apache/logging-log4j2/blob/LOG4J2-2621/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/processor/PluginProcessor.java method

[GitHub] [logging-log4j2] remkop commented on issue #275: Log4 j2 2621

remkop commented on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500677740 OK thanks. I was looking at this with a view to in the future add another visitor that generates an additional file for the plugins (see https://issues.apache.org/jira

[GitHub] [logging-log4j2] rgoers commented on issue #275: Log4 j2 2621

rgoers commented on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500677053 It just occurred to me that I haven't yet updated the documentation. I will have to do that before merging. ---

[GitHub] [logging-log4j2] rgoers edited a comment on issue #275: Log4 j2 2621

rgoers edited a comment on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500676166 See https://github.com/apache/logging-log4j2/blob/LOG4J2-2621/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/processor/PluginProcessor.java method

[GitHub] [logging-log4j2] rgoers commented on issue #275: Log4 j2 2621

rgoers commented on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500676166 See https://github.com/apache/logging-log4j2/blob/LOG4J2-2621/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/processor/PluginProcessor.java method writeC

[GitHub] [logging-log4j2] remkop commented on issue #275: Log4 j2 2621

remkop commented on issue #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275#issuecomment-500671754 I took a look. Many files changed but vast majority is import changes. Files of interest: M log4j-core/src/main/java/org/apache/logging/log4j/core/config/plug

[GitHub] [logging-log4j2] rgoers opened a new pull request #275: Log4 j2 2621

rgoers opened a new pull request #275: Log4 j2 2621 URL: https://github.com/apache/logging-log4j2/pull/275 Moves plugin support to its own module. Generates a Java file for recording plugins instead of Log4jPlugins.dat. Maintains support for Plugins generated in Log4j 2 2.x. -

[jira] [Commented] (LOG4J2-2621) Create log4j-plugins module and use ServiceLoader to load plugins

[ https://issues.apache.org/jira/browse/LOG4J2-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860492#comment-16860492 ] ASF subversion and git services commented on LOG4J2-2621: - Commi