[GitHub] garydgregory commented on issue #251: Remove garbage creation introduced by LOG4J2-2301

garydgregory commented on issue #251: Remove garbage creation introduced by LOG4J2-2301 URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453756721 Can't this be testing with a single thread? Maybe we need to add a package private methods to ease testing? --

[GitHub] cakofony edited a comment on issue #251: Remove garbage creation introduced by LOG4J2-2301

cakofony edited a comment on issue #251: Remove garbage creation introduced by LOG4J2-2301 URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453748782 This issue is a bit difficult to test for because it requires several threads to log. There's allocation if a ThreadLocal

[GitHub] cakofony commented on issue #251: Remove garbage creation introduced by LOG4J2-2301

cakofony commented on issue #251: Remove garbage creation introduced by LOG4J2-2301 URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453748782 This issue is a bit difficult to test test for because it requires several threads to log. There's allocation if a ThreadLocal `

[GitHub] garydgregory commented on issue #251: Remove garbage creation introduced by LOG4J2-2301

garydgregory commented on issue #251: Remove garbage creation introduced by LOG4J2-2301 URL: https://github.com/apache/logging-log4j2/pull/251#issuecomment-453748280 +1 having a failing test, otherwise we are almost guaranteeing the regression will come back :-( Gary On Fri