[jira] [Work logged] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?focusedWorklogId=183938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183938 ] ASF GitHub Bot logged work on LOG4J2-2530: -- Author: ASF GitHub Bot

[GitHub] travisspencer commented on issue #250: LOG4J2-2530 Generalize check for MapMessage

2019-01-10 Thread GitBox
travisspencer commented on issue #250: LOG4J2-2530 Generalize check for MapMessage URL: https://github.com/apache/logging-log4j2/pull/250#issuecomment-453257755 Will do that and the paperwork tomorrow or over the weekend. On Thu, Jan 10, 2019, 10:01 PM Carter Kozak Would you mind ad

[GitHub] cakofony commented on issue #250: LOG4J2-2530 Generalize check for MapMessage

2019-01-10 Thread GitBox
cakofony commented on issue #250: LOG4J2-2530 Generalize check for MapMessage URL: https://github.com/apache/logging-log4j2/pull/250#issuecomment-453252227 Would you mind adding tests to make sure we don't reintroduce this regression? The implementation looks great :-)

[jira] [Work logged] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?focusedWorklogId=183928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183928 ] ASF GitHub Bot logged work on LOG4J2-2530: -- Author: ASF GitHub Bot

[GitHub] cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453231196 Looks great, thank you! This is an automated message from the Apache

[GitHub] travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453230516 ecd05cb225423418f1db91526ed444d8f1ced55f is what you had in mind? If so, and if there's nothing more to change, I'll squash all

[jira] [Work started] (LOG4J2-913) Allow to load log4j2 configuration from a centralized repository, like a database or a webservice

2019-01-10 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LOG4J2-913 started by Ralph Goers. -- > Allow to load log4j2 configuration from a centralized repository, like a > databa

[jira] [Commented] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread Travis Spencer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739611#comment-16739611 ] Travis Spencer commented on LOG4J2-2530: on it! > StructuredDataMessage is not

[GitHub] cakofony closed pull request #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
cakofony closed pull request #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[jira] [Commented] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread Carter Kozak (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739559#comment-16739559 ] Carter Kozak commented on LOG4J2-2530: -- Not at all, your input on my poor implement

[GitHub] travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453151808 Sure! I'm here to help :) This is an automated message from t

[GitHub] cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453151485 Closing this pr, @travisspencer is taking care of the fix :-) This i

[GitHub] cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453151292 That makes sense, thanks for the quick reply! Another potential solution would be to implement `MapFormat.JAVA_UNQUOTED` which exactl

[jira] [Commented] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread Travis Spencer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739555#comment-16739555 ] Travis Spencer commented on LOG4J2-2530: Ha, [~ckozak], you're fast. Sorry for m

[GitHub] travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
travisspencer commented on issue #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453150465 We have customers that parse these log messages from the DB. Would be nice to not change the format. -

[jira] [Commented] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread Travis Spencer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739551#comment-16739551 ] Travis Spencer commented on LOG4J2-2530: Looks like LOG4J2-2522 is a partial fix

[jira] [Work logged] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?focusedWorklogId=183763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183763 ] ASF GitHub Bot logged work on LOG4J2-2530: -- Author: ASF GitHub Bot

[GitHub] travisspencer commented on a change in pull request #250: LOG4J2-2530 Generalize check for MapMessage

2019-01-10 Thread GitBox
travisspencer commented on a change in pull request #250: LOG4J2-2530 Generalize check for MapMessage URL: https://github.com/apache/logging-log4j2/pull/250#discussion_r246816556 ## File path: log4j-samples/log4j-samples-loggerProperties/src/main/java/org/apache/logging/log4j/looku

[jira] [Work logged] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?focusedWorklogId=183755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183755 ] ASF GitHub Bot logged work on LOG4J2-2530: -- Author: ASF GitHub Bot

[GitHub] travisspencer commented on a change in pull request #250: LOG4J2-2530 Generalize check for MapMessage

2019-01-10 Thread GitBox
travisspencer commented on a change in pull request #250: LOG4J2-2530 Generalize check for MapMessage URL: https://github.com/apache/logging-log4j2/pull/250#discussion_r246810327 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MapPatternConverter.java

[jira] [Commented] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread Carter Kozak (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739521#comment-16739521 ] Carter Kozak commented on LOG4J2-2530: -- Thanks [~tspencer]! I've pushed a potential

[jira] [Work logged] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?focusedWorklogId=183753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183753 ] ASF GitHub Bot logged work on LOG4J2-2530: -- Author: ASF GitHub Bot

[jira] [Created] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread Travis Spencer (JIRA)
Travis Spencer created LOG4J2-2530: -- Summary: StructuredDataMessage is not logged Key: LOG4J2-2530 URL: https://issues.apache.org/jira/browse/LOG4J2-2530 Project: Log4j 2 Issue Type: Bug

[GitHub] cakofony commented on a change in pull request #250: LOG4J2-2530 Generalize check for MapMessage

2019-01-10 Thread GitBox
cakofony commented on a change in pull request #250: LOG4J2-2530 Generalize check for MapMessage URL: https://github.com/apache/logging-log4j2/pull/250#discussion_r246809840 ## File path: log4j-samples/log4j-samples-loggerProperties/src/main/java/org/apache/logging/log4j/lookup/Map

[jira] [Work logged] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?focusedWorklogId=183752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183752 ] ASF GitHub Bot logged work on LOG4J2-2530: -- Author: ASF GitHub Bot

[GitHub] cakofony commented on a change in pull request #250: LOG4J2-2530 Generalize check for MapMessage

2019-01-10 Thread GitBox
cakofony commented on a change in pull request #250: LOG4J2-2530 Generalize check for MapMessage URL: https://github.com/apache/logging-log4j2/pull/250#discussion_r246808988 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/MapPatternConverter.java #

[jira] [Work logged] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?focusedWorklogId=183750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183750 ] ASF GitHub Bot logged work on LOG4J2-2530: -- Author: ASF GitHub Bot

[GitHub] travisspencer opened a new pull request #250: LOG4J2-2530 Generalize check for MapMessage

2019-01-10 Thread GitBox
travisspencer opened a new pull request #250: LOG4J2-2530 Generalize check for MapMessage URL: https://github.com/apache/logging-log4j2/pull/250 This fixes LOG4J2-2530 by generalizing the check for `MapMessage` to catch not only `StringMapMessage` objects but also `StructuredMapMessgage` o

[jira] [Commented] (LOG4J2-2530) StructuredDataMessage is not logged

2019-01-10 Thread Carter Kozak (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739525#comment-16739525 ] Carter Kozak commented on LOG4J2-2530: -- The MapLookup break has already been fixed

[GitHub] cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
cakofony commented on issue #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249#issuecomment-453138694 Are we okay with adding quotes to map values here? This is an automa

[GitHub] cakofony opened a new pull request #249: Fix MapMessage -> StringMapMessage API breaks

2019-01-10 Thread GitBox
cakofony opened a new pull request #249: Fix MapMessage -> StringMapMessage API breaks URL: https://github.com/apache/logging-log4j2/pull/249 Note: This updates MapPatternConverter and MapMessageLookup to use MapMessage JAVA format, which is slightly different from the original output

[jira] [Work logged] (LOG4J2-2134) StackOverflowError at AwaitCompletionReliabilityStrategy

2019-01-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2134?focusedWorklogId=183624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183624 ] ASF GitHub Bot logged work on LOG4J2-2134: -- Author: ASF GitHub Bot

[GitHub] rbarbey commented on issue #221: [LOG4J2-2134] Stackoverflow at AwaitCompletionReliabilityStrategy.

2019-01-10 Thread GitBox
rbarbey commented on issue #221: [LOG4J2-2134] Stackoverflow at AwaitCompletionReliabilityStrategy. URL: https://github.com/apache/logging-log4j2/pull/221#issuecomment-453025941 With the latest version 2.11.1 I'm running into this issue as well. Will there be a patch release which includes