[jira] [Work logged] (LOG4J2-2433) Support MDCs with Kotlin coroutines

2018-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2433?focusedWorklogId=173103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-173103 ] ASF GitHub Bot logged work on LOG4J2-2433: -- Author: ASF GitHub Bot

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445393134 New pull https://github.com/apache/logging-log4j-kotlin/pull/8 submitted without the inlining, until we've decided how to handle th

[GitHub] rocketraman opened a new pull request #8: LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman opened a new pull request #8: LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/8 Add support for coroutines by fixing LOG4J2-2433. ThreadContext support is added to integrate the thread-local ThreadContext with coroutines context. Su

Build failed in Jenkins: Log4j 2 3.x #336

2018-12-07 Thread Apache Jenkins Server
See Changes: [garydgregory] [LOG4J2-1246] PatternLayout %date conversion pattern should render time -- [...truncated 1.45 MB...] Uploading: https://repository.apache.org/c

Jenkins build became unstable: Log4j 2 2.x #3767

2018-12-07 Thread Apache Jenkins Server
See

[jira] [Commented] (LOG4J2-1246) PatternLayout %date conversion pattern should render time zone designator for ISO-ISO8601

2018-12-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713299#comment-16713299 ] ASF subversion and git services commented on LOG4J2-1246: - Commi

[jira] [Commented] (LOG4J2-1246) PatternLayout %date conversion pattern should render time zone designator for ISO-ISO8601

2018-12-07 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713297#comment-16713297 ] ASF subversion and git services commented on LOG4J2-1246: - Commi

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445347915 > As per my other comment, this seems to work fine with the inlining Nope, my mistake, caller information does break with inl

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445343651 > Now if we could use some sort of compiler feature or macros to implement the caller info, then we can safely inline a lot of thin

[GitHub] jvz commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
jvz commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445338376 If you identify an awkward API in log4j-api, we can always work on improving that upstream and later using it in version 1.1.x. Feel

[GitHub] rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239916623 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt #

[GitHub] rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445312780 @jvz One approach is to do the message construction in the Kotlin code before delegating to log4j2. For example: ```

[GitHub] rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445312780 @jvz One approach is to do the message construction in the Kotlin code before delegating to log4j2. For example: ```

[GitHub] rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445312780 @jvz One approach is to do the message construction in the Kotlin code before delegating to log4j2. For example: ```

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445312780 @jvz One approach is to do the message construction in the Kotlin code before delegating to log4j2. For example: ``` in

[GitHub] rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman edited a comment on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445305670 @jvz There is an issue with this because a suspending function can't be converted to the Java-based Log4j2 `Supplier` witho

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445305670 @jvz There is an issue with this because a suspending function can't be converted to a Java `Supplier` without losing the suspensio

[GitHub] rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445291009 Hmm, that's odd. Works for me here. Let me see what is different on the build machine. ---

[GitHub] jvz commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
jvz commented on issue #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#issuecomment-445290342 Looks like a test failure in `LoggerCoroutinesTest`? This is an automated

[GitHub] jvz commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
jvz commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239870832 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt ## @@ -1

[GitHub] rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239859451 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt #

[jira] [Commented] (LOG4J2-2433) Support MDCs with Kotlin coroutines

2018-12-07 Thread Raman Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713026#comment-16713026 ] Raman Gupta commented on LOG4J2-2433: - Fixed in https://github.com/apache/logging-lo

[GitHub] rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239856567 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt #

[jira] [Commented] (LOG4J2-2518) Support suspend functions in supplier lambdas

2018-12-07 Thread Raman Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713024#comment-16713024 ] Raman Gupta commented on LOG4J2-2518: - Fixed in https://github.com/apache/logging-lo

[GitHub] jvz commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
jvz commented on a change in pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7#discussion_r239852037 ## File path: log4j-api-kotlin/src/main/kotlin/org/apache/logging/log4j/kotlin/KotlinLogger.kt ## @@ -1

[GitHub] rocketraman opened a new pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support

2018-12-07 Thread GitBox
rocketraman opened a new pull request #7: LOG4J-2518 LOG4J2-2433 Coroutines Support URL: https://github.com/apache/logging-log4j-kotlin/pull/7 Add support for coroutines by fixing [LOG4J-2518](https://issues.apache.org/jira/browse/LOG4J2-2518) and [LOG4J2-2433](https://issues.apache.org/j

[jira] [Created] (LOG4J2-2518) Support suspend functions in supplier lambdas

2018-12-07 Thread Raman Gupta (JIRA)
Raman Gupta created LOG4J2-2518: --- Summary: Support suspend functions in supplier lambdas Key: LOG4J2-2518 URL: https://issues.apache.org/jira/browse/LOG4J2-2518 Project: Log4j 2 Issue Type: New

[jira] [Commented] (LOGCXX-501) Sometimes the log files get locked and then deleted after application restart

2018-12-07 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712487#comment-16712487 ] Thorsten Schöning commented on LOGCXX-501: -- I'm not aware of such an issue and s