eric-milles opened a new pull request, #2158:
URL: https://github.com/apache/groovy/pull/2158
When MethodSelector#setMetaClassCallHandleIfNeeded links to
MetaObjectProtocol#invokeMethod(Object,String,Object[]), the sender class is
dropped.
--
This is an automated message from the Apache
codecov-commenter commented on PR #2160:
URL: https://github.com/apache/groovy/pull/2160#issuecomment-2744528942
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2160?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert merged PR #2160:
URL: https://github.com/apache/groovy/pull/2160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on code in PR #2154:
URL: https://github.com/apache/groovy/pull/2154#discussion_r2000136302
##
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy:
##
@@ -169,16 +168,9 @@ class JarJarTask extends DefaultTask {
it.into(ou
eric-milles commented on code in PR #2154:
URL: https://github.com/apache/groovy/pull/2154#discussion_r1997659214
##
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy:
##
@@ -169,16 +168,9 @@ class JarJarTask extends DefaultTask {
it.into(ou
paulk-asert commented on code in PR #2154:
URL: https://github.com/apache/groovy/pull/2154#discussion_r2000136302
##
build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy:
##
@@ -169,16 +168,9 @@ class JarJarTask extends DefaultTask {
it.into(ou
eric-milles commented on PR #2169:
URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764598229
Sorry, "I don't know quite how to represent the extra variable/parameter"
was not intended as a discussion point for the syntax. After the syntax is
parsed, I have to solve the AST re
daniellansun commented on PR #2170:
URL: https://github.com/apache/groovy/pull/2170#issuecomment-2774034073
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eric-milles opened a new pull request, #2176:
URL: https://github.com/apache/groovy/pull/2176
also static modifier for inner `enum`, `trait`, `interface` or `annotation`
-- I checked this behavior against `javac`
--
This is an automated message from the Apache Git Service.
To respond to t
codecov-commenter commented on PR #2176:
URL: https://github.com/apache/groovy/pull/2176#issuecomment-2780153766
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2176?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2174:
URL: https://github.com/apache/groovy/pull/2174#issuecomment-2781399666
It's better not to break existing users' code unless we have to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
daniellansun commented on PR #2178:
URL: https://github.com/apache/groovy/pull/2178#issuecomment-2781403410
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun commented on PR #2177:
URL: https://github.com/apache/groovy/pull/2177#issuecomment-2781402812
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
daniellansun commented on PR #2175:
URL: https://github.com/apache/groovy/pull/2175#issuecomment-2781400547
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
daniellansun commented on PR #2176:
URL: https://github.com/apache/groovy/pull/2176#issuecomment-2781401634
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
codecov-commenter commented on PR #2179:
URL: https://github.com/apache/groovy/pull/2179#issuecomment-2781338250
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2179?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2171:
URL: https://github.com/apache/groovy/pull/2171#issuecomment-2773244779
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2166:
URL: https://github.com/apache/groovy/pull/2166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #2173:
URL: https://github.com/apache/groovy/pull/2173#issuecomment-2776222499
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2173?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2177:
URL: https://github.com/apache/groovy/pull/2177#issuecomment-2780864494
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2177?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2154:
URL: https://github.com/apache/groovy/pull/2154#issuecomment-2741672998
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2154?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert opened a new pull request, #2178:
URL: https://github.com/apache/groovy/pull/2178
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #2178:
URL: https://github.com/apache/groovy/pull/2178#issuecomment-2781139637
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2178?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert merged PR #2173:
URL: https://github.com/apache/groovy/pull/2173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #2178:
URL: https://github.com/apache/groovy/pull/2178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2164:
URL: https://github.com/apache/groovy/pull/2164
Bumps org.sonarqube from 6.0.1.5171 to 6.1.0.5360.
[ if he had
other examples (but he hasn't responded yet).
--
This is an automated message from the Apache Git Service.
To
Vampire opened a new pull request, #2183:
URL: https://github.com/apache/groovy/pull/2183
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
blackdrag commented on PR #2169:
URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764527455
Daniel's variant is very near to what I know from Python:
for idx,data in enumerate(content_list):
print(idx) # will print the index of the loop starting from 0
codecov-commenter commented on PR #2169:
URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764642795
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2169?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2169:
URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764625268
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2169?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
glaforge commented on PR #2169:
URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764532875
I like the Python approach suggested by @blackdrag, it's quite natural (and
certainly familiar for those who have done some Python)
--
This is an automated message from the Apache Git S
eric-milles commented on PR #2169:
URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764610294
I'm going to push just the clean ups as a commit that can be reviewed and
cherry-picked on its own. The `for (int i, var e in x)` makes sense as simple
and understandable. I should b
eric-milles commented on PR #2169:
URL: https://github.com/apache/groovy/pull/2169#issuecomment-2769914844
This is functional enough for an initial review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
roulpriya opened a new pull request, #2171:
URL: https://github.com/apache/groovy/pull/2171
Update SDKMAN URL to include `"https://get.sdkman.io"` as the old link does
not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
codecov-commenter commented on PR #2157:
URL: https://github.com/apache/groovy/pull/2157#issuecomment-2727155703
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2157?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-2727122813
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2156?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles opened a new pull request, #2156:
URL: https://github.com/apache/groovy/pull/2156
For your consideration. Here are the types in `java.time` package:
--
This is an automated me
eric-milles opened a new pull request, #2157:
URL: https://github.com/apache/groovy/pull/2157
I tried to follow `collectMany` in terms of generics. There is no
connection that can be made between the in type and the out type, since
aggregates are recursively processed. And the closure acc
dependabot[bot] opened a new pull request, #2181:
URL: https://github.com/apache/groovy/pull/2181
Bumps com.gradle.develocity from 3.19.2 to 4.0.
[
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #2180:
URL: https://github.com/apache/groovy/pull/2180#issuecomment-2781835701
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2180?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert opened a new pull request, #2185:
URL: https://github.com/apache/groovy/pull/2185
…Put() hang (additional flexibility)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
codecov-commenter commented on PR #2185:
URL: https://github.com/apache/groovy/pull/2185#issuecomment-2796669887
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2185?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2185:
URL: https://github.com/apache/groovy/pull/2185#issuecomment-2796758896
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun merged PR #2185:
URL: https://github.com/apache/groovy/pull/2185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2185:
URL: https://github.com/apache/groovy/pull/2185#issuecomment-2796821747
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on PR #2183:
URL: https://github.com/apache/groovy/pull/2183#issuecomment-2798347431
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2183:
URL: https://github.com/apache/groovy/pull/2183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
paulk-asert commented on code in PR #2172:
URL: https://github.com/apache/groovy/pull/2172#discussion_r2030997973
##
subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/GroovyshTest.groovy:
##
@@ -392,17 +394,34 @@ class GroovyshInterpreterModeTest extends Gro
daniellansun commented on PR #2177:
URL: https://github.com/apache/groovy/pull/2177#issuecomment-2783110797
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on PR #2179:
URL: https://github.com/apache/groovy/pull/2179#issuecomment-2783115859
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun commented on PR #2180:
URL: https://github.com/apache/groovy/pull/2180#issuecomment-2783119773
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
eric-milles commented on PR #2174:
URL: https://github.com/apache/groovy/pull/2174#issuecomment-2783819389
Do you have an example of something that requires this? It is quite costly
to support arbitrary expression list in for loop.
--
This is an automated message from the Apache Git Serv
daniellansun merged PR #2175:
URL: https://github.com/apache/groovy/pull/2175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2175:
URL: https://github.com/apache/groovy/pull/2175#issuecomment-2782867631
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
paulk-asert commented on PR #2199:
URL: https://github.com/apache/groovy/pull/2199#issuecomment-2812980365
> Can you explain the design of this one? I don't quite follow. I think this
plays into the reason we limited the previous fix to STC.
This just applies the previous fix (so only
daniellansun commented on PR #2198:
URL: https://github.com/apache/groovy/pull/2198#issuecomment-2815276579
Out of curiosity, will multiple dimension array be supported too? For
example,
```groovy
String[][] foo() {
[['a','b'], ['c', 'd']]
}
```
--
This is an automa
daniellansun commented on PR #2199:
URL: https://github.com/apache/groovy/pull/2199#issuecomment-2814267260
LGTM.
P.S. It's better to add some marker to limit visiting further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
eric-milles commented on PR #2199:
URL: https://github.com/apache/groovy/pull/2199#issuecomment-2815666933
Is it possible for the switch expression closure to delegate to the enum
class? Would that be safe to do?
--
This is an automated message from the Apache Git Service.
To respond to
eric-milles commented on PR #2198:
URL: https://github.com/apache/groovy/pull/2198#issuecomment-2815638900
It supports whatever the dynamic mode conversion is. I have not tried with
multi-dimensional, but I expect that it works.
--
This is an automated message from the Apache Git Service
daniellansun commented on PR #2186:
URL: https://github.com/apache/groovy/pull/2186#issuecomment-2799588675
> @daniellansun there are already 3 maps/caches in VariableScope. Why are
those no good?
Finding logic will still be triggered for each same variables/class members
in the Vari
daniellansun closed pull request #2186: GROOVY-11609: Avoid finding same
variable/class member repeatedly
URL: https://github.com/apache/groovy/pull/2186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
daniellansun closed pull request #2023: GROOVY-11263: Analyze dead code
URL: https://github.com/apache/groovy/pull/2023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
codecov-commenter commented on PR #2194:
URL: https://github.com/apache/groovy/pull/2194#issuecomment-2804164723
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2194?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2187:
URL: https://github.com/apache/groovy/pull/2187#issuecomment-2804787579
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun merged PR #2194:
URL: https://github.com/apache/groovy/pull/2194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2194:
URL: https://github.com/apache/groovy/pull/2194#issuecomment-2804754579
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eric-milles merged PR #2187:
URL: https://github.com/apache/groovy/pull/2187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on PR #2190:
URL: https://github.com/apache/groovy/pull/2190#issuecomment-2804792888
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
daniellansun commented on PR #2192:
URL: https://github.com/apache/groovy/pull/2192#issuecomment-2804769157
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
eric-milles merged PR #2189:
URL: https://github.com/apache/groovy/pull/2189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
codecov-commenter commented on PR #2195:
URL: https://github.com/apache/groovy/pull/2195#issuecomment-2805473391
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2195?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2195:
URL: https://github.com/apache/groovy/pull/2195#issuecomment-2805693066
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
paulk-asert opened a new pull request, #2199:
URL: https://github.com/apache/groovy/pull/2199
…ified will cause a groovy compile error for switch expressions even with
type checking enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov-commenter commented on PR #2199:
URL: https://github.com/apache/groovy/pull/2199#issuecomment-2811947062
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2199?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
Goooler merged PR #2202:
URL: https://github.com/apache/groovy/pull/2202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
daniellansun commented on PR #2199:
URL: https://github.com/apache/groovy/pull/2199#issuecomment-2817255442
If delegation applied, method calls within switch expression can also be
delegated to enum class. But switch statement treats the method calls as
invalid.
--
This is an automated m
dependabot[bot] opened a new pull request, #2202:
URL: https://github.com/apache/groovy/pull/2202
Bumps
[com.h3xstream.findsecbugs:findsecbugs-plugin](https://github.com/find-sec-bugs/find-sec-bugs)
from 1.13.0 to 1.14.0.
Commits
See full diff in https://github.com/find-sec-bu
901 - 1000 of 1470 matches
Mail list logo
