Re: [PR] Bump org.sonarqube from 5.1.0.4882 to 6.0.1.5171 [groovy]

2024-11-28 Thread via GitHub
daniellansun merged PR #2127: URL: https://github.com/apache/groovy/pull/2127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] Bump org.sonarqube from 5.1.0.4882 to 6.0.1.5171 [groovy]

2024-11-27 Thread via GitHub
dependabot[bot] opened a new pull request, #2127: URL: https://github.com/apache/groovy/pull/2127 Bumps org.sonarqube from 5.1.0.4882 to 6.0.1.5171. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.sonarqube&

Re: [PR] Bump org.sonarqube from 5.1.0.4882 to 6.0.0.5145 [groovy]

2024-11-27 Thread via GitHub
dependabot[bot] closed pull request #2124: Bump org.sonarqube from 5.1.0.4882 to 6.0.0.5145 URL: https://github.com/apache/groovy/pull/2124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Bump org.sonarqube from 5.1.0.4882 to 6.0.0.5145 [groovy]

2024-11-27 Thread via GitHub
dependabot[bot] commented on PR #2124: URL: https://github.com/apache/groovy/pull/2124#issuecomment-2505073205 Superseded by #2127. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump codecov/codecov-action from 4 to 5 [groovy]

2024-11-18 Thread via GitHub
daniellansun merged PR #2123: URL: https://github.com/apache/groovy/pull/2123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] Bump org.sonarqube from 5.1.0.4882 to 6.0.0.5145 [groovy]

2024-11-19 Thread via GitHub
dependabot[bot] opened a new pull request, #2124: URL: https://github.com/apache/groovy/pull/2124 Bumps org.sonarqube from 5.1.0.4882 to 6.0.0.5145. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.sonarqube&

[PR] Bump com.gradle.develocity from 3.18.1 to 3.18.2 [groovy]

2024-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #2122: URL: https://github.com/apache/groovy/pull/2122 Bumps com.gradle.develocity from 3.18.1 to 3.18.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.dev

Re: [PR] Bump com.gradle.develocity from 3.18.1 to 3.18.2 [groovy]

2024-11-13 Thread via GitHub
daniellansun merged PR #2122: URL: https://github.com/apache/groovy/pull/2122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] Bump codecov/codecov-action from 4 to 5 [groovy]

2024-11-17 Thread via GitHub
dependabot[bot] opened a new pull request, #2123: URL: https://github.com/apache/groovy/pull/2123 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. Release notes Sourced from https://github.com/codecov/codecov-action/releases";>codecov/codecov-a

Re: [PR] Bump codecov/codecov-action from 3 to 5 [groovy]

2024-11-25 Thread via GitHub
daniellansun merged PR #2126: URL: https://github.com/apache/groovy/pull/2126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] Bump gradle/wrapper-validation-action from 2 to 3 [groovy]

2024-12-02 Thread via GitHub
daniellansun merged PR #2128: URL: https://github.com/apache/groovy/pull/2128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-10381: No compiler error for class that implements interfaces with duplicated default methods [groovy]

2024-11-25 Thread via GitHub
daniellansun merged PR #2125: URL: https://github.com/apache/groovy/pull/2125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] Bump gradle/wrapper-validation-action from 2 to 3 [groovy]

2024-12-01 Thread via GitHub
dependabot[bot] opened a new pull request, #2128: URL: https://github.com/apache/groovy/pull/2128 Bumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 2 to 3. Release notes Sourced from https://github.com/gradle/wrapper-validation-acti

[PR] Bump org.codehaus.plexus:plexus-utils from 3.0.24 to 4.0.2 [groovy]

2024-12-03 Thread via GitHub
dependabot[bot] opened a new pull request, #2132: URL: https://github.com/apache/groovy/pull/2132 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.0.24 to 4.0.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-ut

[PR] Bump com.jcraft:jsch from 0.1.54 to 0.1.55 [groovy]

2024-12-03 Thread via GitHub
dependabot[bot] opened a new pull request, #2129: URL: https://github.com/apache/groovy/pull/2129 Bumps com.jcraft:jsch from 0.1.54 to 0.1.55. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.jcraft:jsch&pack

[PR] Bump org.apache.ant:ant from 1.10.11 to 1.10.15 [groovy]

2024-12-03 Thread via GitHub
dependabot[bot] opened a new pull request, #2131: URL: https://github.com/apache/groovy/pull/2131 Bumps org.apache.ant:ant from 1.10.11 to 1.10.15. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.ant:

Re: [PR] GROOVY-8283: field hides getter of super class (not interface) [groovy]

2024-12-09 Thread via GitHub
codecov-commenter commented on PR #1767: URL: https://github.com/apache/groovy/pull/1767#issuecomment-2529108767 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/1767?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-8283: field hides getter of super class (not interface) [groovy]

2024-12-09 Thread via GitHub
eric-milles commented on PR #1767: URL: https://github.com/apache/groovy/pull/1767#issuecomment-2528805577 For circumstances that go through `ScriptBytecodeAdapter`, the sender class is not propagated to `MetaClassImpl`. Access checks give different results, since the sender is re-mapped t

Re: [PR] GROOVY-11539: float variants for min/max in ArrayGroovyMethods [groovy]

2025-01-01 Thread via GitHub
paulk-asert merged PR #2137: URL: https://github.com/apache/groovy/pull/2137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11566: Bump asm to 9.7.1 in Groovy 3 [groovy]

2025-02-06 Thread via GitHub
paulk-asert merged PR #2150: URL: https://github.com/apache/groovy/pull/2150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-02-12 Thread via GitHub
paulk-asert commented on PR #2141: URL: https://github.com/apache/groovy/pull/2141#issuecomment-2653788265 Noted. Thanks. I'm away for a couple of days but will fix when I return unless someone beats me to it. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-02-12 Thread via GitHub
clayburn commented on PR #2141: URL: https://github.com/apache/groovy/pull/2141#issuecomment-2653769638 @paulk-asert / @daniellansun - note that ge.apache.org is scheduled to be decommissioned this week, yet the GROOVY_4_0_X branch has not picked up this change and is still publishing Buil

Re: [PR] GROOVY-11563: STC: check compound assignment `x op= y` like `x = x op y` [groovy]

2025-02-02 Thread via GitHub
codecov-commenter commented on PR #2148: URL: https://github.com/apache/groovy/pull/2148#issuecomment-2629557141 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2148?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] web: style guide: small language improvements [groovy]

2025-02-02 Thread via GitHub
paulk-asert commented on PR #2149: URL: https://github.com/apache/groovy/pull/2149#issuecomment-2629638808 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] web: style guide: small language improvements [groovy]

2025-02-02 Thread via GitHub
paulk-asert merged PR #2149: URL: https://github.com/apache/groovy/pull/2149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] improve explanation of `var` [groovy]

2024-12-10 Thread via GitHub
daniellansun commented on PR #2133: URL: https://github.com/apache/groovy/pull/2133#issuecomment-2533568558 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] GROOVY-8283: field hides getter of super class (not interface) [groovy]

2024-12-09 Thread via GitHub
codecov-commenter commented on PR #1767: URL: https://github.com/apache/groovy/pull/1767#issuecomment-2530651240 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/1767?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] improve explanation of `var` [groovy]

2024-12-10 Thread via GitHub
paulk-asert opened a new pull request, #2133: URL: https://github.com/apache/groovy/pull/2133 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] improve explanation of `var` [groovy]

2024-12-10 Thread via GitHub
codecov-commenter commented on PR #2133: URL: https://github.com/apache/groovy/pull/2133#issuecomment-2533434323 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2133?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] Bump com.gradle.develocity from 3.18.2 to 3.19 [groovy]

2024-12-15 Thread via GitHub
dependabot[bot] opened a new pull request, #2135: URL: https://github.com/apache/groovy/pull/2135 Bumps com.gradle.develocity from 3.18.2 to 3.19. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.devel

Re: [PR] Bump com.gradle.develocity from 3.18.2 to 3.19 [groovy]

2024-12-16 Thread via GitHub
paulk-asert closed pull request #2135: Bump com.gradle.develocity from 3.18.2 to 3.19 URL: https://github.com/apache/groovy/pull/2135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Bump com.gradle.develocity from 3.18.2 to 3.19 [groovy]

2024-12-16 Thread via GitHub
dependabot[bot] commented on PR #2135: URL: https://github.com/apache/groovy/pull/2135#issuecomment-2545340896 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.gradle.develocity from 3.18.2 to 3.19 [groovy]

2024-12-16 Thread via GitHub
paulk-asert commented on PR #2135: URL: https://github.com/apache/groovy/pull/2135#issuecomment-2545340820 Still waiting for the server to be upgraded first: https://ge.apache.org/scans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Bump com.gradle.develocity from 3.18.2 to 3.19 [groovy]

2024-12-12 Thread via GitHub
dependabot[bot] opened a new pull request, #2134: URL: https://github.com/apache/groovy/pull/2134 Bumps com.gradle.develocity from 3.18.2 to 3.19. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.devel

Re: [PR] Bump com.gradle.develocity from 3.18.2 to 3.19 [groovy]

2024-12-12 Thread via GitHub
daniellansun merged PR #2134: URL: https://github.com/apache/groovy/pull/2134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] improve explanation of `var` [groovy]

2024-12-12 Thread via GitHub
daniellansun merged PR #2133: URL: https://github.com/apache/groovy/pull/2133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] improve explanation of `var` [groovy]

2024-12-12 Thread via GitHub
daniellansun commented on PR #2133: URL: https://github.com/apache/groovy/pull/2133#issuecomment-2540515211 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-11190: Jakarta EE 9 compatibility for groovy-servlet [groovy]

2024-12-19 Thread via GitHub
codecov-commenter commented on PR #2136: URL: https://github.com/apache/groovy/pull/2136#issuecomment-2554501476 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2136?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11190: Jakarta EE 9 compatibility for groovy-servlet [groovy]

2024-12-20 Thread via GitHub
daniellansun merged PR #2136: URL: https://github.com/apache/groovy/pull/2136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11190: Jakarta EE 9 compatibility for groovy-servlet [groovy]

2024-12-20 Thread via GitHub
daniellansun commented on PR #2136: URL: https://github.com/apache/groovy/pull/2136#issuecomment-2557145191 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-11190: Jakarta EE 9 compatibility for groovy-servlet [groovy]

2024-12-20 Thread via GitHub
daniellansun commented on PR #2136: URL: https://github.com/apache/groovy/pull/2136#issuecomment-2556850920 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.0.24 to 4.0.2 [groovy]

2024-12-03 Thread via GitHub
daniellansun merged PR #2132: URL: https://github.com/apache/groovy/pull/2132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] Bump com.jcraft:jsch from 0.1.54 to 0.1.55 [groovy]

2024-12-03 Thread via GitHub
daniellansun merged PR #2129: URL: https://github.com/apache/groovy/pull/2129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] Bump commons-io:commons-io from 2.16.1 to 2.18.0 [groovy]

2024-12-03 Thread via GitHub
dependabot[bot] commented on PR #2130: URL: https://github.com/apache/groovy/pull/2130#issuecomment-2516152583 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump commons-io:commons-io from 2.16.1 to 2.18.0 [groovy]

2024-12-03 Thread via GitHub
daniellansun closed pull request #2130: Bump commons-io:commons-io from 2.16.1 to 2.18.0 URL: https://github.com/apache/groovy/pull/2130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.apache.ant:ant from 1.10.11 to 1.10.15 [groovy]

2024-12-03 Thread via GitHub
daniellansun merged PR #2131: URL: https://github.com/apache/groovy/pull/2131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] Bump commons-io:commons-io from 2.16.1 to 2.18.0 [groovy]

2024-12-03 Thread via GitHub
dependabot[bot] opened a new pull request, #2130: URL: https://github.com/apache/groovy/pull/2130 Bumps commons-io:commons-io from 2.16.1 to 2.18.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-io:com

Re: [PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 2.0.2 to 2.1 [groovy]

2025-01-23 Thread via GitHub
paulk-asert merged PR #2143: URL: https://github.com/apache/groovy/pull/2143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] Bump com.github.ben-manes.versions from 0.51.0 to 0.52.0 [groovy]

2025-01-23 Thread via GitHub
paulk-asert merged PR #2144: URL: https://github.com/apache/groovy/pull/2144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] Bump com.github.ben-manes.versions from 0.51.0 to 0.52.0 [groovy]

2025-01-23 Thread via GitHub
dependabot[bot] opened a new pull request, #2144: URL: https://github.com/apache/groovy/pull/2144 Bumps com.github.ben-manes.versions from 0.51.0 to 0.52.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gi

[PR] Bump com.gradle.develocity from 3.18.2 to 3.19.1 [groovy]

2025-01-23 Thread via GitHub
dependabot[bot] opened a new pull request, #2145: URL: https://github.com/apache/groovy/pull/2145 Bumps com.gradle.develocity from 3.18.2 to 3.19.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.dev

Re: [PR] Bump com.gradle.develocity from 3.18.2 to 3.19.1 [groovy]

2025-01-24 Thread via GitHub
dependabot[bot] commented on PR #2145: URL: https://github.com/apache/groovy/pull/2145#issuecomment-2613810631 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.gradle.develocity from 3.18.2 to 3.19.1 [groovy]

2025-01-24 Thread via GitHub
paulk-asert closed pull request #2145: Bump com.gradle.develocity from 3.18.2 to 3.19.1 URL: https://github.com/apache/groovy/pull/2145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] GROOVY-11560: Invalid compiler error for class which overrides a meth… [groovy]

2025-01-24 Thread via GitHub
codecov-commenter commented on PR #2146: URL: https://github.com/apache/groovy/pull/2146#issuecomment-2613787951 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2146?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11560: Invalid compiler error for class which overrides a meth… [groovy]

2025-01-24 Thread via GitHub
daniellansun commented on PR #2146: URL: https://github.com/apache/groovy/pull/2146#issuecomment-2613790581 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] GROOVY-11559: fix `addAllInterfaces` for `UnionTypeClassNode` [groovy]

2025-01-26 Thread via GitHub
codecov-commenter commented on PR #2147: URL: https://github.com/apache/groovy/pull/2147#issuecomment-2614615351 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2147?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11560: Invalid compiler error for class which overrides a meth… [groovy]

2025-01-27 Thread via GitHub
eric-milles merged PR #2146: URL: https://github.com/apache/groovy/pull/2146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 2.0.2 to 2.1 [groovy]

2025-01-21 Thread via GitHub
dependabot[bot] opened a new pull request, #2143: URL: https://github.com/apache/groovy/pull/2143 Bumps com.gradle.common-custom-user-data-gradle-plugin from 2.0.2 to 2.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?depende

Re: [PR] GROOVY-11540: Provide sum variants in ArrayGroovyMethods which take a… [groovy]

2025-01-02 Thread via GitHub
paulk-asert merged PR #2138: URL: https://github.com/apache/groovy/pull/2138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] GROOVY-11541: Sql wildcard params [groovy]

2025-01-03 Thread via GitHub
seregamorph opened a new pull request, #2139: URL: https://github.com/apache/groovy/pull/2139 `groovy.sql.Sql` declares several methods with SQL statement and parameters like this ```java public boolean execute(String sql, List params) throws SLQException { ``` This declarati

Re: [PR] GROOVY-11541: Sql wildcard params [groovy]

2025-01-03 Thread via GitHub
seregamorph commented on PR #2139: URL: https://github.com/apache/groovy/pull/2139#issuecomment-2569083590 The build is broken, but doesn't seem related as master branch is also broken: https://github.com/apache/groovy/actions/runs/12586627965/job/35088979045 -- This is an automated mess

Re: [PR] GROOVY-11541: Sql wildcard params [groovy]

2025-01-03 Thread via GitHub
daniellansun commented on PR #2139: URL: https://github.com/apache/groovy/pull/2139#issuecomment-2569263159 LGTM. No worries. JDK 13 and 18 builds fail due to timeout unaccountably someday, it is tricky for us too. -- This is an automated message from the Apache Git Service. To

Re: [PR] GROOVY-11541: Sql wildcard params [groovy]

2025-01-03 Thread via GitHub
daniellansun commented on PR #2139: URL: https://github.com/apache/groovy/pull/2139#issuecomment-2569262506 LGTM. No worries. JDK 13 and 18 build fails due to timeout unaccountably someday, it is tricky for us too. -- This is an automated message from the Apache Git Service. To

Re: [PR] GROOVY-11541: Sql wildcard params [groovy]

2025-01-03 Thread via GitHub
codecov-commenter commented on PR #2139: URL: https://github.com/apache/groovy/pull/2139#issuecomment-2569024772 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2139?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] GROOVY-11539: float variants for min/max in ArrayGroovyMethods [groovy]

2025-01-01 Thread via GitHub
paulk-asert opened a new pull request, #2137: URL: https://github.com/apache/groovy/pull/2137 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] GROOVY-11539: float variants for min/max in ArrayGroovyMethods [groovy]

2025-01-01 Thread via GitHub
codecov-commenter commented on PR #2137: URL: https://github.com/apache/groovy/pull/2137#issuecomment-2567176653 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2137?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] GROOVY-11540: Provide sum variants in ArrayGroovyMethods which take a… [groovy]

2025-01-01 Thread via GitHub
paulk-asert opened a new pull request, #2138: URL: https://github.com/apache/groovy/pull/2138 … unary operator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] GROOVY-11540: Provide sum variants in ArrayGroovyMethods which take a… [groovy]

2025-01-01 Thread via GitHub
codecov-commenter commented on PR #2138: URL: https://github.com/apache/groovy/pull/2138#issuecomment-2567180821 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2138?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11539: float variants for min/max in ArrayGroovyMethods [groovy]

2025-01-01 Thread via GitHub
daniellansun commented on PR #2137: URL: https://github.com/apache/groovy/pull/2137#issuecomment-2567189303 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] GROOVY-11540: Provide sum variants in ArrayGroovyMethods which take a… [groovy]

2025-01-01 Thread via GitHub
daniellansun commented on PR #2138: URL: https://github.com/apache/groovy/pull/2138#issuecomment-2567189122 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] GROOVY-11541: Sql wildcard params [groovy]

2025-01-04 Thread via GitHub
daniellansun commented on PR #2139: URL: https://github.com/apache/groovy/pull/2139#issuecomment-2570690820 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-11541: Sql wildcard params [groovy]

2025-01-04 Thread via GitHub
daniellansun merged PR #2139: URL: https://github.com/apache/groovy/pull/2139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] Publish build scans to develocity.apache.org [groovy]

2025-01-14 Thread via GitHub
clayburn opened a new pull request, #2141: URL: https://github.com/apache/groovy/pull/2141 This PR migrates the Groovy project to publish Build Scans to the the new Develocity instance at develocity.apache.org. Additionally, this PR sets a projectId for use by Develocity. -- This i

Re: [PR] [GROOVY-7407] Compilation not thread safe if Grape / Ivy is used in Groovy scripts [groovy]

2025-01-14 Thread via GitHub
codecov-commenter commented on PR #2142: URL: https://github.com/apache/groovy/pull/2142#issuecomment-2591404849 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2142?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-01-15 Thread via GitHub
daniellansun commented on PR #2141: URL: https://github.com/apache/groovy/pull/2141#issuecomment-2594175108 LGTM. But I can't find the result of publishing in the build log, e.g. Publishing build scan... https://ge.apache.org/s/npb3qc5clkarg -- This is an automated message fr

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-01-16 Thread via GitHub
clayburn commented on PR #2141: URL: https://github.com/apache/groovy/pull/2141#issuecomment-2595564875 See [here](https://github.com/apache/groovy-geb/pull/244) for a similar case - essentially my PR from a fork cannot see the secret. Post-merge, builds from apache/groovy will be able to s

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-01-16 Thread via GitHub
paulk-asert commented on PR #2141: URL: https://github.com/apache/groovy/pull/2141#issuecomment-2595771733 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-01-16 Thread via GitHub
daniellansun commented on PR #2141: URL: https://github.com/apache/groovy/pull/2141#issuecomment-2595771829 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-01-16 Thread via GitHub
daniellansun merged PR #2141: URL: https://github.com/apache/groovy/pull/2141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-01-14 Thread via GitHub
codecov-commenter commented on PR #2141: URL: https://github.com/apache/groovy/pull/2141#issuecomment-2591272269 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2141?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] [GROOVY-7407] Compilation not thread safe if Grape / Ivy is used in Groovy scripts [groovy]

2025-01-16 Thread via GitHub
daniellansun commented on PR #2142: URL: https://github.com/apache/groovy/pull/2142#issuecomment-2597144123 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [GROOVY-7407] Compilation not thread safe if Grape / Ivy is used in Groovy scripts [groovy]

2025-01-16 Thread via GitHub
daniellansun merged PR #2142: URL: https://github.com/apache/groovy/pull/2142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11562: `final` modifier of `MetaBeanProperty` [groovy]

2025-02-14 Thread via GitHub
eric-milles merged PR #2151: URL: https://github.com/apache/groovy/pull/2151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11559: fix `addAllInterfaces` for `UnionTypeClassNode` [groovy]

2025-02-09 Thread via GitHub
eric-milles merged PR #2147: URL: https://github.com/apache/groovy/pull/2147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] GROOVY-11562: `final` modifier of `MetaBeanProperty` [groovy]

2025-02-09 Thread via GitHub
eric-milles opened a new pull request, #2151: URL: https://github.com/apache/groovy/pull/2151 Take `final` modifier from lack of setter and field's `final` state. This is potentially breaking because `final`, `native`, `strictfp`, `synchronized` and `volatile` are not propagated. I don't

Re: [PR] GROOVY-11562: `final` modifier of `MetaBeanProperty` [groovy]

2025-02-09 Thread via GitHub
codecov-commenter commented on PR #2151: URL: https://github.com/apache/groovy/pull/2151#issuecomment-2646436006 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2151?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11569: Create a sprintf shortcut for 1-arg usage [groovy]

2025-02-16 Thread via GitHub
eric-milles commented on PR #2152: URL: https://github.com/apache/groovy/pull/2152#issuecomment-2661840048 I understand the use case. But the existing `sprintf` extensions don't work this way. Adding a variant with much different usage is a problem IMO. We're only saving a few chars vers

Re: [PR] GROOVY-11569: Create a sprintf shortcut for 1-arg usage [groovy]

2025-02-15 Thread via GitHub
eric-milles commented on PR #2152: URL: https://github.com/apache/groovy/pull/2152#issuecomment-2661095547 The other 2 `sprintf` extensions don't make use of the "self" parameter. It is confusing to add one that passes self along as the arg. It almost makes more sense to add a `toString(S

Re: [PR] GROOVY-11563: STC: check compound assignment `x op= y` like `x = x op y` [groovy]

2025-02-16 Thread via GitHub
eric-milles merged PR #2148: URL: https://github.com/apache/groovy/pull/2148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11569: Create a sprintf shortcut for 1-arg usage [groovy]

2025-02-15 Thread via GitHub
paulk-asert commented on PR #2152: URL: https://github.com/apache/groovy/pull/2152#issuecomment-2661163902 It is very useful to have a variant that can be used in conjunction with the spread-dot operator. ``` def nums = (2..7).collect{ 1/it } assert nums*.sprintf('%.2f') == ['0.

Re: [PR] GROOVY-11569: Create a sprintf shortcut for 1-arg usage [groovy]

2025-02-16 Thread via GitHub
paulk-asert closed pull request #2152: GROOVY-11569: Create a sprintf shortcut for 1-arg usage URL: https://github.com/apache/groovy/pull/2152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] GROOVY-11569: Create a sprintf shortcut for 1-arg usage [groovy]

2025-02-16 Thread via GitHub
paulk-asert commented on PR #2152: URL: https://github.com/apache/groovy/pull/2152#issuecomment-2661947443 Actually, I just remembered String::formatted. It allows: ``` def nums = (2..7).collect { 1 / it } assert nums.collect('%.2f'::formatted) == ['0.50', '0.33', '0.25', '0.20',

Re: [PR] GROOVY-11569: Create a sprintf shortcut for 1-arg usage [groovy]

2025-02-14 Thread via GitHub
codecov-commenter commented on PR #2152: URL: https://github.com/apache/groovy/pull/2152#issuecomment-2660773819 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2152?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] build(console): move `groovy-swing` to API scope [groovy]

2025-03-23 Thread via GitHub
paulk-asert commented on PR #2163: URL: https://github.com/apache/groovy/pull/2163#issuecomment-2746166373 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] build(console): move `groovy-swing` to API scope [groovy]

2025-03-23 Thread via GitHub
paulk-asert merged PR #2163: URL: https://github.com/apache/groovy/pull/2163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] build(console): move `groovy-swing` to API scope [groovy]

2025-03-23 Thread via GitHub
codecov-commenter commented on PR #2163: URL: https://github.com/apache/groovy/pull/2163#issuecomment-2746159339 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2163?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] remove excess manifest attributes [groovy]

2025-03-22 Thread via GitHub
paulk-asert commented on PR #2154: URL: https://github.com/apache/groovy/pull/2154#issuecomment-2740381173 I merged in the "pre-work" and minor refactoring. Do you want to rebase this against master? Should reduce to just a few lines. -- This is an automated message from the Apache Git Se

Re: [PR] build(console): move `groovy-swing` to API scope [groovy]

2025-03-23 Thread via GitHub
matrei commented on PR #2162: URL: https://github.com/apache/groovy/pull/2162#issuecomment-2746146885 Will create PR against master branch instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] build(console): move `groovy-swing` to API scope [groovy]

2025-03-23 Thread via GitHub
matrei closed pull request #2162: build(console): move `groovy-swing` to API scope URL: https://github.com/apache/groovy/pull/2162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Gradle 8.13 [groovy]

2025-03-21 Thread via GitHub
paulk-asert commented on PR #2160: URL: https://github.com/apache/groovy/pull/2160#issuecomment-2744606054 For 24 support, we could use toolchains for main source (would need some work in the build files). For the CI tests, we can use the `-Ptarget.java.home` property as per existing `ea` s

<    4   5   6   7   8   9   10   11   12   13   >