daniellansun commented on PR #1994:
URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826414813
Closed. I misunderstood the usage of draft pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
codecov-commenter commented on PR #1995:
URL: https://github.com/apache/groovy/pull/1995#issuecomment-1826461358
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/1995?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
keeganwitt merged PR #1995:
URL: https://github.com/apache/groovy/pull/1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@gr
keeganwitt merged PR #1996:
URL: https://github.com/apache/groovy/pull/1996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@gr
keeganwitt merged PR #1992:
URL: https://github.com/apache/groovy/pull/1992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@gr
keeganwitt merged PR #1976:
URL: https://github.com/apache/groovy/pull/1976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@gr
keeganwitt merged PR #1977:
URL: https://github.com/apache/groovy/pull/1977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@gr
daniellansun commented on PR #1997:
URL: https://github.com/apache/groovy/pull/1997#issuecomment-1826790758
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
eric-milles commented on PR #1997:
URL: https://github.com/apache/groovy/pull/1997#issuecomment-1826862454
Now `private` methods are supported in interfaces. Are `static` also
supported? It was less clear from the changes if this is the case. Also, are
there tests for `protected` and `@P
eric-milles commented on PR #1997:
URL: https://github.com/apache/groovy/pull/1997#issuecomment-1826873641
Something is missing in the stub generator, because when I try to add a
static method to a groovy interface, it states that the java implementer needs
to implement the abstract method.
eric-milles commented on PR #1997:
URL: https://github.com/apache/groovy/pull/1997#issuecomment-1826876769
@blackdrag @paulk-asert I was able to implement a groovy `interface` with
both `default` and `private` methods in it using a java `class` (test case
above). Very encouraging progress
paulk-asert commented on PR #1997:
URL: https://github.com/apache/groovy/pull/1997#issuecomment-1826880815
Yes, statics are still a work in progress. The `InterfaceName.this.method()`
is a hook to allow us to hardcode the interface as receiver.
--
This is an automated message from the Apa
paulk-asert commented on PR #1997:
URL: https://github.com/apache/groovy/pull/1997#issuecomment-1826883479
I'll split the issue up since I don't think I will get static finished for
alpha-3. There is still some more testing and doco to come too.
--
This is an automated message from the Ap
paulk-asert closed pull request #1997: GROOVY-10060: Support static & private
interface methods
URL: https://github.com/apache/groovy/pull/1997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
paulk-asert commented on PR #1997:
URL: https://github.com/apache/groovy/pull/1997#issuecomment-1826883539
Merged the private methods commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #1998:
URL: https://github.com/apache/groovy/pull/1998
Bumps
[com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin)
from 5.2.3 to 5.2.4.
Release notes
Sourced from https://github.com/spotbugs
daniellansun commented on PR #1999:
URL: https://github.com/apache/groovy/pull/1999#issuecomment-1827717571
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
keeganwitt opened a new pull request, #2000:
URL: https://github.com/apache/groovy/pull/2000
Instead of skipping the GROOVY-9962 test (as introduced in #1995), we can
use a different annotation that accepts a value in Java 8.
--
This is an automated message from the Apache Git Service.
To
codecov-commenter commented on PR #2000:
URL: https://github.com/apache/groovy/pull/2000#issuecomment-1828304937
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
paulk-asert merged PR #2000:
URL: https://github.com/apache/groovy/pull/2000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles closed pull request #1482: GROOVY-9801: Print default on interface
methods with default implementation
URL: https://github.com/apache/groovy/pull/1482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
eric-milles closed pull request #1560: GROOVY-9017 DGM methods
URL: https://github.com/apache/groovy/pull/1560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
eric-milles closed pull request #1602: GROOVY-,GROOVY-8488:STC:make decimal
literal parameter can auto c…
URL: https://github.com/apache/groovy/pull/1602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
daniellansun commented on code in PR #1999:
URL: https://github.com/apache/groovy/pull/1999#discussion_r1406945262
##
src/antlr/GroovyParser.g4:
##
@@ -848,6 +848,9 @@ expression
// logical or (||) (level 13)
| left=expression nls op=OR nls right=expression
daniellansun commented on code in PR #1999:
URL: https://github.com/apache/groovy/pull/1999#discussion_r1406945262
##
src/antlr/GroovyParser.g4:
##
@@ -848,6 +848,9 @@ expression
// logical or (||) (level 13)
| left=expression nls op=OR nls right=expression
Goooler merged PR #1998:
URL: https://github.com/apache/groovy/pull/1998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
paulk-asert commented on code in PR #1999:
URL: https://github.com/apache/groovy/pull/1999#discussion_r1407059329
##
src/antlr/GroovyParser.g4:
##
@@ -848,6 +848,9 @@ expression
// logical or (||) (level 13)
| left=expression nls op=OR nls right=expression
paulk-asert opened a new pull request, #2001:
URL: https://github.com/apache/groovy/pull/2001
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
daniellansun commented on code in PR #1999:
URL: https://github.com/apache/groovy/pull/1999#discussion_r1407754977
##
src/antlr/GroovyParser.g4:
##
@@ -848,6 +848,9 @@ expression
// logical or (||) (level 13)
| left=expression nls op=OR nls right=expression
eric-milles commented on code in PR #2001:
URL: https://github.com/apache/groovy/pull/2001#discussion_r1408404532
##
src/test/groovy/InterfaceTest.groovy:
##
@@ -91,4 +91,19 @@ final class InterfaceTest extends CompilableTestSupport {
assert impl2.foo() == 'hello fr
eric-milles commented on PR #2001:
URL: https://github.com/apache/groovy/pull/2001#issuecomment-1830732529
With static method support so close at hand, did you think of re-rolling
5.0.0-alpha-3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
eric-milles commented on PR #2001:
URL: https://github.com/apache/groovy/pull/2001#issuecomment-1830768443
I have all these changes together locally if you'd like me to push a branch
or commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
paulk-asert merged PR #1999:
URL: https://github.com/apache/groovy/pull/1999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #2001:
URL: https://github.com/apache/groovy/pull/2001#issuecomment-1831026189
> With static method support so close at hand, did you think of re-rolling
5.0.0-alpha-3?
Let's go with the current release and shoot for another before the end of
the year.
-
paulk-asert commented on code in PR #2001:
URL: https://github.com/apache/groovy/pull/2001#discussion_r1408618851
##
src/main/java/org/codehaus/groovy/classgen/ClassCompletionVerifier.java:
##
@@ -418,10 +418,6 @@ private void checkMethodsForIncorrectModifiers(final
ClassNode c
paulk-asert commented on code in PR #2001:
URL: https://github.com/apache/groovy/pull/2001#discussion_r1408619048
##
src/main/java/org/codehaus/groovy/classgen/ClassCompletionVerifier.java:
##
@@ -418,10 +418,6 @@ private void checkMethodsForIncorrectModifiers(final
ClassNode c
paulk-asert commented on code in PR #2001:
URL: https://github.com/apache/groovy/pull/2001#discussion_r1408619139
##
src/test/groovy/InterfaceTest.groovy:
##
@@ -91,4 +91,19 @@ final class InterfaceTest extends CompilableTestSupport {
assert impl2.foo() == 'hello fr
paulk-asert commented on PR #2001:
URL: https://github.com/apache/groovy/pull/2001#issuecomment-1831068762
> I have all these changes together locally if you'd like me to push a
branch or commit.
I've included some of them with tweaks. I'll merge when ready but feel free
to amend fur
paulk-asert merged PR #2001:
URL: https://github.com/apache/groovy/pull/2001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2003:
URL: https://github.com/apache/groovy/pull/2003
Bumps
[com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin)
from 5.2.4 to 5.2.5.
Release notes
Sourced from https://github.com/spotbugs
Goooler merged PR #2003:
URL: https://github.com/apache/groovy/pull/2003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
Goooler opened a new pull request, #2004:
URL: https://github.com/apache/groovy/pull/2004
I'm enabling @renovate-bot in my fork, it would send dep updates more
efficiently than @dependabot. I'll create updates from it if we can accept.
https://docs.renovatebot.com
--
This is an aut
Goooler commented on PR #2004:
URL: https://github.com/apache/groovy/pull/2004#issuecomment-1834305786
Let me know if there is any legal or copyright issue to prevent us from
doing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
daniellansun merged PR #2002:
URL: https://github.com/apache/groovy/pull/2002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2004:
URL: https://github.com/apache/groovy/pull/2004#issuecomment-1836527375
I'm not sure how you set the token.
```
1. Set your PAT as a token in your config.js file
2. Set your PAT as an environment variable RENOVATE_TOKEN
3. Set your PAT when
Goooler commented on PR #2004:
URL: https://github.com/apache/groovy/pull/2004#issuecomment-1836546235
I'm planning to send Renovate updates manually, I'll view their docs later
for looking if there is any automatically way.
--
This is an automated message from the Apache Git Service.
To
Goooler commented on PR #2004:
URL: https://github.com/apache/groovy/pull/2004#issuecomment-1837441972
I didn't find any docs mentioning how to let @renovate-bot send PRs to the
upstream repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
dependabot[bot] opened a new pull request, #2005:
URL: https://github.com/apache/groovy/pull/2005
Bumps
[com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin)
from 5.2.5 to 6.0.1.
Release notes
Sourced from https://github.com/spotbugs
dependabot[bot] opened a new pull request, #2006:
URL: https://github.com/apache/groovy/pull/2006
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to
4.
Release notes
Sourced from https://github.com/actions/setup-java/releases";>actions/setup-java's
release
Goooler merged PR #2006:
URL: https://github.com/apache/groovy/pull/2006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
Goooler merged PR #2005:
URL: https://github.com/apache/groovy/pull/2005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
dependabot[bot] opened a new pull request, #2007:
URL: https://github.com/apache/groovy/pull/2007
Bumps
[com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin)
from 6.0.1 to 6.0.2.
Release notes
Sourced from https://github.com/spotbugs
Goooler merged PR #2007:
URL: https://github.com/apache/groovy/pull/2007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
dependabot[bot] opened a new pull request, #2008:
URL: https://github.com/apache/groovy/pull/2008
Bumps com.gradle.enterprise from 3.13 to 3.16.
[
from 5.1.11 to 5.1.12.
Release notes
Sourced from https://github.com/jfrog/
paulk-asert merged PR #1974:
URL: https://github.com/apache/groovy/pull/1974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #2011:
URL: https://github.com/apache/groovy/pull/2011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2012:
URL: https://github.com/apache/groovy/pull/2012
Bumps com.gradle.enterprise from 3.15 to 3.16.1.
[.
--
This is an automated message from the Apache Git S
eric-milles commented on PR #1767:
URL: https://github.com/apache/groovy/pull/1767#issuecomment-2444229021
@blackdrag @paulk-asert If I refresh the branch, do you think this is
viable? The test case should illustrate the new hiding behavior.
--
This is an automated message from the Apach
GianniGiglio commented on PR #2112:
URL: https://github.com/apache/groovy/pull/2112#issuecomment-2435613155
Hi are there any plans to backport this to groovy 4 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
codecov-commenter commented on PR #2118:
URL: https://github.com/apache/groovy/pull/2118#issuecomment-2453339239
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2118?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles commented on PR #2117:
URL: https://github.com/apache/groovy/pull/2117#issuecomment-2438278862
I relaxed from an error to a warning for traits:
https://github.com/apache/groovy/commit/9d0d67197eb8cd333e973b08d4d0f4b7f3f41475
--
This is an automated message from the Apac
eric-milles closed pull request #2117: GROOVY-11508: change exception to
detailed warning
URL: https://github.com/apache/groovy/pull/2117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
eric-milles commented on PR #2117:
URL: https://github.com/apache/groovy/pull/2117#issuecomment-2438361044
This should stop the errors for `Entity` and `GormEntity`. However, you may
still get an error for the interface `GormEntityApi` per your example. You can
try out the snapshot build
paulk-asert commented on PR #2119:
URL: https://github.com/apache/groovy/pull/2119#issuecomment-2466026939
Thanks for spotting those. I suspect they might have worked as is on a very
old version of Asciidoc. In any case, I think the sentence could be made
clearer without the pluralization o
paulk-asert merged PR #2119:
URL: https://github.com/apache/groovy/pull/2119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
fanofxiaofeng commented on PR #2119:
URL: https://github.com/apache/groovy/pull/2119#issuecomment-2466028323
OK, thanks for the details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
codecov-commenter commented on PR #2119:
URL: https://github.com/apache/groovy/pull/2119#issuecomment-2466029908
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2119?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
fanofxiaofeng opened a new pull request, #2119:
URL: https://github.com/apache/groovy/pull/2119
As mentioned in Example 6 in
https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#text-formatting,
two consecutive "`" character can be used to render unconstrained italic (I
paulk-asert commented on code in PR #2119:
URL: https://github.com/apache/groovy/pull/2119#discussion_r1835235874
##
src/spec/doc/style-guide.adoc:
##
@@ -622,7 +622,7 @@ and the resulting value will be null if something's `null`.
To check your parameters, your return values,
daniellansun merged PR #2120:
URL: https://github.com/apache/groovy/pull/2120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
eric-milles merged PR #2121:
URL: https://github.com/apache/groovy/pull/2121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on code in PR #2119:
URL: https://github.com/apache/groovy/pull/2119#discussion_r1835235874
##
src/spec/doc/style-guide.adoc:
##
@@ -622,7 +622,7 @@ and the resulting value will be null if something's `null`.
To check your parameters, your return values,
paulk-asert commented on code in PR #2119:
URL: https://github.com/apache/groovy/pull/2119#discussion_r1835235507
##
src/spec/doc/style-guide.adoc:
##
@@ -622,7 +622,7 @@ and the resulting value will be null if something's `null`.
To check your parameters, your return values,
Alchemik opened a new pull request, #2115:
URL: https://github.com/apache/groovy/pull/2115
Fixed dead link to IntelliJ IDEA > Groovy docs
--
This is an automated message from the Apache Git Se
daniellansun commented on PR #2115:
URL: https://github.com/apache/groovy/pull/2115#issuecomment-2369640676
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2115:
URL: https://github.com/apache/groovy/pull/2115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #2113:
URL: https://github.com/apache/groovy/pull/2113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2114:
URL: https://github.com/apache/groovy/pull/2114#issuecomment-2357049981
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun merged PR #2114:
URL: https://github.com/apache/groovy/pull/2114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2114:
URL: https://github.com/apache/groovy/pull/2114#issuecomment-2358929734
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jamesfredley commented on PR #2117:
URL: https://github.com/apache/groovy/pull/2117#issuecomment-2438428975
@eric-milles Thank you for the quick turnaround. We converted
`GormEntityApi` to a `Trait` and are able to move forward.
https://github.com/grails/grails-data-mapping/pull/1834
dependabot[bot] opened a new pull request, #2126:
URL: https://github.com/apache/groovy/pull/2126
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action)
from 3 to 5.
Release notes
Sourced from https://github.com/codecov/codecov-action/releases";>codecov/codecov-a
701 - 800 of 1478 matches
Mail list logo
