[GitHub] [groovy] paulk-asert commented on pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder

2023-09-07 Thread via GitHub
paulk-asert commented on PR #1867: URL: https://github.com/apache/groovy/pull/1867#issuecomment-1711059289 > The underscore (_) is used in groovy.cli.commons.CommandLineInterface when there is no shortDesc . I THINK this is the same usage(???) > > ex. > > ``` >

[GitHub] [groovy] orubel commented on pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder

2023-09-08 Thread via GitHub
orubel commented on PR #1867: URL: https://github.com/apache/groovy/pull/1867#issuecomment-1712051390 @paulk-asert > There are two separate method call expressions with name `_` in your example. AFAIK this is following the example (works great anyway) to set it so that only

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1951: Bump actions/checkout from 3 to 4

2023-09-10 Thread via GitHub
dependabot[bot] opened a new pull request, #1951: URL: https://github.com/apache/groovy/pull/1951 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases.

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1952: Bump com.gradle.common-custom-user-data-gradle-plugin from 1.11.1 to 1.11.2

2023-09-10 Thread via GitHub
dependabot[bot] opened a new pull request, #1952: URL: https://github.com/apache/groovy/pull/1952 Bumps com.gradle.common-custom-user-data-gradle-plugin from 1.11.1 to 1.11.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dep

[GitHub] [groovy] paulk-asert merged pull request #1932: GROOVY-11156: remove illegal magic accessor usage

2023-09-10 Thread via GitHub
paulk-asert merged PR #1932: URL: https://github.com/apache/groovy/pull/1932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert commented on pull request #1935: Move JDK 18 into groovy-build-test-aux matrix

2023-09-11 Thread via GitHub
paulk-asert commented on PR #1935: URL: https://github.com/apache/groovy/pull/1935#issuecomment-1713297490 +1, I think you have all the necessary permissions to merge yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [groovy] paulk-asert commented on pull request #1935: Move JDK 18 into groovy-build-test-aux matrix

2023-09-11 Thread via GitHub
paulk-asert commented on PR #1935: URL: https://github.com/apache/groovy/pull/1935#issuecomment-1713318263 Yes, we can certainly squash commits when it makes sense. In fact, it is often preferred - though if there are pieces of a PR which might be cherry-picked individually for backporting

[GitHub] [groovy] blackdrag opened a new pull request, #1953: GROOVY-8299: default methods

2023-09-11 Thread via GitHub
blackdrag opened a new pull request, #1953: URL: https://github.com/apache/groovy/pull/1953 First incomplete implementation of default methods. - [ ] interface with default methods is not seen as trait anymore - [ ] stub generation adds default modifier to stub - [ ] allow

[GitHub] [groovy] glaforge opened a new pull request, #1954: Use the tap() method instead of with(), as tap() returns the object instead of returning the last expression of the closure like with with(

2023-09-13 Thread via GitHub
glaforge opened a new pull request, #1954: URL: https://github.com/apache/groovy/pull/1954 Without this change, variable p3 actually contained the int 1951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [groovy] paulk-asert merged pull request #1954: Use the tap() method instead of with(), as tap() returns the object instead of returning the last expression of the closure like with with().

2023-09-13 Thread via GitHub
paulk-asert merged PR #1954: URL: https://github.com/apache/groovy/pull/1954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1955: Bump com.gradle.enterprise from 3.13 to 3.15

2023-09-13 Thread via GitHub
dependabot[bot] opened a new pull request, #1955: URL: https://github.com/apache/groovy/pull/1955 Bumps com.gradle.enterprise from 3.13 to 3.15. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.enterpr

[GitHub] [groovy] coheigea opened a new pull request, #1956: Add Bundle-License to the generated jars

2023-09-20 Thread via GitHub
coheigea opened a new pull request, #1956: URL: https://github.com/apache/groovy/pull/1956 SBOM tools like Syft rely on the Bundle-License in the Manifest to detect licenses when generating SBOMs. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [groovy] aalmiray commented on pull request #1956: Add Bundle-License to the generated jars

2023-09-20 Thread via GitHub
aalmiray commented on PR #1956: URL: https://github.com/apache/groovy/pull/1956#issuecomment-1727485935 Must the value be a link to the text or could it be a matching SPDX identifier? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1957: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 5.1.6 to 5.1.8

2023-09-20 Thread via GitHub
dependabot[bot] opened a new pull request, #1957: URL: https://github.com/apache/groovy/pull/1957 Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/artifactory-gradle-plugin) from 5.1.6 to 5.1.8. Release notes Sourced from https://github.com/jfrog/ar

[GitHub] [groovy] daniellansun merged pull request #1957: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 5.1.6 to 5.1.8

2023-09-21 Thread via GitHub
daniellansun merged PR #1957: URL: https://github.com/apache/groovy/pull/1957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] paulk-asert merged pull request #1956: Add Bundle-License to the generated jars

2023-09-23 Thread via GitHub
paulk-asert merged PR #1956: URL: https://github.com/apache/groovy/pull/1956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1958: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 5.1.8 to 5.1.9

2023-09-24 Thread via GitHub
dependabot[bot] opened a new pull request, #1958: URL: https://github.com/apache/groovy/pull/1958 Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/artifactory-gradle-plugin) from 5.1.8 to 5.1.9. Release notes Sourced from https://github.com/jfrog/ar

[GitHub] [groovy] daniellansun merged pull request #1958: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 5.1.8 to 5.1.9

2023-09-24 Thread via GitHub
daniellansun merged PR #1958: URL: https://github.com/apache/groovy/pull/1958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1960: Bump org.sonarqube from 4.3.1.3277 to 4.4.0.3356

2023-09-27 Thread via GitHub
dependabot[bot] opened a new pull request, #1960: URL: https://github.com/apache/groovy/pull/1960 Bumps org.sonarqube from 4.3.1.3277 to 4.4.0.3356. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.sonarqube&

[GitHub] [groovy] daniellansun merged pull request #1959: GROOVY-11183: Add `allThreads` method to `Thread`

2023-09-28 Thread via GitHub
daniellansun merged PR #1959: URL: https://github.com/apache/groovy/pull/1959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] paulk-asert commented on pull request #1953: GROOVY-8299: default methods

2023-10-01 Thread via GitHub
paulk-asert commented on PR #1953: URL: https://github.com/apache/groovy/pull/1953#issuecomment-1742215546 Jochen, looks great to me. I'll rebase and merge tomorrow if no further feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1961: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 5.1.9 to 5.1.10

2023-10-01 Thread via GitHub
dependabot[bot] opened a new pull request, #1961: URL: https://github.com/apache/groovy/pull/1961 Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/artifactory-gradle-plugin) from 5.1.9 to 5.1.10. Release notes Sourced from https://github.com/jfrog/a

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1962: Bump com.gradle.common-custom-user-data-gradle-plugin from 1.11.2 to 1.11.3

2023-10-01 Thread via GitHub
dependabot[bot] opened a new pull request, #1962: URL: https://github.com/apache/groovy/pull/1962 Bumps com.gradle.common-custom-user-data-gradle-plugin from 1.11.2 to 1.11.3. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dep

Re: [PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 1.11.2 to 1.11.3 [groovy]

2023-10-02 Thread via GitHub
Goooler merged PR #1962: URL: https://github.com/apache/groovy/pull/1962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] Bump org.jfrog.buildinfo:build-info-extractor-gradle from 5.1.9 to 5.1.10 [groovy]

2023-10-02 Thread via GitHub
Goooler merged PR #1961: URL: https://github.com/apache/groovy/pull/1961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] GROOVY-8299: default methods [groovy]

2023-10-03 Thread via GitHub
paulk-asert commented on PR #1953: URL: https://github.com/apache/groovy/pull/1953#issuecomment-1744745102 Merged! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] GROOVY-8299: default methods [groovy]

2023-10-03 Thread via GitHub
paulk-asert closed pull request #1953: GROOVY-8299: default methods URL: https://github.com/apache/groovy/pull/1953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] GROOVY-9801: add test case for stub generation with default method [groovy]

2023-10-03 Thread via GitHub
blackdrag opened a new pull request, #1963: URL: https://github.com/apache/groovy/pull/1963 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[PR] Bump org.sonarqube from 4.3.1.3277 to 4.4.1.3373 [groovy]

2023-10-03 Thread via GitHub
dependabot[bot] opened a new pull request, #1964: URL: https://github.com/apache/groovy/pull/1964 Bumps org.sonarqube from 4.3.1.3277 to 4.4.1.3373. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.sonarqube&

Re: [PR] Bump org.sonarqube from 4.3.1.3277 to 4.4.0.3356 [groovy]

2023-10-03 Thread via GitHub
dependabot[bot] commented on PR #1960: URL: https://github.com/apache/groovy/pull/1960#issuecomment-1745973281 Superseded by #1964. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Bump org.sonarqube from 4.3.1.3277 to 4.4.0.3356 [groovy]

2023-10-03 Thread via GitHub
dependabot[bot] closed pull request #1960: Bump org.sonarqube from 4.3.1.3277 to 4.4.0.3356 URL: https://github.com/apache/groovy/pull/1960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Bump org.sonarqube from 4.3.1.3277 to 4.4.1.3373 [groovy]

2023-10-03 Thread via GitHub
Goooler merged PR #1964: URL: https://github.com/apache/groovy/pull/1964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] GROOVY-9801: add test case for stub generation with default method [groovy]

2023-10-04 Thread via GitHub
daniellansun commented on PR #1963: URL: https://github.com/apache/groovy/pull/1963#issuecomment-1747975308 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-9801: add test case for stub generation with default method [groovy]

2023-10-04 Thread via GitHub
daniellansun merged PR #1963: URL: https://github.com/apache/groovy/pull/1963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] Bump com.gradle.enterprise from 3.13 to 3.15.1 [groovy]

2023-10-05 Thread via GitHub
dependabot[bot] opened a new pull request, #1965: URL: https://github.com/apache/groovy/pull/1965 Bumps com.gradle.enterprise from 3.13 to 3.15.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.enter

Re: [PR] Bump com.gradle.enterprise from 3.13 to 3.15.1 [groovy]

2023-10-06 Thread via GitHub
dependabot[bot] commented on PR #1965: URL: https://github.com/apache/groovy/pull/1965#issuecomment-1750383948 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump com.gradle.enterprise from 3.13 to 3.15.1 [groovy]

2023-10-06 Thread via GitHub
Goooler closed pull request #1965: Bump com.gradle.enterprise from 3.13 to 3.15.1 URL: https://github.com/apache/groovy/pull/1965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] Bump com.github.ben-manes.versions from 0.48.0 to 0.49.0 [groovy]

2023-10-08 Thread via GitHub
dependabot[bot] opened a new pull request, #1966: URL: https://github.com/apache/groovy/pull/1966 Bumps com.github.ben-manes.versions from 0.48.0 to 0.49.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gi

[PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.3 to 5.1.4 [groovy]

2023-10-08 Thread via GitHub
dependabot[bot] opened a new pull request, #1967: URL: https://github.com/apache/groovy/pull/1967 Bumps [com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 5.1.3 to 5.1.4. Release notes Sourced from https://github.com/spotbugs

Re: [PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.3 to 5.1.4 [groovy]

2023-10-08 Thread via GitHub
Goooler merged PR #1967: URL: https://github.com/apache/groovy/pull/1967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] Bump com.github.ben-manes.versions from 0.48.0 to 0.49.0 [groovy]

2023-10-08 Thread via GitHub
Goooler merged PR #1966: URL: https://github.com/apache/groovy/pull/1966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

[PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.4 to 5.1.5 [groovy]

2023-10-12 Thread via GitHub
dependabot[bot] opened a new pull request, #1968: URL: https://github.com/apache/groovy/pull/1968 Bumps [com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 5.1.4 to 5.1.5. Release notes Sourced from https://github.com/spotbugs

Re: [PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.4 to 5.1.5 [groovy]

2023-10-14 Thread via GitHub
Goooler merged PR #1968: URL: https://github.com/apache/groovy/pull/1968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

[PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.5 to 5.2.0 [groovy]

2023-10-15 Thread via GitHub
dependabot[bot] opened a new pull request, #1969: URL: https://github.com/apache/groovy/pull/1969 Bumps [com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 5.1.5 to 5.2.0. Release notes Sourced from https://github.com/spotbugs

Re: [PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.1.5 to 5.2.0 [groovy]

2023-10-16 Thread via GitHub
Goooler merged PR #1969: URL: https://github.com/apache/groovy/pull/1969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] fix GROOVY-9367 [groovy]

2023-10-17 Thread via GitHub
asfgit closed pull request #1147: fix GROOVY-9367 URL: https://github.com/apache/groovy/pull/1147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [PR] GROOVY-11192: Diamond inference should work on subclasses with less generic parameters [groovy]

2023-10-18 Thread via GitHub
blackdrag commented on PR #1970: URL: https://github.com/apache/groovy/pull/1970#issuecomment-1769267973 could you please add a test case: interface A { } class B implements A{ } A a = new B<>() oh yes.. usi

Re: [PR] GROOVY-11192: Diamond inference should work on subclasses with less generic parameters [groovy]

2023-10-18 Thread via GitHub
eric-milles commented on PR #1970: URL: https://github.com/apache/groovy/pull/1970#issuecomment-1769290243 Generics is a very tricky area of the compiler. The diamond inference may assume that the target type's generics exactly correspond to the constructor type's generics. I don't think

[PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.0 to 5.2.1 [groovy]

2023-10-18 Thread via GitHub
dependabot[bot] opened a new pull request, #1971: URL: https://github.com/apache/groovy/pull/1971 Bumps [com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 5.2.0 to 5.2.1. Release notes Sourced from https://github.com/spotbugs

Re: [PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.0 to 5.2.1 [groovy]

2023-10-18 Thread via GitHub
Goooler merged PR #1971: URL: https://github.com/apache/groovy/pull/1971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] GROOVY-11192: Diamond inference should work on subclasses with less generic parameters [groovy]

2023-10-19 Thread via GitHub
yuhengfdada commented on PR #1970: URL: https://github.com/apache/groovy/pull/1970#issuecomment-1771312550 Thank you so much @blackdrag @eric-milles for your comments . Now I understand the problem is more complicated than I thought. Closing the PR for now. -- This is an automated messag

Re: [PR] GROOVY-11192: Diamond inference should work on subclasses with less generic parameters [groovy]

2023-10-19 Thread via GitHub
yuhengfdada closed pull request #1970: GROOVY-11192: Diamond inference should work on subclasses with less generic parameters URL: https://github.com/apache/groovy/pull/1970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] GROOVY-11192: Diamond inference should work on subclasses with less generic parameters [groovy]

2023-10-19 Thread via GitHub
yuhengfdada commented on PR #1970: URL: https://github.com/apache/groovy/pull/1970#issuecomment-1771993296 > Generics is a very tricky area of the compiler. The diamond inference may assume that the target type's generics exactly correspond to the constructor type's generics. I don't think

[PR] GROOVY-11200: JsonSlurper should throw exception when parsing invalid String ended with a right curly brace [groovy]

2023-10-21 Thread via GitHub
yuhengfdada opened a new pull request, #1972: URL: https://github.com/apache/groovy/pull/1972 # Analysis As mentioned by Paul's comment in the jira, this is a bug in `JsonParserCharArray`. The problem does not exist in `JsonParserUsingCharacterSource`. After debugging through both cla

[PR] GROOVY-11200: (Second Approach) JsonSlurper should throw exception when parsing invalid String ended with a right curly brace [groovy]

2023-10-22 Thread via GitHub
yuhengfdada opened a new pull request, #1974: URL: https://github.com/apache/groovy/pull/1974 This approach avoids array copy as in https://github.com/apache/groovy/pull/1972 by using a simple counter. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] GROOVY-11200: JsonSlurper should throw exception when parsing invalid String ended with a right curly brace [groovy]

2023-10-22 Thread via GitHub
yuhengfdada commented on PR #1972: URL: https://github.com/apache/groovy/pull/1972#issuecomment-1774046490 With this change, this unit test is failing in `JsonSlurperLaxTest.groovy`: ``` void testArrayOfArrayWithSimpleValues() { assert parser.parseText('[1, 2, 3, ["a", "b

Re: [PR] fix(XmlUtil): escapeControlCharacters off-by-one bug [groovy]

2023-10-22 Thread via GitHub
daniellansun commented on PR #1973: URL: https://github.com/apache/groovy/pull/1973#issuecomment-1774077583 It would be better if you could provide the related test as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 1.11.3 to 1.12 [groovy]

2023-10-23 Thread via GitHub
dependabot[bot] opened a new pull request, #1975: URL: https://github.com/apache/groovy/pull/1975 Bumps com.gradle.common-custom-user-data-gradle-plugin from 1.11.3 to 1.12. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?depen

Re: [PR] GROOVY-11200: JsonSlurper should throw exception when parsing invalid String ended with a right curly brace [groovy]

2023-10-24 Thread via GitHub
yuhengfdada commented on PR #1972: URL: https://github.com/apache/groovy/pull/1972#issuecomment-1777313262 > With this change, this unit test is failing in `JsonSlurperLaxTest.groovy`: > > ``` > void testArrayOfArrayWithSimpleValues() { > assert parser.parseText('[1,

Re: [PR] GROOVY-11200: JsonSlurper should throw exception when parsing invalid String ended with a right curly brace [groovy]

2023-10-24 Thread via GitHub
yuhengfdada closed pull request #1972: GROOVY-11200: JsonSlurper should throw exception when parsing invalid String ended with a right curly brace URL: https://github.com/apache/groovy/pull/1972 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Groovy-11194 (Groovy 3.0) [groovy]

2023-10-24 Thread via GitHub
keeganwitt opened a new pull request, #1976: URL: https://github.com/apache/groovy/pull/1976 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[PR] GROOVY-11194 (Groovy 2.5) [groovy]

2023-10-24 Thread via GitHub
keeganwitt opened a new pull request, #1977: URL: https://github.com/apache/groovy/pull/1977 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 1.11.3 to 1.12 [groovy]

2023-10-25 Thread via GitHub
Goooler merged PR #1975: URL: https://github.com/apache/groovy/pull/1975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] fix(XmlUtil): escapeControlCharacters off-by-one bug [groovy]

2023-10-26 Thread via GitHub
pinicarus commented on PR #1973: URL: https://github.com/apache/groovy/pull/1973#issuecomment-1780972154 > It would be better if you could provide the related test as well. I added the range bounds to the existing test -- This is an automated message from the Apache Git Service. To

Re: [PR] fix(XmlUtil): escapeControlCharacters off-by-one bug [groovy]

2023-10-26 Thread via GitHub
paulk-asert merged PR #1973: URL: https://github.com/apache/groovy/pull/1973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] fix(XmlUtil): escapeControlCharacters off-by-one bug [groovy]

2023-10-27 Thread via GitHub
paulk-asert commented on PR #1973: URL: https://github.com/apache/groovy/pull/1973#issuecomment-1783659833 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] Bump me.champeau.jmh:jmh-gradle-plugin from 0.7.1 to 0.7.2 [groovy]

2023-10-29 Thread via GitHub
dependabot[bot] opened a new pull request, #1978: URL: https://github.com/apache/groovy/pull/1978 Bumps me.champeau.jmh:jmh-gradle-plugin from 0.7.1 to 0.7.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=me.c

Re: [PR] Bump me.champeau.jmh:jmh-gradle-plugin from 0.7.1 to 0.7.2 [groovy]

2023-10-30 Thread via GitHub
Goooler merged PR #1978: URL: https://github.com/apache/groovy/pull/1978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] GROOVY-11210: Bump Commons CLI to 1.6.0 [groovy]

2023-10-30 Thread via GitHub
daniellansun commented on PR #1979: URL: https://github.com/apache/groovy/pull/1979#issuecomment-1785004088 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] GROOVY-11210: Bump Commons CLI to 1.6.0 [groovy]

2023-10-30 Thread via GitHub
paulk-asert merged PR #1979: URL: https://github.com/apache/groovy/pull/1979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] GROOVY-11214: Bump jansi to 2.4.1 [groovy]

2023-11-05 Thread via GitHub
paulk-asert opened a new pull request, #1980: URL: https://github.com/apache/groovy/pull/1980 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] GROOVY-11214: Bump jansi to 2.4.1 [groovy]

2023-11-05 Thread via GitHub
paulk-asert merged PR #1980: URL: https://github.com/apache/groovy/pull/1980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11215: Bump JUnit Jupiter/JUnit Platform to 5.10.1/1.10.1 [groovy]

2023-11-05 Thread via GitHub
paulk-asert merged PR #1981: URL: https://github.com/apache/groovy/pull/1981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] GROOVY-11217: Bump Spotbugs/Spotbugs annotations to 4.8.0 (build depe… [groovy]

2023-11-05 Thread via GitHub
paulk-asert opened a new pull request, #1983: URL: https://github.com/apache/groovy/pull/1983 …ndency) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] GROOVY-11216: Bump checkstyle to 10.12.4 (build dependency) [groovy]

2023-11-06 Thread via GitHub
paulk-asert merged PR #1982: URL: https://github.com/apache/groovy/pull/1982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11217: Bump Spotbugs/Spotbugs annotations to 4.8.0 (build depe… [groovy]

2023-11-06 Thread via GitHub
paulk-asert merged PR #1983: URL: https://github.com/apache/groovy/pull/1983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] GROOVY-11218: Bump jackson/jackson-databind to 2.15.3 [groovy]

2023-11-06 Thread via GitHub
paulk-asert opened a new pull request, #1984: URL: https://github.com/apache/groovy/pull/1984 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] GROOVY-11218: Bump jackson/jackson-databind to 2.15.3 [groovy]

2023-11-06 Thread via GitHub
paulk-asert merged PR #1984: URL: https://github.com/apache/groovy/pull/1984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11219: Bump javaparser to 3.25.6 [groovy]

2023-11-06 Thread via GitHub
paulk-asert merged PR #1985: URL: https://github.com/apache/groovy/pull/1985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] GROOVY-11221: Bump log4j2 version to 2.21.1 (test dependency) [groovy]

2023-11-06 Thread via GitHub
paulk-asert opened a new pull request, #1986: URL: https://github.com/apache/groovy/pull/1986 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] GROOVY-11221: Bump log4j2 version to 2.21.1 (test dependency) [groovy]

2023-11-06 Thread via GitHub
paulk-asert merged PR #1986: URL: https://github.com/apache/groovy/pull/1986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.1 to 5.2.3 [groovy]

2023-11-07 Thread via GitHub
dependabot[bot] opened a new pull request, #1987: URL: https://github.com/apache/groovy/pull/1987 Bumps [com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 5.2.1 to 5.2.3. Release notes Sourced from https://github.com/spotbugs

Re: [PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.1 to 5.2.3 [groovy]

2023-11-08 Thread via GitHub
Goooler merged PR #1987: URL: https://github.com/apache/groovy/pull/1987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

[PR] Bump com.github.ben-manes.versions from 0.49.0 to 0.50.0 [groovy]

2023-11-19 Thread via GitHub
dependabot[bot] opened a new pull request, #1988: URL: https://github.com/apache/groovy/pull/1988 Bumps com.github.ben-manes.versions from 0.49.0 to 0.50.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gi

[PR] Fix typo dor -> for in MetaClassImpl docstrings [groovy]

2023-11-20 Thread via GitHub
AndreyBozhko opened a new pull request, #1990: URL: https://github.com/apache/groovy/pull/1990 Looks like there is a typo in the docstrings for MetaClassImpl constructors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Bump org.jfrog.buildinfo:build-info-extractor-gradle from 5.1.10 to 5.1.11 [groovy]

2023-11-20 Thread via GitHub
dependabot[bot] opened a new pull request, #1991: URL: https://github.com/apache/groovy/pull/1991 Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/artifactory-gradle-plugin) from 5.1.10 to 5.1.11. Release notes Sourced from https://github.com/jfrog/

Re: [PR] Fix typo dor -> for in MetaClassImpl docstrings [groovy]

2023-11-20 Thread via GitHub
paulk-asert merged PR #1990: URL: https://github.com/apache/groovy/pull/1990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] Fix typo dor -> for in MetaClassImpl docstrings [groovy]

2023-11-20 Thread via GitHub
paulk-asert commented on PR #1990: URL: https://github.com/apache/groovy/pull/1990#issuecomment-1820360754 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Bump org.jfrog.buildinfo:build-info-extractor-gradle from 5.1.10 to 5.1.11 [groovy]

2023-11-21 Thread via GitHub
daniellansun merged PR #1991: URL: https://github.com/apache/groovy/pull/1991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] Bump com.github.ben-manes.versions from 0.49.0 to 0.50.0 [groovy]

2023-11-21 Thread via GitHub
daniellansun merged PR #1988: URL: https://github.com/apache/groovy/pull/1988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] GROOVY-11194 (Groovy 4.0) [groovy]

2023-11-21 Thread via GitHub
keeganwitt opened a new pull request, #1992: URL: https://github.com/apache/groovy/pull/1992 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] GROOVY-11194 (Groovy 4.0) [groovy]

2023-11-21 Thread via GitHub
codecov-commenter commented on PR #1992: URL: https://github.com/apache/groovy/pull/1992#issuecomment-1821943088 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/1992?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Re

Re: [PR] GROOVY-11194: Add missing options [groovy]

2023-11-21 Thread via GitHub
daniellansun commented on PR #1993: URL: https://github.com/apache/groovy/pull/1993#issuecomment-1822201590 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] GROOVY-11224: Reconsider name duplication for groovysh [groovy]

2023-11-22 Thread via GitHub
paulk-asert merged PR #1989: URL: https://github.com/apache/groovy/pull/1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11194: Add missing options [groovy]

2023-11-23 Thread via GitHub
daniellansun merged PR #1993: URL: https://github.com/apache/groovy/pull/1993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11194: Add missing options [groovy]

2023-11-23 Thread via GitHub
daniellansun commented on PR #1993: URL: https://github.com/apache/groovy/pull/1993#issuecomment-1824629521 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
eric-milles commented on PR #1994: URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826377223 Do you have some description how this will be integrated? Adding something to `ClassExpression` without changing its `transformExpression` or `visit` does not make it clear where this

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
daniellansun commented on PR #1994: URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826386161 I am looking for better AST for pattern matching for both `instanceof` and `switch`. The PR is just for `instanceof`, but I try to make flexible to change easily for other pattern

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
eric-milles commented on PR #1994: URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826398019 It would have been better to state in the original issue ticket that the goal is to support `instanceof` and `switch` pattern matching. It is still not clear from this where your plan

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
daniellansun closed pull request #1994: GROOVY-11229: Support pattern matching for `instanceof` URL: https://github.com/apache/groovy/pull/1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

<    2   3   4   5   6   7   8   9   10   11   >