codecov-commenter commented on PR #2043:
URL: https://github.com/apache/groovy/pull/2043#issuecomment-1911709539
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2043?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
Goooler opened a new pull request, #2045:
URL: https://github.com/apache/groovy/pull/2045
https://github.com/gradle/gradle-build-action/releases/tag/v3.0.0-rc.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Goooler merged PR #2045:
URL: https://github.com/apache/groovy/pull/2045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
codecov-commenter commented on PR #2044:
URL: https://github.com/apache/groovy/pull/2044#issuecomment-1912997552
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
eric-milles commented on PR #2044:
URL: https://github.com/apache/groovy/pull/2044#issuecomment-1913181493
Adding reliance on the runtime library (`InvokerHelper` and `VMPlugin`)
means a record can no longer be tagged `@POJO` and used in a vanilla java
environment. And though an immutable
dependabot[bot] opened a new pull request, #2046:
URL: https://github.com/apache/groovy/pull/2046
Bumps com.gradle.enterprise from 3.15 to 3.16.2.
[
Re
paulk-asert opened a new pull request, #2047:
URL: https://github.com/apache/groovy/pull/2047
…return immutable collections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
codecov-commenter commented on PR #2047:
URL: https://github.com/apache/groovy/pull/2047#issuecomment-1913971350
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2047?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
daniellansun commented on PR #2047:
URL: https://github.com/apache/groovy/pull/2047#issuecomment-1914000468
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Goooler merged PR #2046:
URL: https://github.com/apache/groovy/pull/2046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
PaintNinja commented on PR #2044:
URL: https://github.com/apache/groovy/pull/2044#issuecomment-1915649600
Groovy records already rely on the runtime library - the generated toList()
and toMap() use ScriptBytecodeAdapter#createList/createMap in Groovy 4 and
Groovy 5 snapshots (pre this PR).
Goooler merged PR #2043:
URL: https://github.com/apache/groovy/pull/2043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
Goooler merged PR #2049:
URL: https://github.com/apache/groovy/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
Goooler opened a new pull request, #2050:
URL: https://github.com/apache/groovy/pull/2050
It's easy to forget to modify this property, and we have no much necessary
to input it for Wrapper tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
codecov-commenter commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925559975
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
paulk-asert commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925604789
I don't think we can remove this. Current ASF policy prohibits binary files
like the wrapper jar from being included in the src zip. So, to build from
source, we need to have the boots
Goooler commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925609969
If we can remove that line to prevent `gradle/wrapper` been deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
paulk-asert commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925641963
That is the spec for building the source zip. As per ASF requirements, it
can't contain binary files, e.g. gradle-wrapper.jar. We have asked for an
exemption in the past but haven't be
Goooler closed pull request #2050: Remove redundant `gradle_version` property
URL: https://github.com/apache/groovy/pull/2050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Goooler commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925642357
Got it! Thanks for your explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
aalmiray commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925654703
FWIW I followed the trail of the Maven wrapper to bootstrap it from source.
The initial commit is here
https://github.com/jreleaser/jreleaser/commit/82f0706d98674f761d7253b81952b19756100a
dependabot[bot] opened a new pull request, #2051:
URL: https://github.com/apache/groovy/pull/2051
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action)
from 3 to 4.
Release notes
Sourced from https://github.com/codecov/codecov-action/releases";>codecov/codecov-a
dependabot[bot] opened a new pull request, #2052:
URL: https://github.com/apache/groovy/pull/2052
Bumps
[gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action)
from 1.1.0 to 2.0.0.
Release notes
Sourced from https://github.com/gradle/wrapper-validat
codecov-commenter commented on PR #2052:
URL: https://github.com/apache/groovy/pull/2052#issuecomment-1926083766
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
Goooler merged PR #2052:
URL: https://github.com/apache/groovy/pull/2052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
Goooler commented on PR #2051:
URL: https://github.com/apache/groovy/pull/2051#issuecomment-1926116531
https://github.com/codecov/codecov-action/releases/tag/v4.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
Goooler commented on PR #2051:
URL: https://github.com/apache/groovy/pull/2051#issuecomment-1926118774
Seems @codecov-commenter doesn't comment this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
codecov-commenter commented on PR #2053:
URL: https://github.com/apache/groovy/pull/2053#issuecomment-1926312237
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2053?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
paulk-asert merged PR #2047:
URL: https://github.com/apache/groovy/pull/2047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert closed pull request #2044: GROOVY-11294: Make generated toList()
and toMap() methods on records return immutable collections
URL: https://github.com/apache/groovy/pull/2044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
paulk-asert commented on PR #2044:
URL: https://github.com/apache/groovy/pull/2044#issuecomment-1926785163
As per comment in the issue, I'll close this PR. There is plenty of scope
for further improvements - as noted, even with POJO, records still make calls
into runtime. This is why @POJO
paulk-asert commented on PR #2048:
URL: https://github.com/apache/groovy/pull/2048#issuecomment-1926786023
Plan to look at this tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
paulk-asert merged PR #2048:
URL: https://github.com/apache/groovy/pull/2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
Goooler commented on PR #2048:
URL: https://github.com/apache/groovy/pull/2048#issuecomment-1928713497
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
paulk-asert merged PR #2053:
URL: https://github.com/apache/groovy/pull/2053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
codecov-commenter commented on PR #2054:
URL: https://github.com/apache/groovy/pull/2054#issuecomment-1933196729
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
paulk-asert commented on PR #2054:
URL: https://github.com/apache/groovy/pull/2054#issuecomment-1933522752
This looks okay to me. But, by way of background, if we ever wanted to
change the default list in Groovy from ArrayList to LinkedList (not that we
would), we would now have one more pl
Goooler commented on PR #2051:
URL: https://github.com/apache/groovy/pull/2051#issuecomment-1933652125
@dependabot Rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
PaintNinja commented on PR #2054:
URL: https://github.com/apache/groovy/pull/2054#issuecomment-1933744394
Thanks. In that case, would you like me to add a code comment to
ScriptBytecodeAdapter#createList, referencing this change?
--
This is an automated message from the Apache Git Service
paulk-asert commented on PR #2054:
URL: https://github.com/apache/groovy/pull/2054#issuecomment-1935490334
> Thanks. In that case, would you like me to add a code comment to
ScriptBytecodeAdapter#createList, referencing this change?
Probably not needed in this case.
--
This is an a
daniellansun commented on PR #2054:
URL: https://github.com/apache/groovy/pull/2054#issuecomment-1936835711
How about creating empty map, empty array?
IMHO, both maintenance and flexibility are important, but the PR reduces
them in the same time...
-1 from me.
--
This is
dependabot[bot] opened a new pull request, #2055:
URL: https://github.com/apache/groovy/pull/2055
Bumps
[gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action)
from 2.0.0 to 2.1.1.
Release notes
Sourced from https://github.com/gradle/wrapper-validat
codecov-commenter commented on PR #2055:
URL: https://github.com/apache/groovy/pull/2055#issuecomment-1937982382
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2055?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
paulk-asert merged PR #2055:
URL: https://github.com/apache/groovy/pull/2055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
Goooler commented on PR #2051:
URL: https://github.com/apache/groovy/pull/2051#issuecomment-1939084926
Need an extra token from v4, see
https://docs.codecov.com/docs/adding-the-codecov-token#github-actions
--
This is an automated message from the Apache Git Service.
To respond to the mess
codecov-commenter commented on PR #2056:
URL: https://github.com/apache/groovy/pull/2056#issuecomment-1943095932
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2056?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
paulk-asert merged PR #2056:
URL: https://github.com/apache/groovy/pull/2056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #2056:
URL: https://github.com/apache/groovy/pull/2056#issuecomment-1943102336
Merged, thanks! There is a small tweak we can do to get the minor
performance gain that I think the original code was after, but I can do that
after the merge.
--
This is an automat
dependabot[bot] opened a new pull request, #2057:
URL: https://github.com/apache/groovy/pull/2057
Bumps
[org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/artifactory-gradle-plugin)
from 5.1.14 to 5.2.0.
Release notes
Sourced from https://github.com/jfrog/a
codecov-commenter commented on PR #2057:
URL: https://github.com/apache/groovy/pull/2057#issuecomment-1945219214
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
Goooler merged PR #2057:
URL: https://github.com/apache/groovy/pull/2057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
codecov-commenter commented on PR #2059:
URL: https://github.com/apache/groovy/pull/2059#issuecomment-1951200981
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
paulk-asert closed pull request #2054: GROOVY-11309 Optimise bytecode for empty
list expressions
URL: https://github.com/apache/groovy/pull/2054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
paulk-asert commented on PR #2054:
URL: https://github.com/apache/groovy/pull/2054#issuecomment-1953451647
I'll close this PR since a -1 vote for a code change is an absolute veto:
https://www.apache.org/foundation/voting.html
I have kept it open for a while since the normal process
paulk-asert merged PR #2059:
URL: https://github.com/apache/groovy/pull/2059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun merged PR #2020:
URL: https://github.com/apache/groovy/pull/2020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2020:
URL: https://github.com/apache/groovy/pull/2020#issuecomment-1956687500
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Goooler merged PR #2058:
URL: https://github.com/apache/groovy/pull/2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
dependabot[bot] opened a new pull request, #2060:
URL: https://github.com/apache/groovy/pull/2060
Bumps com.gradle.common-custom-user-data-gradle-plugin from 1.12.1 to 1.12.2.
[
Re
paulk-asert merged PR #2060:
URL: https://github.com/apache/groovy/pull/2060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2061:
URL: https://github.com/apache/groovy/pull/2061
Bumps
[com.h3xstream.findsecbugs:findsecbugs-plugin](https://github.com/find-sec-bugs/find-sec-bugs)
from 1.12.0 to 1.13.0.
Release notes
Sourced from https://github.com/find-sec-bugs
codecov-commenter commented on PR #2061:
URL: https://github.com/apache/groovy/pull/2061#issuecomment-1965626389
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2061?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
Goooler merged PR #2061:
URL: https://github.com/apache/groovy/pull/2061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
dependabot[bot] opened a new pull request, #2062:
URL: https://github.com/apache/groovy/pull/2062
Bumps com.gradle.common-custom-user-data-gradle-plugin from 1.12.2 to 1.13.
[
Re
Goooler merged PR #2062:
URL: https://github.com/apache/groovy/pull/2062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
paulk-asert closed pull request #1496: GROOVY-6360: move @Pure to separate
subproject.
URL: https://github.com/apache/groovy/pull/1496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
paulk-asert commented on PR #1496:
URL: https://github.com/apache/groovy/pull/1496#issuecomment-1977786718
I'll close this. The intention of moving this to a separate jar was so other
folks could start using the annotation without depending on (all of) Groovy. I
am not sure the world is a b
paulk-asert opened a new pull request, #2063:
URL: https://github.com/apache/groovy/pull/2063
Remove experimental AGM minBy/maxBy @Incubating methods now that selection
by parameter count is improved
--
This is an automated message from the Apache Git Service.
To respond to the message, p
codecov-commenter commented on PR #2063:
URL: https://github.com/apache/groovy/pull/2063#issuecomment-1984340475
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2063?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
daniellansun commented on PR #2063:
URL: https://github.com/apache/groovy/pull/2063#issuecomment-1984769387
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
paulk-asert merged PR #2063:
URL: https://github.com/apache/groovy/pull/2063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2064:
URL: https://github.com/apache/groovy/pull/2064
Bumps com.github.jk1.dependency-license-report from 2.5 to 2.6.
[
Re
testwill opened a new pull request, #2065:
URL: https://github.com/apache/groovy/pull/2065
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
paulk-asert merged PR #2065:
URL: https://github.com/apache/groovy/pull/2065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #2065:
URL: https://github.com/apache/groovy/pull/2065#issuecomment-1993907480
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Goooler merged PR #2064:
URL: https://github.com/apache/groovy/pull/2064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
Goooler opened a new pull request, #2066:
URL: https://github.com/apache/groovy/pull/2066
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
codecov-commenter commented on PR #2066:
URL: https://github.com/apache/groovy/pull/2066#issuecomment-2011199514
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2066?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
Goooler merged PR #2066:
URL: https://github.com/apache/groovy/pull/2066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
dependabot[bot] opened a new pull request, #2067:
URL: https://github.com/apache/groovy/pull/2067
Bumps
[gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action)
from 2.1.1 to 2.1.2.
Release notes
Sourced from https://github.com/gradle/wrapper-validat
codecov-commenter commented on PR #2067:
URL: https://github.com/apache/groovy/pull/2067#issuecomment-2017077450
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2067?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
Goooler merged PR #2067:
URL: https://github.com/apache/groovy/pull/2067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
dependabot[bot] opened a new pull request, #2068:
URL: https://github.com/apache/groovy/pull/2068
Bumps org.sonarqube from 4.4.1.3373 to 5.0.0.4638.
[