Re: [PR] GROOVY-11639: include super interface fields in face's property index [groovy]

2025-04-28 Thread via GitHub
eric-milles merged PR #2205: URL: https://github.com/apache/groovy/pull/2205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11637: Gradle 8.14 [groovy]

2025-04-28 Thread via GitHub
codecov-commenter commented on PR #2195: URL: https://github.com/apache/groovy/pull/2195#issuecomment-2835572372 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2195?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11513: include `import java.time.*` by default [groovy]

2025-04-28 Thread via GitHub
codeconsole commented on PR #2156: URL: https://github.com/apache/groovy/pull/2156#issuecomment-2837341316 @paulk-asert not having java.time.* by default is a major hindrance for large projects that want to migrate away from Date to LocalDate. As an example, requiring an extra import prohi

Re: [PR] GROOVY-11639: include super interface fields in face's property index [groovy]

2025-04-26 Thread via GitHub
codecov-commenter commented on PR #2205: URL: https://github.com/apache/groovy/pull/2205#issuecomment-283272 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2205?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11637: Gradle 8.14 [groovy]

2025-04-28 Thread via GitHub
daniellansun commented on PR #2195: URL: https://github.com/apache/groovy/pull/2195#issuecomment-2836605125 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] add partitionPoint to Groovy Array and List [groovy]

2025-05-03 Thread via GitHub
dongwq opened a new pull request, #2210: URL: https://github.com/apache/groovy/pull/2210 ref: https://en.cppreference.com/w/cpp/algorithm/ranges/partition_point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] GROOVY-11642: include annotations and modifiers in inner class offset [groovy]

2025-05-03 Thread via GitHub
eric-milles opened a new pull request, #2211: URL: https://github.com/apache/groovy/pull/2211 inner class offset like outer class offset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] GROOVY-11642: include annotations and modifiers in inner class offset [groovy]

2025-05-03 Thread via GitHub
codecov-commenter commented on PR #2211: URL: https://github.com/apache/groovy/pull/2211#issuecomment-2848697999 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2211?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-03 Thread via GitHub
paulk-asert commented on PR #2210: URL: https://github.com/apache/groovy/pull/2210#issuecomment-2848855320 I created this issue to track this potential enhancement: https://issues.apache.org/jira/browse/GROOVY-11649 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] GROOVY-11650: Create drain extension method for Queues [groovy]

2025-05-03 Thread via GitHub
codecov-commenter commented on PR #2212: URL: https://github.com/apache/groovy/pull/2212#issuecomment-2849016444 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2212?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-04 Thread via GitHub
dongwq commented on PR #2210: URL: https://github.com/apache/groovy/pull/2210#issuecomment-2849075039 > This is an interesting proposal. > > One immediate point of feedback is I would change the IntRange semantics to follow normal Groovy idioms. I know that means it might be slightly

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-04 Thread via GitHub
dongwq commented on code in PR #2210: URL: https://github.com/apache/groovy/pull/2210#discussion_r2072551816 ## src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java: ## @@ -6576,6 +6579,528 @@ public static T[] minus(T[] self, Object removeMe) { return res

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-03 Thread via GitHub
codecov-commenter commented on PR #2210: URL: https://github.com/apache/groovy/pull/2210#issuecomment-2848861822 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2210?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-03 Thread via GitHub
paulk-asert commented on PR #2210: URL: https://github.com/apache/groovy/pull/2210#issuecomment-2848880644 This is an interesting proposal. One immediate point of feedback is I would change the IntRange semantics to follow normal Groovy idioms. I know that means it might be slightly d

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-03 Thread via GitHub
paulk-asert commented on code in PR #2210: URL: https://github.com/apache/groovy/pull/2210#discussion_r2072491151 ## src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java: ## @@ -6576,6 +6579,528 @@ public static T[] minus(T[] self, Object removeMe) { retur

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-03 Thread via GitHub
paulk-asert commented on code in PR #2210: URL: https://github.com/apache/groovy/pull/2210#discussion_r2072491151 ## src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java: ## @@ -6576,6 +6579,528 @@ public static T[] minus(T[] self, Object removeMe) { retur

[PR] GROOVY-11650: Create drain extension method for Queues [groovy]

2025-05-03 Thread via GitHub
paulk-asert opened a new pull request, #2212: URL: https://github.com/apache/groovy/pull/2212 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] GROOVY-9530: use parsed static field value for constant inlining [groovy]

2025-04-19 Thread via GitHub
codecov-commenter commented on PR #2201: URL: https://github.com/apache/groovy/pull/2201#issuecomment-2816769847 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2201?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] GROOVY-9530: use parsed static field value for constant inlining [groovy]

2025-04-19 Thread via GitHub
eric-milles opened a new pull request, #2201: URL: https://github.com/apache/groovy/pull/2201 Step 1: use field value if given by class decompiler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] GROOVY-11624: SC: post-`ResolveVisitor`, pre-`Verifier` constant inlining [groovy]

2025-04-18 Thread via GitHub
eric-milles opened a new pull request, #2200: URL: https://github.com/apache/groovy/pull/2200 In case of references to external constants, `StaticCompilationVisitor` could replace constant arithmetic with methods calls before `Verifier` has a chance to fully inline. -- This is an automat

Re: [PR] GROOVY-11624: SC: post-`ResolveVisitor`, pre-`Verifier` constant inlining [groovy]

2025-04-18 Thread via GitHub
codecov-commenter commented on PR #2200: URL: https://github.com/apache/groovy/pull/2200#issuecomment-2816090478 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2200?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11623: STC: support return of list expression for array method [groovy]

2025-04-18 Thread via GitHub
daniellansun commented on PR #2198: URL: https://github.com/apache/groovy/pull/2198#issuecomment-2816106489 Great. Would you like to add some test cases for multi-dimensional array? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[PR] GROOVY-11630: optimize `void` groovy method return in expression statement [groovy]

2025-04-21 Thread via GitHub
eric-milles opened a new pull request, #2203: URL: https://github.com/apache/groovy/pull/2203 consolidate metadata keys to shared value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] GROOVY-11630: optimize `void` groovy method return in expression statement [groovy]

2025-04-21 Thread via GitHub
paulk-asert commented on PR #2203: URL: https://github.com/apache/groovy/pull/2203#issuecomment-2819527439 LGTM; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] GROOVY-11630: optimize `void` groovy method return in expression statement [groovy]

2025-04-21 Thread via GitHub
codecov-commenter commented on PR #2203: URL: https://github.com/apache/groovy/pull/2203#issuecomment-2818899592 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2203?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11630: optimize `void` groovy method return in expression statement [groovy]

2025-04-21 Thread via GitHub
eric-milles merged PR #2203: URL: https://github.com/apache/groovy/pull/2203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11614: Enums in switch/case statements that are not fully qual… [groovy]

2025-04-21 Thread via GitHub
daniellansun merged PR #2199: URL: https://github.com/apache/groovy/pull/2199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11614: Enums in switch/case statements that are not fully qual… [groovy]

2025-04-21 Thread via GitHub
daniellansun commented on PR #2199: URL: https://github.com/apache/groovy/pull/2199#issuecomment-2819582901 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-11624: SC: post-`ResolveVisitor`, pre-`Verifier` constant inlining [groovy]

2025-04-21 Thread via GitHub
eric-milles merged PR #2200: URL: https://github.com/apache/groovy/pull/2200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] GROOVY-7439: add test case [groovy]

2025-05-07 Thread via GitHub
eric-milles opened a new pull request, #2217: URL: https://github.com/apache/groovy/pull/2217 Adding test case for the two scenarios presented in GROOVY-7439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] GROOVY-11655: Create extension method to make StringBuilder like a stack [groovy]

2025-05-07 Thread via GitHub
paulk-asert commented on code in PR #2215: URL: https://github.com/apache/groovy/pull/2215#discussion_r2077668278 ## src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java: ## @@ -1877,6 +1878,77 @@ public static StringBuilder leftShift(final StringBuilder self, fin

Re: [PR] GROOVY-11655: Create extension method to make StringBuilder like a stack [groovy]

2025-05-08 Thread via GitHub
dongwq commented on PR #2215: URL: https://github.com/apache/groovy/pull/2215#issuecomment-2862685453 > I don't think there is much general value in providing "stack of chars" semantic. You can always provide these for your own projects through extension or category class. @eric-mill

Re: [PR] GROOVY-11655: Create extension method to make StringBuilder like a stack [groovy]

2025-05-08 Thread via GitHub
dongwq commented on code in PR #2215: URL: https://github.com/apache/groovy/pull/2215#discussion_r2079527754 ## src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java: ## @@ -1877,6 +1878,77 @@ public static StringBuilder leftShift(final StringBuilder self, final Ob

Re: [PR] GROOVY-11577: Add withIndex/indexed methods for ArrayGroovyMethods [groovy]

2025-03-01 Thread via GitHub
eric-milles commented on code in PR #2155: URL: https://github.com/apache/groovy/pull/2155#discussion_r1976496530 ## src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java: ## @@ -4526,7 +4541,26 @@ public static Map indexed(long[] self, int offset) { } /

Re: [PR] GROOVY-11577: Add withIndex/indexed methods for ArrayGroovyMethods [groovy]

2025-03-01 Thread via GitHub
paulk-asert merged PR #2155: URL: https://github.com/apache/groovy/pull/2155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11577: Add withIndex/indexed methods for ArrayGroovyMethods [groovy]

2025-03-01 Thread via GitHub
paulk-asert commented on code in PR #2155: URL: https://github.com/apache/groovy/pull/2155#discussion_r1976498473 ## src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java: ## @@ -4526,7 +4541,26 @@ public static Map indexed(long[] self, int offset) { } /

[PR] GROOVY-11577: Add withIndex/indexed methods for ArrayGroovyMethods [groovy]

2025-02-26 Thread via GitHub
paulk-asert opened a new pull request, #2155: URL: https://github.com/apache/groovy/pull/2155 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] GROOVY-11577: Add withIndex/indexed methods for ArrayGroovyMethods [groovy]

2025-02-26 Thread via GitHub
codecov-commenter commented on PR #2155: URL: https://github.com/apache/groovy/pull/2155#issuecomment-2686811607 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2155?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] Bump com.gradle.develocity from 3.18.2 to 3.19.2 [groovy]

2025-02-19 Thread via GitHub
dependabot[bot] opened a new pull request, #2153: URL: https://github.com/apache/groovy/pull/2153 Bumps com.gradle.develocity from 3.18.2 to 3.19.2. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.dev

Re: [PR] Publish build scans to develocity.apache.org [groovy]

2025-02-20 Thread via GitHub
paulk-asert commented on PR #2141: URL: https://github.com/apache/groovy/pull/2141#issuecomment-2671119948 Hopefully all moved across on the 4_0_X branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Bump com.gradle.develocity from 3.18.2 to 3.19.2 [groovy]

2025-02-19 Thread via GitHub
paulk-asert merged PR #2153: URL: https://github.com/apache/groovy/pull/2153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11571: remove excess manifest attributes [groovy]

2025-02-25 Thread via GitHub
paulk-asert commented on PR #2154: URL: https://github.com/apache/groovy/pull/2154#issuecomment-2683845318 > This is also a work-in-progress for dropping `Ant-Version` and `Created-By` from the jarjar output, which retains those attributes due to use of the Ant `jar` task to repackage the `

Re: [PR] GROOVY-11571: remove excess manifest attributes [groovy]

2025-02-25 Thread via GitHub
codecov-commenter commented on PR #2154: URL: https://github.com/apache/groovy/pull/2154#issuecomment-2683477628 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2154?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11571: remove excess manifest attributes [groovy]

2025-02-25 Thread via GitHub
paulk-asert commented on code in PR #2154: URL: https://github.com/apache/groovy/pull/2154#discussion_r1970770095 ## build-logic/src/main/groovy/org/apache/groovy/gradle/JarJarTask.groovy: ## @@ -169,16 +168,9 @@ class JarJarTask extends DefaultTask { it.into(ou

[PR] remove excess manifest attributes [groovy]

2025-02-25 Thread via GitHub
eric-milles opened a new pull request, #2154: URL: https://github.com/apache/groovy/pull/2154 I suspect not all of these are still required. This is a draft to explore removing all or some. And for any kept, adding some docs and tests. * `Bundle-ClassPath` * `DynamicImport-Packag

Re: [PR] remove excess manifest attributes [groovy]

2025-02-25 Thread via GitHub
eric-milles commented on PR #2154: URL: https://github.com/apache/groovy/pull/2154#issuecomment-2683457819 This is also a work-in-progress for dropping `Ant-Version` and `Created-By` from the jarjar output, which retains those attributes due to use of ant jar task to repackage the jarjar ar

Re: [PR] GROOVY-10683: support `for (index, item in list)` looping [groovy]

2025-03-30 Thread via GitHub
codecov-commenter commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764765742 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2169?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11596: Additional DGM lazy iterator methods [groovy]

2025-03-31 Thread via GitHub
codecov-commenter commented on PR #2170: URL: https://github.com/apache/groovy/pull/2170#issuecomment-2765866544 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2170?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-10683: support `for (index, item in list)` looping [groovy]

2025-03-30 Thread via GitHub
codecov-commenter commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764891027 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2169?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-10683: support `for (index, item in list)` looping [groovy]

2025-03-30 Thread via GitHub
codecov-commenter commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764811923 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2169?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] GROOVY-10683: support `for (item in list index i)` looping [groovy]

2025-03-29 Thread via GitHub
eric-milles opened a new pull request, #2169: URL: https://github.com/apache/groovy/pull/2169 This is a total experiment and a work-in-progress. I don't know quite how to represent the extra variable/parameter. `ForStatement` is already a bit of a mess in how it supports both `for(int i =

Re: [PR] GROOVY-10683: support `for (item in list index i)` looping [groovy]

2025-03-29 Thread via GitHub
codecov-commenter commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764337307 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2169?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-10683: support `for (item in list index i)` looping [groovy]

2025-03-29 Thread via GitHub
daniellansun commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2764351669 How about `for (int index, var item : items)`? For example: ```groovy // ① traverse a list List names = Arrays.asList("Alice", "Bob", "Charlie"); for (int i, String name

Re: [PR] GROOVY-9742: GroovyClassLoader.parseClass() StampedCommonCache.getAndPut() hang [groovy]

2025-03-29 Thread via GitHub
Copilot commented on code in PR #2168: URL: https://github.com/apache/groovy/pull/2168#discussion_r2020051653 ## src/test/groovy/bugs/groovy9742/CustomGroovyClassLoader.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] spike to test build for asm 9.8 [groovy]

2025-03-29 Thread via GitHub
paulk-asert merged PR #2161: URL: https://github.com/apache/groovy/pull/2161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 2.1 to 2.2.1 [groovy]

2025-03-29 Thread via GitHub
daniellansun merged PR #2167: URL: https://github.com/apache/groovy/pull/2167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11486: rework `flatten` type parameters, similar to `collectMany` [groovy]

2025-03-29 Thread via GitHub
daniellansun commented on PR #2157: URL: https://github.com/apache/groovy/pull/2157#issuecomment-2763249502 Merged. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] GROOVY-11486: rework `flatten` type parameters, similar to `collectMany` [groovy]

2025-03-29 Thread via GitHub
daniellansun merged PR #2157: URL: https://github.com/apache/groovy/pull/2157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11568: try `invokeMethod(Class,Object,Object[],boolean,boolean)` [groovy]

2025-03-29 Thread via GitHub
daniellansun commented on PR #2158: URL: https://github.com/apache/groovy/pull/2158#issuecomment-2763248536 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-11596: Additional DGM lazy iterator methods [groovy]

2025-04-02 Thread via GitHub
daniellansun merged PR #2170: URL: https://github.com/apache/groovy/pull/2170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-4721: variable declared in try block is in scope in finally block [groovy]

2025-04-04 Thread via GitHub
paulk-asert commented on code in PR #2172: URL: https://github.com/apache/groovy/pull/2172#discussion_r2028683776 ## subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/GroovyshTest.groovy: ## @@ -392,17 +394,34 @@ class GroovyshInterpreterModeTest extends Gro

Re: [PR] GROOVY-4721: variable declared in try block is in scope in finally block [groovy]

2025-04-04 Thread via GitHub
paulk-asert commented on code in PR #2172: URL: https://github.com/apache/groovy/pull/2172#discussion_r2028777348 ## subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/GroovyshTest.groovy: ## @@ -392,17 +394,34 @@ class GroovyshInterpreterModeTest extends Gro

Re: [PR] GROOVY-10683: support `for (index, item in list)` looping [groovy]

2025-04-04 Thread via GitHub
eric-milles commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2778901561 Spock's `spock.util.AstNodeToScriptVisitor#visitForLoop` will need a similar change to Groovy's `groovy.console.ui.AstNodeToScriptVisitor#visitForLoop`. -- This is an automated messa

Re: [PR] GROOVY-10683: support `for (index, item in list)` looping [groovy]

2025-04-04 Thread via GitHub
eric-milles commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2778828764 Supporting `long` would not be a big step from what is there -- grammar support is done. I can't envision the case where you would want linear iteration over that many elements. Mayb

Re: [PR] GROOVY-10683: support `for (index, item in list)` looping [groovy]

2025-04-04 Thread via GitHub
eric-milles merged PR #2169: URL: https://github.com/apache/groovy/pull/2169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-10683: support `for (index, item in list)` looping [groovy]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2778979938 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2169?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-4721: variable declared in try block is in scope in finally block [groovy]

2025-04-04 Thread via GitHub
daniellansun commented on code in PR #2172: URL: https://github.com/apache/groovy/pull/2172#discussion_r2029274400 ## subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/GroovyshTest.groovy: ## @@ -392,17 +394,34 @@ class GroovyshInterpreterModeTest extends Gr

Re: [PR] GROOVY-4721: variable declared in try block is in scope in finally block [groovy]

2025-04-04 Thread via GitHub
daniellansun commented on code in PR #2172: URL: https://github.com/apache/groovy/pull/2172#discussion_r2029274400 ## subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/GroovyshTest.groovy: ## @@ -392,17 +394,34 @@ class GroovyshInterpreterModeTest extends Gr

Re: [PR] spike to test build for asm 9.8 [groovy]

2025-03-22 Thread via GitHub
codecov-commenter commented on PR #2161: URL: https://github.com/apache/groovy/pull/2161#issuecomment-2745977878 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2161?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] spike to test build for asm 9.8 [groovy]

2025-03-22 Thread via GitHub
paulk-asert opened a new pull request, #2161: URL: https://github.com/apache/groovy/pull/2161 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] remove excess manifest attributes [groovy]

2025-03-23 Thread via GitHub
codecov-commenter commented on PR #2154: URL: https://github.com/apache/groovy/pull/2154#issuecomment-2746652548 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2154?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] remove excess manifest attributes [groovy]

2025-03-24 Thread via GitHub
eric-milles commented on PR #2154: URL: https://github.com/apache/groovy/pull/2154#issuecomment-2741611974 I have rebased, added comments to the `Eclipse-ExtensibleAPI` line, and moved `DynamicImport-Package` and `Eclipse-BuddyPolicy` to main jar only. I should be able to dig up a jira tic

Re: [PR] GROOVY-11568: try `invokeMethod(Class,Object,Object[],boolean,boolean)` [groovy]

2025-03-23 Thread via GitHub
codecov-commenter commented on PR #2158: URL: https://github.com/apache/groovy/pull/2158#issuecomment-2746628756 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2158?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11568: try `invokeMethod(Class,Object,Object[],boolean,boolean)` [groovy]

2025-03-29 Thread via GitHub
daniellansun merged PR #2158: URL: https://github.com/apache/groovy/pull/2158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11586: Provide an injectAll DGM method [groovy]

2025-03-29 Thread via GitHub
daniellansun commented on PR #2166: URL: https://github.com/apache/groovy/pull/2166#issuecomment-2763245775 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-9742: GroovyClassLoader.parseClass() StampedCommonCache.getAndPut() hang [groovy]

2025-03-29 Thread via GitHub
codecov-commenter commented on PR #2168: URL: https://github.com/apache/groovy/pull/2168#issuecomment-2763568264 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2168?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-4721: variable declared in try block is in scope in finally block [groovy]

2025-04-02 Thread via GitHub
codecov-commenter commented on PR #2172: URL: https://github.com/apache/groovy/pull/2172#issuecomment-2773198131 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] Update SDKMAN install URL [groovy]

2025-04-02 Thread via GitHub
daniellansun merged PR #2171: URL: https://github.com/apache/groovy/pull/2171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11586: Provide an injectAll DGM method [groovy]

2025-03-27 Thread via GitHub
codecov-commenter commented on PR #2166: URL: https://github.com/apache/groovy/pull/2166#issuecomment-2757828262 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2166?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] Update SDKMAN install URL [groovy]

2025-04-02 Thread via GitHub
codecov-commenter commented on PR #2171: URL: https://github.com/apache/groovy/pull/2171#issuecomment-2772318432 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2171?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-10683: support `for (index, item in list)` looping [groovy]

2025-04-02 Thread via GitHub
daniellansun commented on PR #2169: URL: https://github.com/apache/groovy/pull/2169#issuecomment-2773277262 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] GROOVY-11601: remove support for expression list in `for`-each statement [groovy]

2025-04-04 Thread via GitHub
eric-milles opened a new pull request, #2174: URL: https://github.com/apache/groovy/pull/2174 https://issues.apache.org/jira/browse/GROOVY-11601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] GROOVY-11597: STC: loop over enum class [groovy]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #2175: URL: https://github.com/apache/groovy/pull/2175#issuecomment-2779796432 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2175?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] GROOVY-11597: STC: loop over enum class [groovy]

2025-04-04 Thread via GitHub
eric-milles opened a new pull request, #2175: URL: https://github.com/apache/groovy/pull/2175 `for` loop item type for `Class` is `EnumType` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] GROOVY-11601: remove support for expression list in `for`-each statement [groovy]

2025-04-04 Thread via GitHub
codecov-commenter commented on PR #2174: URL: https://github.com/apache/groovy/pull/2174#issuecomment-2779715333 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2174?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-7439: add test case [groovy]

2025-05-07 Thread via GitHub
eric-milles merged PR #2217: URL: https://github.com/apache/groovy/pull/2217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11655: Create extension method to make StringBuilder like a stack [groovy]

2025-05-07 Thread via GitHub
eric-milles commented on PR #2215: URL: https://github.com/apache/groovy/pull/2215#issuecomment-2858852984 I don't think there is much general value in providing "stack of chars" semantic. You can always provide these for your own projects through extension or categroy class. -- This is

Re: [PR] GROOVY-7439: add test case [groovy]

2025-05-07 Thread via GitHub
codecov-commenter commented on PR #2217: URL: https://github.com/apache/groovy/pull/2217#issuecomment-2858885581 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2217?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11655: Create extension method to make StringBuilder like a stack [groovy]

2025-05-10 Thread via GitHub
paulk-asert commented on code in PR #2215: URL: https://github.com/apache/groovy/pull/2215#discussion_r2083133787 ## src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java: ## @@ -1877,6 +1878,77 @@ public static StringBuilder leftShift(final StringBuilder self, fin

Re: [PR] GROOVY-11616: STC: combine multiple type witnesses for type parameter [groovy]

2025-05-08 Thread via GitHub
codecov-commenter commented on PR #2219: URL: https://github.com/apache/groovy/pull/2219#issuecomment-2863685655 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2219?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11641: roll back [groovy]

2025-05-07 Thread via GitHub
codecov-commenter commented on PR #2218: URL: https://github.com/apache/groovy/pull/2218#issuecomment-2859978588 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2218?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11656: Create SGM#getLength methods for StringBuilder/StringBu… [groovy]

2025-05-07 Thread via GitHub
paulk-asert merged PR #2216: URL: https://github.com/apache/groovy/pull/2216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11653: Create DGM#sort(List) and AGM#sort(T[]) variants that t… [groovy]

2025-05-07 Thread via GitHub
paulk-asert merged PR #2213: URL: https://github.com/apache/groovy/pull/2213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11654: Create AGM#putAt variants [groovy]

2025-05-07 Thread via GitHub
paulk-asert merged PR #2214: URL: https://github.com/apache/groovy/pull/2214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11616: STC: combine multiple type witnesses for type parameter [groovy]

2025-05-12 Thread via GitHub
eric-milles merged PR #2219: URL: https://github.com/apache/groovy/pull/2219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-7439: allow logging transform on trait class [groovy]

2025-05-12 Thread via GitHub
eric-milles merged PR #2220: URL: https://github.com/apache/groovy/pull/2220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11641: roll back [groovy]

2025-05-08 Thread via GitHub
eric-milles merged PR #2218: URL: https://github.com/apache/groovy/pull/2218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11601: remove support for expression list in `for`-each statement [groovy]

2025-05-08 Thread via GitHub
eric-milles closed pull request #2174: GROOVY-11601: remove support for expression list in `for`-each statement URL: https://github.com/apache/groovy/pull/2174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] GROOVY-7439: allow logging transform on trait class [groovy]

2025-05-09 Thread via GitHub
codecov-commenter commented on PR #2220: URL: https://github.com/apache/groovy/pull/2220#issuecomment-2866973382 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2220?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-11656: Create SGM#getLength methods for StringBuilder/StringBu… [groovy]

2025-05-06 Thread via GitHub
codecov-commenter commented on PR #2216: URL: https://github.com/apache/groovy/pull/2216#issuecomment-2856787787 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2216?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

<    7   8   9   10   11   12   13   14   15   >