paulk-asert commented on PR #2182:
URL: https://github.com/apache/groovy/pull/2182#issuecomment-2821128192
This PR has been updated with an alternative suggestion. Instead of eager &
lazy/iterator variants being:
```
List collect(Iterator)
Iterator collectLazy(Iterator)
```
daniellansun commented on PR #2197:
URL: https://github.com/apache/groovy/pull/2197#issuecomment-2810750826
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
eric-milles merged PR #2197:
URL: https://github.com/apache/groovy/pull/2197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on PR #2199:
URL: https://github.com/apache/groovy/pull/2199#issuecomment-2816547275
If switch expression closure delegates to the enum class, switch expression
and switch statement will be different. As a result, it's hard for users to
understand if they do not know
daniellansun merged PR #2198:
URL: https://github.com/apache/groovy/pull/2198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2198:
URL: https://github.com/apache/groovy/pull/2198#issuecomment-2816881639
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eric-milles commented on PR #2199:
URL: https://github.com/apache/groovy/pull/2199#issuecomment-2817232959
They are already different. Switch statement supports unqualified enum
constants under STC. Switch expression does not. The expression case could be
made to work with delegation, in
codeconsole commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-2822450676
@daniellansun what exactly is breaking?
This commit brings consistency to existing legacy imports
https://groovy.apache.org/blog/groovy-dates-and-times-cheat
--
paulk-asert closed pull request #2207: Bump com.gradle.develocity from 3.19.2
to 4.0.1
URL: https://github.com/apache/groovy/pull/2207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
paulk-asert commented on PR #2207:
URL: https://github.com/apache/groovy/pull/2207#issuecomment-2834077405
ASF develocity server is still on 2024.3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] commented on PR #2207:
URL: https://github.com/apache/groovy/pull/2207#issuecomment-2834077496
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
paulk-asert merged PR #2204:
URL: https://github.com/apache/groovy/pull/2204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
codecov-commenter commented on PR #2206:
URL: https://github.com/apache/groovy/pull/2206#issuecomment-2833698831
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2206?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2206:
URL: https://github.com/apache/groovy/pull/2206#issuecomment-2836878815
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
paulk-asert commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-2822890969
In general, it is domain classes that have the same name as the java.time
classes and no package that catch us out.
E.g. for a `Main.groovy` file containing `println Period.ZERO`
eric-milles merged PR #2201:
URL: https://github.com/apache/groovy/pull/2201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on PR #2195:
URL: https://github.com/apache/groovy/pull/2195#issuecomment-2832192091
FYI.
Gradle 8.14 is available:
https://docs.gradle.org/current/release-notes.html
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
paulk-asert commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-2832009463
@codeconsole I agree this would be nice to have. We just have to weigh up
all pros and cons. We treat breaking existing code seriously and such changes
proceed more slowly due to the e
paulk-asert closed pull request #2184: GROOVY-11606: Lazy findAll, collect,
collectMany (alternative proposa…
URL: https://github.com/apache/groovy/pull/2184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
blackdrag commented on PR #2186:
URL: https://github.com/apache/groovy/pull/2186#issuecomment-2833356349
@daniellansun I think that if the logic tries to find duplicates, then
because those three caches are not utilized properly.
--
This is an automated message from the Apache Git Service
daniellansun commented on PR #2205:
URL: https://github.com/apache/groovy/pull/2205#issuecomment-2833570632
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
paulk-asert merged PR #2208:
URL: https://github.com/apache/groovy/pull/2208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
codecov-commenter commented on PR #2208:
URL: https://github.com/apache/groovy/pull/2208#issuecomment-2840642508
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2208?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert opened a new pull request, #2209:
URL: https://github.com/apache/groovy/pull/2209
…hods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov-commenter commented on PR #2209:
URL: https://github.com/apache/groovy/pull/2209#issuecomment-2844073448
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2209?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert merged PR #2209:
URL: https://github.com/apache/groovy/pull/2209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #2182:
URL: https://github.com/apache/groovy/pull/2182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on PR #2195:
URL: https://github.com/apache/groovy/pull/2195#issuecomment-2843767956
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2195:
URL: https://github.com/apache/groovy/pull/2195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #2183:
URL: https://github.com/apache/groovy/pull/2183#issuecomment-2794936721
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2183?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2184:
URL: https://github.com/apache/groovy/pull/2184#issuecomment-2795915648
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2184?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
dependabot[bot] opened a new pull request, #2191:
URL: https://github.com/apache/groovy/pull/2191
Bumps commons-io:commons-io from 2.18.0 to 2.19.0.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-io:com
codecov-commenter commented on PR #2193:
URL: https://github.com/apache/groovy/pull/2193#issuecomment-2800594292
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2193?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2192:
URL: https://github.com/apache/groovy/pull/2192#issuecomment-2800332333
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2192?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert commented on PR #2182:
URL: https://github.com/apache/groovy/pull/2182#issuecomment-2799053479
The Smalltalk semantics for "collect" is transform. Think: I have an
aggregate of People and I'll produce an aggregate of Names by "collect"ing each
person's name. The "into a collecti
Copilot commented on code in PR #2186:
URL: https://github.com/apache/groovy/pull/2186#discussion_r2040634434
##
src/main/java/org/codehaus/groovy/classgen/VariableScopeVisitor.java:
##
@@ -760,4 +780,66 @@ public void visitVariableExpression(final
VariableExpression expression
codecov-commenter commented on PR #2186:
URL: https://github.com/apache/groovy/pull/2186#issuecomment-2798789566
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2186?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
Copilot commented on code in PR #2186:
URL: https://github.com/apache/groovy/pull/2186#discussion_r2040641694
##
src/main/java/org/codehaus/groovy/classgen/VariableScopeVisitor.java:
##
@@ -192,113 +195,130 @@ private void declare(final Variable variable, final
ASTNode context)
codecov-commenter commented on PR #2187:
URL: https://github.com/apache/groovy/pull/2187#issuecomment-2798897074
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2187?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles merged PR #2192:
URL: https://github.com/apache/groovy/pull/2192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles opened a new pull request, #2197:
URL: https://github.com/apache/groovy/pull/2197
Special checks for `putAt` lack `null` handling. Adding
"isNullConstant(enclosingExpressionRHS) ? UNKNOWN_PARAMETER_TYPE :" to
`getType` would expose to all STC users/scripts.
--
This is an aut
paulk-asert commented on PR #2196:
URL: https://github.com/apache/groovy/pull/2196#issuecomment-2808107196
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
paulk-asert merged PR #2196:
URL: https://github.com/apache/groovy/pull/2196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
codecov-commenter commented on PR #2197:
URL: https://github.com/apache/groovy/pull/2197#issuecomment-2810018087
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2197?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles opened a new pull request, #2198:
URL: https://github.com/apache/groovy/pull/2198
```groovy
String[] foo() {
['a','b','c' ]
}
```
and
```groovy
@interface A {
String[] value() default []
}
```
--
This is an automated message from the Apache G
dependabot[bot] commented on PR #2181:
URL: https://github.com/apache/groovy/pull/2181#issuecomment-2810755280
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
dependabot[bot] closed pull request #2191: Bump commons-io:commons-io from
2.18.0 to 2.19.0
URL: https://github.com/apache/groovy/pull/2191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dependabot[bot] commented on PR #2191:
URL: https://github.com/apache/groovy/pull/2191#issuecomment-2801340264
Looks like commons-io:commons-io is up-to-date now, so this is no longer
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
eric-milles opened a new pull request, #2192:
URL: https://github.com/apache/groovy/pull/2192
```groovy
class A {
String value() { 'A' }
}
class B extends A {
String value() { 'B' }
/*non-static*/ class C {
def m() {
B.super.value() // this$0 super call
eric-milles commented on PR #2199:
URL: https://github.com/apache/groovy/pull/2199#issuecomment-2812884480
Can you explain the design of this one? I don't quite follow. I think this
plays into the reason we limited the previous fix to STC.
--
This is an automated message from the Apache
codecov-commenter commented on PR #2198:
URL: https://github.com/apache/groovy/pull/2198#issuecomment-2810774461
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2198?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun closed pull request #2181: Bump com.gradle.develocity from 3.19.2
to 4.0
URL: https://github.com/apache/groovy/pull/2181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
paulk-asert opened a new pull request, #2213:
URL: https://github.com/apache/groovy/pull/2213
…ake an IntRange
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
codecov-commenter commented on PR #2213:
URL: https://github.com/apache/groovy/pull/2213#issuecomment-2853322734
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2213?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
dongwq commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2851503770
> Also, was there anything in particular you used from `AbstractList`.
Wondering why not to use the more general `List` interface?
cause partition_point is O(logn), suppose that elem
dongwq commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2851508067
> I actually think i prefer just `partitionPoint` to match Rust and C++, but
let me put my thoughts into
[GROOVY-11649](https://issues.apache.org/jira/browse/GROOVY-11649) because I am
not
dongwq commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2851517853
what about the usage, my q: why rust vec.partition_point is useful if there
is binary_search already?
and copilot give below:
Let me help you understand the difference between `par
daniellansun merged PR #2206:
URL: https://github.com/apache/groovy/pull/2206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2206:
URL: https://github.com/apache/groovy/pull/2206#issuecomment-2843318843
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2850581038
I actually think i prefer just `partitionPoint` to match Rust and C++, but
let me put my thoughts into GROOVY-11649 because I am not sure all of the
variants are equally compelling.
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2850587016
Also, was there anything in particular you used from `AbstractList`.
Wondering why not to use the more general `List` interface.
--
This is an automated message from the Apache Git S
codecov-commenter commented on PR #2211:
URL: https://github.com/apache/groovy/pull/2211#issuecomment-2849276591
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2211?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2211:
URL: https://github.com/apache/groovy/pull/2211#issuecomment-2849336302
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Copilot commented on code in PR #2211:
URL: https://github.com/apache/groovy/pull/2211#discussion_r2072671610
##
src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java:
##
@@ -1581,7 +1581,7 @@ public Void visitMemberDeclaration(final
MemberDeclarationContext ctx) {
daniellansun commented on PR #2212:
URL: https://github.com/apache/groovy/pull/2212#issuecomment-2849336900
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
eric-milles commented on PR #2211:
URL: https://github.com/apache/groovy/pull/2211#issuecomment-2849266564
I checked field, method and compact constructor. The first two already
include annotations and modifiers in their source offset and the compact
constructor is mapped to a closure in t
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2852386998
I was thinking a bit more about usage overnight.
For arrays, the "clean insertion" point argument is less compelling but
somewhat useful none-the-less.
Given that it isn't
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2852415381
Can you rename back to partitionPoint, and use List instead of AbstractList.
I am still pondering the benefits of Predicate vs Closure for the DGM List and
AGM T[] variants. Did you ma
dongwq commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2852847257
> Can you rename back to partitionPoint, and use List instead of
AbstractList. I am still pondering the benefits of Predicate vs Closure for the
DGM List and AGM T[] variants. Did you make
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2852852315
I am not sure if "prefer Predicate to Closure" is correct yet. I think
that will be the case for primitive arrays, still thinking about List and T[].
It might be best to align those wi
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2852406946
> > Also, was there anything in particular you used from `AbstractList`.
Wondering why not to use the more general `List` interface?
>
> cause partition_point is O(logn), suppose
paulk-asert merged PR #2210:
URL: https://github.com/apache/groovy/pull/2210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2852950283
Predicate looks fine in all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2852952166
Merged! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
paulk-asert commented on PR #2210:
URL: https://github.com/apache/groovy/pull/2210#issuecomment-2852956042
Apologies, I meant to squash when merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
eric-milles merged PR #2211:
URL: https://github.com/apache/groovy/pull/2211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert opened a new pull request, #2214:
URL: https://github.com/apache/groovy/pull/2214
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #2214:
URL: https://github.com/apache/groovy/pull/2214#issuecomment-2854406649
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2214?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2214:
URL: https://github.com/apache/groovy/pull/2214#issuecomment-2854667681
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun commented on PR #2213:
URL: https://github.com/apache/groovy/pull/2213#issuecomment-2854674249
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
Copilot commented on code in PR #2214:
URL: https://github.com/apache/groovy/pull/2214#discussion_r2075538165
##
src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java:
##
@@ -7260,6 +7260,405 @@ public static T[] plus(T[] left, Object right) {
return result
codecov-commenter commented on PR #2215:
URL: https://github.com/apache/groovy/pull/2215#issuecomment-2855268053
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2215?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2204:
URL: https://github.com/apache/groovy/pull/2204#issuecomment-2826464638
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2204?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codeconsole commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-2825914773
Well, I have found, as is, unintentionally encourages deprecated behavior in
domain classes due to the added complexity of having to add imports in view
layers. Even in standalone appl
codecov-commenter commented on PR #2195:
URL: https://github.com/apache/groovy/pull/2195#issuecomment-2828916714
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2195?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles commented on PR #2204:
URL: https://github.com/apache/groovy/pull/2204#issuecomment-2831078819
@blackdrag raised concern that `charAt` should probably be code point at.
And is there a next code point method? Any concern about invalid/unmapped code
points?
--
This is an aut
paulk-asert commented on PR #2204:
URL: https://github.com/apache/groovy/pull/2204#issuecomment-2831521205
I commented in the issue. I was following the code from next()/previous().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
eric-milles merged PR #2190:
URL: https://github.com/apache/groovy/pull/2190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles commented on PR #2186:
URL: https://github.com/apache/groovy/pull/2186#issuecomment-2798851375
Do you have something to measure the performance difference? We have
nothing to weigh the complexity of the changes against.
Even if complex, it is compile-time behavior. I wou
daniellansun commented on PR #2194:
URL: https://github.com/apache/groovy/pull/2194#issuecomment-2804667623
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
blackdrag commented on PR #2186:
URL: https://github.com/apache/groovy/pull/2186#issuecomment-2799567259
@daniellansun there are already 3 maps/caches in VariableScope. Why are
those no good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
paulk-asert opened a new pull request, #2188:
URL: https://github.com/apache/groovy/pull/2188
…Put() hang (provide constructor to enable alternative sourceCaches to be
set)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
daniellansun commented on PR #2188:
URL: https://github.com/apache/groovy/pull/2188#issuecomment-2799732499
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
codecov-commenter commented on PR #2188:
URL: https://github.com/apache/groovy/pull/2188#issuecomment-2799752158
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2188?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun merged PR #2188:
URL: https://github.com/apache/groovy/pull/2188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2188:
URL: https://github.com/apache/groovy/pull/2188#issuecomment-2799833752
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dufucun opened a new pull request, #2196:
URL: https://github.com/apache/groovy/pull/2196
remove duplicate words in comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on PR #2189:
URL: https://github.com/apache/groovy/pull/2189#issuecomment-2804783264
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
paulk-asert commented on PR #2195:
URL: https://github.com/apache/groovy/pull/2195#issuecomment-2807674495
I am -0 for this change just now. I think it is good (so great to have this
branch) to test that we can move to 8.14 when it comes out but I'd prefer to
wait until we are on the final
dependabot[bot] opened a new pull request, #2207:
URL: https://github.com/apache/groovy/pull/2207
Bumps com.gradle.develocity from 3.19.2 to 4.0.1.
[