[jira] [Created] (GROOVY-11651) Bump antlr to 4.13.2.7

2025-05-04 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-11651: --- Summary: Bump antlr to 4.13.2.7 Key: GROOVY-11651 URL: https://issues.apache.org/jira/browse/GROOVY-11651 Project: Groovy Issue Type: Dependency upgrade

[jira] [Commented] (GROOVY-11650) Create drain extension method for Queues

2025-05-04 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949354#comment-17949354 ] Paul King commented on GROOVY-11650: {quote}If you create an iterator extension met

Re: [PR] GROOVY-11642: include annotations and modifiers in inner class offset [groovy]

2025-05-04 Thread via GitHub
codecov-commenter commented on PR #2211: URL: https://github.com/apache/groovy/pull/2211#issuecomment-2849276591 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2211?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[jira] [Commented] (GROOVY-11642) source offset of inner class declaration with annotation

2025-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949294#comment-17949294 ] ASF GitHub Bot commented on GROOVY-11642: - codecov-commenter commented on PR #2

[jira] [Commented] (GROOVY-11642) source offset of inner class declaration with annotation

2025-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949308#comment-17949308 ] ASF GitHub Bot commented on GROOVY-11642: - Copilot commented on code in PR #221

Re: [PR] GROOVY-11642: include annotations and modifiers in inner class offset [groovy]

2025-05-04 Thread via GitHub
daniellansun commented on PR #2211: URL: https://github.com/apache/groovy/pull/2211#issuecomment-2849336302 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[jira] [Commented] (GROOVY-11642) source offset of inner class declaration with annotation

2025-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949309#comment-17949309 ] ASF GitHub Bot commented on GROOVY-11642: - daniellansun commented on PR #2211:

Re: [PR] GROOVY-11642: include annotations and modifiers in inner class offset [groovy]

2025-05-04 Thread via GitHub
Copilot commented on code in PR #2211: URL: https://github.com/apache/groovy/pull/2211#discussion_r2072671610 ## src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java: ## @@ -1581,7 +1581,7 @@ public Void visitMemberDeclaration(final MemberDeclarationContext ctx) {

Re: [PR] GROOVY-11650: Create drain extension method for Queues [groovy]

2025-05-04 Thread via GitHub
daniellansun commented on PR #2212: URL: https://github.com/apache/groovy/pull/2212#issuecomment-2849336900 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[jira] [Commented] (GROOVY-11650) Create drain extension method for Queues

2025-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949310#comment-17949310 ] ASF GitHub Bot commented on GROOVY-11650: - daniellansun commented on PR #2212:

[jira] [Created] (GROOVY-11652) Bump spotbugs to 4.9.3

2025-05-04 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-11652: --- Summary: Bump spotbugs to 4.9.3 Key: GROOVY-11652 URL: https://issues.apache.org/jira/browse/GROOVY-11652 Project: Groovy Issue Type: Dependency upgrade

[jira] [Commented] (GROOVY-11650) Create drain extension method for Queues

2025-05-04 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949287#comment-17949287 ] Eric Milles commented on GROOVY-11650: -- If you create an iterator extension method

[jira] [Commented] (GROOVY-11648) Make methods in groovy-core friendly to JIT

2025-05-04 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949288#comment-17949288 ] Eric Milles commented on GROOVY-11648: -- If your candidate list is a few hundred it

[jira] [Commented] (GROOVY-11648) Make methods in groovy-core friendly to JIT

2025-05-04 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949289#comment-17949289 ] Eric Milles commented on GROOVY-11648: -- I’m not opposed to this effort (or many of

[jira] [Commented] (GROOVY-11640) GC pause by Metadata GC Threshold for weeks then turned to Full GC

2025-05-04 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949290#comment-17949290 ] Eric Milles commented on GROOVY-11640: -- I do not interpret what was said so far as

[jira] [Assigned] (GROOVY-11627) Compile Error when private and public functions use same name in compile static mode

2025-05-04 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-11627: Assignee: Eric Milles > Compile Error when private and public functions use same name in

[jira] [Closed] (GROOVY-11652) Bump spotbugs to 4.9.3

2025-05-04 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun closed GROOVY-11652. --- Fix Version/s: 5.0.0-alpha-13 Assignee: Daniel Sun Resolution: Fixed > Bump spotbug

Re: [PR] GROOVY-11642: include annotations and modifiers in inner class offset [groovy]

2025-05-04 Thread via GitHub
eric-milles commented on PR #2211: URL: https://github.com/apache/groovy/pull/2211#issuecomment-2849266564 I checked field, method and compact constructor. The first two already include annotations and modifiers in their source offset and the compact constructor is mapped to a closure in t

[jira] [Commented] (GROOVY-11642) source offset of inner class declaration with annotation

2025-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949291#comment-17949291 ] ASF GitHub Bot commented on GROOVY-11642: - eric-milles commented on PR #2211: U

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-04 Thread via GitHub
dongwq commented on PR #2210: URL: https://github.com/apache/groovy/pull/2210#issuecomment-2849075039 > This is an interesting proposal. > > One immediate point of feedback is I would change the IntRange semantics to follow normal Groovy idioms. I know that means it might be slightly

Re: [PR] add partitionPoint to Groovy Array and List(missed in java and groovy) [groovy]

2025-05-04 Thread via GitHub
dongwq commented on code in PR #2210: URL: https://github.com/apache/groovy/pull/2210#discussion_r2072551816 ## src/main/java/org/codehaus/groovy/runtime/ArrayGroovyMethods.java: ## @@ -6576,6 +6579,528 @@ public static T[] minus(T[] self, Object removeMe) { return res