paulk-asert commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3092607872
Looks like I accidentally left some debugging code in play. I'll redo the
release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
eric-milles commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3092561266
When I first ran groovysh, it created `/.groovy/aliases.json` as an
empty file. Then it went to slurp this in and failed with an exception that it
cannot parse empty string as JSON.
matrei commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092501587
> Don't the name-value pairs come in source order? I would not want them
sorted to another order besides that.
It does not seem so as the order appears to differ from one build to an
eric-milles commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092475283
Don't the name-value pairs come in source order? I would not want them
sorted to another order besides that.
--
This is an automated message from the Apache Git Service.
To respond
matrei commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092237938
> AST transformation can add annotations, so I do not think parser is an
ideal place to fix the issue.
Aha, good point.
Is there also a reproducibility issue with annotations added
codecov-commenter commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092217471
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2268?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092212821
AST transformation can add annotations, so I do not think parser is an ideal
place to fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the m
matrei opened a new pull request, #2268:
URL: https://github.com/apache/groovy/pull/2268
Sort element value pairs by key before collecting them into a
`LinkedHashMap` to ensure consistent iteration order across builds.
This change addresses GROOVY-11715 without requiring `TreeMap` usa
paulk-asert commented on code in PR #2267:
URL: https://github.com/apache/groovy/pull/2267#discussion_r2217024543
##
src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java:
##
@@ -2221,10 +,11 @@ private AnnotationVisitor getAnnotationVisitor(final
AnnotatedNode
paulk-asert commented on PR #2265:
URL: https://github.com/apache/groovy/pull/2265#issuecomment-3091219026
@dependabot close
Not compatible with the currently installed ge at apache:
https://docs.gradle.com/enterprise/compatibility/#develocity_compatibility
--
This is an automate
dependabot[bot] closed pull request #2265: Bump com.gradle.develocity from
4.0.2 to 4.1
URL: https://github.com/apache/groovy/pull/2265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
matrei commented on code in PR #2267:
URL: https://github.com/apache/groovy/pull/2267#discussion_r2217020381
##
src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java:
##
@@ -2221,10 +,11 @@ private AnnotationVisitor getAnnotationVisitor(final
AnnotatedNode targe
Copilot commented on code in PR #1767:
URL: https://github.com/apache/groovy/pull/1767#discussion_r2216334564
##
src/main/java/groovy/lang/MetaClassImpl.java:
##
@@ -2089,10 +2091,25 @@ public void setProperty(final Object object, final
Object newValue) {
* Object#getClas
eric-milles commented on PR #2265:
URL: https://github.com/apache/groovy/pull/2265#issuecomment-3089844510
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eric-milles commented on PR #2266:
URL: https://github.com/apache/groovy/pull/2266#issuecomment-3089814738
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eric-milles merged PR #2264:
URL: https://github.com/apache/groovy/pull/2264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun merged PR #2267:
URL: https://github.com/apache/groovy/pull/2267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2267:
URL: https://github.com/apache/groovy/pull/2267#issuecomment-3089241974
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on PR #2267:
URL: https://github.com/apache/groovy/pull/2267#issuecomment-3086021765
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
jdaugherty commented on PR #2267:
URL: https://github.com/apache/groovy/pull/2267#issuecomment-3084381682
Thank you @paulk-asert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
codecov-commenter commented on PR #2267:
URL: https://github.com/apache/groovy/pull/2267#issuecomment-3084216370
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2267?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert opened a new pull request, #2267:
URL: https://github.com/apache/groovy/pull/2267
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #1767:
URL: https://github.com/apache/groovy/pull/1767#issuecomment-3080393307
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/1767?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #1904:
URL: https://github.com/apache/groovy/pull/1904#issuecomment-3078864553
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/1904?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles merged PR #1904:
URL: https://github.com/apache/groovy/pull/1904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2266:
URL: https://github.com/apache/groovy/pull/2266
Bumps org.apache.maven:maven-core from 3.9.10 to 3.9.11.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apac
dependabot[bot] opened a new pull request, #2265:
URL: https://github.com/apache/groovy/pull/2265
Bumps com.gradle.develocity from 4.0.2 to 4.1.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.develoc
paulk-asert merged PR #2263:
URL: https://github.com/apache/groovy/pull/2263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles merged PR #2154:
URL: https://github.com/apache/groovy/pull/2154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles merged PR #2174:
URL: https://github.com/apache/groovy/pull/2174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles closed pull request #2250: GROOVY-11693: improve specificity of
error message in extension module loading
URL: https://github.com/apache/groovy/pull/2250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
codecov-commenter commented on PR #2264:
URL: https://github.com/apache/groovy/pull/2264#issuecomment-3074656685
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2264?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
Copilot commented on code in PR #2264:
URL: https://github.com/apache/groovy/pull/2264#discussion_r2208118802
##
src/main/java/org/codehaus/groovy/transform/TupleConstructorASTTransformation.java:
##
@@ -285,17 +286,22 @@ private static void createConstructor(final
AbstractASTT
eric-milles opened a new pull request, #2264:
URL: https://github.com/apache/groovy/pull/2264
`@RecordType` should not set `namedVariant=true` when only record component
is a `Map`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3065085437
https://github.com/user-attachments/assets/31c17f82-a125-4826-86a6-99841f92f85b";
/>
Looks better now ;-)
--
This is an automated message from the Apache Git Service.
To resp
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064684229
> > I prefer the original style of output, as it is compact and more readable
> > **current PR:** (a bit verbose, IMHO) https://private-user-images.githubusercontent.com/9151616/4655
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064680893
> > GQ {
> > add: }> from n in [1, 2, 3]
> > add: }> innerjoin m in [2, 3, 4] on m = n
> > add: }> select m, n
> > add: }> }
>
> You currently have to do:
>
paulk-asert commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-306468
> I prefer the original style of output, as it is compact and more readable
>
> **current PR:** (a bit verbose, IMHO) https://private-user-images.githubusercontent.com/9151616/465
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064675791
I prefer the original style of output, as it is compact and more readable
**current PR:** (a bit verbose, IMHO)
https://github.com/user-attachments/assets/610a0235-5e1f-4670-9
paulk-asert commented on code in PR #2263:
URL: https://github.com/apache/groovy/pull/2263#discussion_r2202316790
##
subprojects/groovy-groovysh/src/main/resources/nanorc/groovy.nanorc:
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
paulk-asert commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064674007
> GQ {
> add: }> from n in [1, 2, 3]
> add: }> innerjoin m in [2, 3, 4] on m = n
> add: }> select m, n
> add: }> }
You currently have to do:
println GQ {
daniellansun commented on code in PR #2263:
URL: https://github.com/apache/groovy/pull/2263#discussion_r2202310797
##
subprojects/groovy-groovysh/src/main/resources/nanorc/groovy.nanorc:
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064624433
I like the improvement very much!
It would be great if the result of GINQ in groovySh could be shown as ascii
table as usual.
BTW, `on` is a keyword of GINQ too.
`
Copilot commented on code in PR #2263:
URL: https://github.com/apache/groovy/pull/2263#discussion_r2202289500
##
subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/commands/SystemTestSupport.groovy:
##
@@ -18,35 +18,27 @@
*/
package org.apache.groovy.groov
codecov-commenter commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064556710
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2263?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert opened a new pull request, #2263:
URL: https://github.com/apache/groovy/pull/2263
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
daniellansun commented on PR #2262:
URL: https://github.com/apache/groovy/pull/2262#issuecomment-3062874272
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2262:
URL: https://github.com/apache/groovy/pull/2262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #2262:
URL: https://github.com/apache/groovy/pull/2262#issuecomment-3058431321
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2262?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles opened a new pull request, #2262:
URL: https://github.com/apache/groovy/pull/2262
`ExecutorService` declares `submit(Callable)` and `submit(Runnable)` so add
`submit(Closure)` to prevent routing of closures to the `Runnable` variant,
which drops the return value.
Add chec
daniellansun merged PR #2261:
URL: https://github.com/apache/groovy/pull/2261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2261:
URL: https://github.com/apache/groovy/pull/2261#issuecomment-3058307967
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on PR #2260:
URL: https://github.com/apache/groovy/pull/2260#issuecomment-3055396736
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2260:
URL: https://github.com/apache/groovy/pull/2260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
eric-milles commented on PR #2250:
URL: https://github.com/apache/groovy/pull/2250#issuecomment-3049747033
Is there a test case that can check the message format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
codecov-commenter commented on PR #2261:
URL: https://github.com/apache/groovy/pull/2261#issuecomment-3049516438
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2261?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles opened a new pull request, #2261:
URL: https://github.com/apache/groovy/pull/2261
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #2260:
URL: https://github.com/apache/groovy/pull/2260#issuecomment-3049267038
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2260?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles opened a new pull request, #2260:
URL: https://github.com/apache/groovy/pull/2260
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #2255:
URL: https://github.com/apache/groovy/pull/2255#issuecomment-3038836778
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2255?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on PR #2259:
URL: https://github.com/apache/groovy/pull/2259#issuecomment-3036619563
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2259:
URL: https://github.com/apache/groovy/pull/2259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #2259:
URL: https://github.com/apache/groovy/pull/2259#issuecomment-3019587240
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2259?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
perNyfelt opened a new pull request, #2259:
URL: https://github.com/apache/groovy/pull/2259
The ManagedConcurrentMap and its base class AbstractConcurrentMapBase were
removed in Groovy 4.x as part of internal cleanup.
This patch removes the corresponding ManagedConcurrentMapStressTest
daniellansun commented on PR #2258:
URL: https://github.com/apache/groovy/pull/2258#issuecomment-3015994714
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2258:
URL: https://github.com/apache/groovy/pull/2258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #2258:
URL: https://github.com/apache/groovy/pull/2258#issuecomment-3005054799
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2258?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles opened a new pull request, #2258:
URL: https://github.com/apache/groovy/pull/2258
`IntRange` is `List`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
daniellansun commented on PR #2257:
URL: https://github.com/apache/groovy/pull/2257#issuecomment-2997328977
I tried to create a simple script to reproduce the issue, but failed either.
Let's tweak the test case in future.
--
This is an automated message from the Apache Git Service.
To res
daniellansun merged PR #2257:
URL: https://github.com/apache/groovy/pull/2257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
eric-milles commented on PR #2257:
URL: https://github.com/apache/groovy/pull/2257#issuecomment-2997225886
It would be nice to have a small test case in core for this, but otherwise
looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
codecov-commenter commented on PR #2257:
URL: https://github.com/apache/groovy/pull/2257#issuecomment-2994082156
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2257?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
Copilot commented on code in PR #2257:
URL: https://github.com/apache/groovy/pull/2257#discussion_r2160276495
##
subprojects/groovy-ginq/src/main/groovy/org/apache/groovy/ginq/provider/collection/GinqAstWalker.groovy:
##
@@ -1496,19 +1498,19 @@ class GinqAstWalker implements
Gi
daniellansun opened a new pull request, #2257:
URL: https://github.com/apache/groovy/pull/2257
https://issues.apache.org/jira/browse/GROOVY-11703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
daniellansun commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-2993623522
As most users like the improvement, I'll merge the PR soon.
https://lists.apache.org/thread/pm35433ghyglk03dmlvn3z4o72qd7ynf
--
This is an automated message from the A
daniellansun merged PR #2156:
URL: https://github.com/apache/groovy/pull/2156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
Copilot commented on code in PR #2156:
URL: https://github.com/apache/groovy/pull/2156#discussion_r2160059938
##
src/main/java/org/codehaus/groovy/control/ResolveVisitor.java:
##
@@ -95,9 +95,9 @@
*/
public class ResolveVisitor extends ClassCodeExpressionTransformer {
//
daniellansun merged PR #2255:
URL: https://github.com/apache/groovy/pull/2255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2255:
URL: https://github.com/apache/groovy/pull/2255#issuecomment-2993349835
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
paulk-asert closed pull request #2256: Tuple changes related to its backing
array
URL: https://github.com/apache/groovy/pull/2256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
paulk-asert commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986633960
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Choosechee commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986410255
> You might want to squash your PR.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
codecov-commenter commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986083595
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2256?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986047943
I created this issue to track this change:
https://issues.apache.org/jira/browse/GROOVY-11702
--
This is an automated message from the Apache Git Service.
To respond to the message
paulk-asert commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986051227
You might want to squash your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
daniellansun merged PR #2254:
URL: https://github.com/apache/groovy/pull/2254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2254:
URL: https://github.com/apache/groovy/pull/2254#issuecomment-2985985015
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2155691786
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
r
Choosechee opened a new pull request, #2256:
URL: https://github.com/apache/groovy/pull/2256
I have made some changes to `Tuple` that are related to its backing array.
One of them fixes a pretty major bug I found:
- Made `Tuple` implement `RandomAccess`.
- Currently, `Tuple`'s 'toA
eric-milles opened a new pull request, #2255:
URL: https://github.com/apache/groovy/pull/2255
For an expression like `list.stream().collect(Collectors.toSet())` the
return type is dependent on the return type of `toSet`, which can be partially
resolved from the receiver type (for example `S
paulk-asert commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2153724057
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
re
paulk-asert commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2153724057
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
re
daniellansun commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2153612481
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
r
Copilot commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2153222725
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
return
daniellansun commented on PR #2254:
URL: https://github.com/apache/groovy/pull/2254#issuecomment-2981925028
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
paulk-asert commented on PR #2247:
URL: https://github.com/apache/groovy/pull/2247#issuecomment-2979857110
I tweaked the javadoc to better describe the intent of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
paulk-asert merged PR #2247:
URL: https://github.com/apache/groovy/pull/2247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
codecov-commenter commented on PR #2254:
URL: https://github.com/apache/groovy/pull/2254#issuecomment-2975592770
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2254?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert opened a new pull request, #2254:
URL: https://github.com/apache/groovy/pull/2254
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
daniellansun commented on PR #2253:
URL: https://github.com/apache/groovy/pull/2253#issuecomment-2972012384
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
1 - 100 of 1410 matches
Mail list logo
