Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
daniellansun commented on PR #2263: URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064684229 > > I prefer the original style of output, as it is compact and more readable > > **current PR:** (a bit verbose, IMHO) https://private-user-images.githubusercontent.com/9151616/4655

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
daniellansun commented on PR #2263: URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064680893 > > GQ { > > add: }> from n in [1, 2, 3] > > add: }> innerjoin m in [2, 3, 4] on m = n > > add: }> select m, n > > add: }> } > > You currently have to do: >

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
paulk-asert commented on PR #2263: URL: https://github.com/apache/groovy/pull/2263#issuecomment-306468 > I prefer the original style of output, as it is compact and more readable > > **current PR:** (a bit verbose, IMHO) https://private-user-images.githubusercontent.com/9151616/465

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
daniellansun commented on PR #2263: URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064675791 I prefer the original style of output, as it is compact and more readable **current PR:** (a bit verbose, IMHO) https://github.com/user-attachments/assets/610a0235-5e1f-4670-9

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
paulk-asert commented on code in PR #2263: URL: https://github.com/apache/groovy/pull/2263#discussion_r2202316790 ## subprojects/groovy-groovysh/src/main/resources/nanorc/groovy.nanorc: ## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
paulk-asert commented on PR #2263: URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064674007 > GQ { > add: }> from n in [1, 2, 3] > add: }> innerjoin m in [2, 3, 4] on m = n > add: }> select m, n > add: }> } You currently have to do: println GQ {

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
daniellansun commented on code in PR #2263: URL: https://github.com/apache/groovy/pull/2263#discussion_r2202310797 ## subprojects/groovy-groovysh/src/main/resources/nanorc/groovy.nanorc: ## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
daniellansun commented on PR #2263: URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064624433 I like the improvement very much! It would be great if the result of GINQ in groovySh could be shown as ascii table as usual. BTW, `on` is a keyword of GINQ too. `

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
Copilot commented on code in PR #2263: URL: https://github.com/apache/groovy/pull/2263#discussion_r2202289500 ## subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/commands/SystemTestSupport.groovy: ## @@ -18,35 +18,27 @@ */ package org.apache.groovy.groov

Re: [PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
codecov-commenter commented on PR #2263: URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064556710 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2263?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] Jline3 [groovy]

2025-07-11 Thread via GitHub
paulk-asert opened a new pull request, #2263: URL: https://github.com/apache/groovy/pull/2263 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[jira] [Resolved] (GROOVY-11681) Return statement throws a compile error inside a closure

2025-07-11 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-11681. -- Fix Version/s: 5.0.0-beta-2 Resolution: Fixed > Return statement throws a compile erro

[jira] [Commented] (GROOVY-11601) remove support for expression list in for-each statement

2025-07-11 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004769#comment-18004769 ] Daniel Sun commented on GROOVY-11601: - {code:java} package gls.statements import o

[jira] [Commented] (GROOVY-11681) Return statement throws a compile error inside a closure

2025-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004731#comment-18004731 ] ASF GitHub Bot commented on GROOVY-11681: - daniellansun commented on PR #2262:

[jira] [Commented] (GROOVY-11681) Return statement throws a compile error inside a closure

2025-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004730#comment-18004730 ] ASF GitHub Bot commented on GROOVY-11681: - daniellansun merged PR #2262: URL: h

Re: [PR] GROOVY-11681: add `ExecutorService#submit(Closure)` extension [groovy]

2025-07-11 Thread via GitHub
daniellansun commented on PR #2262: URL: https://github.com/apache/groovy/pull/2262#issuecomment-3062874272 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-11681: add `ExecutorService#submit(Closure)` extension [groovy]

2025-07-11 Thread via GitHub
daniellansun merged PR #2262: URL: https://github.com/apache/groovy/pull/2262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@