[jira] [Resolved] (GROOVY-11702) Tuple#toArray doesn't honor expected contract for immutability

2025-06-18 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-11702. Fix Version/s: 4.0.28 5.0.0-beta-2 Assignee: Paul King Resoluti

Re: [PR] Tuple changes related to its backing array [groovy]

2025-06-18 Thread via GitHub
paulk-asert closed pull request #2256: Tuple changes related to its backing array URL: https://github.com/apache/groovy/pull/2256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Tuple changes related to its backing array [groovy]

2025-06-18 Thread via GitHub
paulk-asert commented on PR #2256: URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986633960 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Tuple changes related to its backing array [groovy]

2025-06-18 Thread via GitHub
Choosechee commented on PR #2256: URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986410255 > You might want to squash your PR. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Tuple changes related to its backing array [groovy]

2025-06-18 Thread via GitHub
codecov-commenter commented on PR #2256: URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986083595 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2256?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[jira] [Resolved] (GROOVY-11701) Improved named-capturing group support for Groovy matchers

2025-06-18 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-11701. Fix Version/s: 5.0.0-beta-2 Assignee: Paul King Resolution: Fixed Proposed PR mer

Re: [PR] Tuple changes related to its backing array [groovy]

2025-06-18 Thread via GitHub
paulk-asert commented on PR #2256: URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986047943 I created this issue to track this change: https://issues.apache.org/jira/browse/GROOVY-11702 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Tuple changes related to its backing array [groovy]

2025-06-18 Thread via GitHub
paulk-asert commented on PR #2256: URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986051227 You might want to squash your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Created] (GROOVY-11702) Tuple#toArray doesn't honor expected contract for immutability

2025-06-18 Thread Paul King (Jira)
Paul King created GROOVY-11702: -- Summary: Tuple#toArray doesn't honor expected contract for immutability Key: GROOVY-11702 URL: https://issues.apache.org/jira/browse/GROOVY-11702 Project: Groovy

Re: [PR] GROOVY-11701: Improved named-capturing group support for Groovy matchers [groovy]

2025-06-18 Thread via GitHub
daniellansun merged PR #2254: URL: https://github.com/apache/groovy/pull/2254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] GROOVY-11701: Improved named-capturing group support for Groovy matchers [groovy]

2025-06-18 Thread via GitHub
daniellansun commented on PR #2254: URL: https://github.com/apache/groovy/pull/2254#issuecomment-2985985015 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GROOVY-11701: Improved named-capturing group support for Groovy matchers [groovy]

2025-06-18 Thread via GitHub
daniellansun commented on code in PR #2254: URL: https://github.com/apache/groovy/pull/2254#discussion_r2155691786 ## src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java: ## @@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher matcher) { r

[PR] Tuple changes related to its backing array [groovy]

2025-06-18 Thread via GitHub
Choosechee opened a new pull request, #2256: URL: https://github.com/apache/groovy/pull/2256 I have made some changes to `Tuple` that are related to its backing array. One of them fixes a pretty major bug I found: - Made `Tuple` implement `RandomAccess`. - Currently, `Tuple`'s 'toA

[jira] [Commented] (GROOVY-11615) Groovy has trouble type inferencing for Collections. The offender is Collectors.asBlah set of methods. It needs the generic type to be added explicitly

2025-06-18 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17982797#comment-17982797 ] Eric Milles commented on GROOVY-11615: -- https://github.com/apache/groovy/pull/2255

[PR] GRIIVY-11615: STC: receiver type args in param can help with argument [groovy]

2025-06-18 Thread via GitHub
eric-milles opened a new pull request, #2255: URL: https://github.com/apache/groovy/pull/2255 For an expression like `list.stream().collect(Collectors.toSet())` the return type is dependent on the return type of `toSet`, which can be partially resolved from the receiver type (for example `S

Re: [PR] GROOVY-11701: Improved named-capturing group support for Groovy matchers [groovy]

2025-06-18 Thread via GitHub
paulk-asert commented on code in PR #2254: URL: https://github.com/apache/groovy/pull/2254#discussion_r2153724057 ## src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java: ## @@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher matcher) { re