Re: [PR] misc: fix spelling [groovy]

2025-05-26 Thread via GitHub
codecov-commenter commented on PR #2238: URL: https://github.com/apache/groovy/pull/2238#issuecomment-2910838130 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2238?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] misc: fix spelling [groovy]

2025-05-26 Thread via GitHub
jbampton opened a new pull request, #2238: URL: https://github.com/apache/groovy/pull/2238 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] misc(groovy-ginq): fix spelling [groovy]

2025-05-26 Thread via GitHub
paulk-asert commented on PR #2237: URL: https://github.com/apache/groovy/pull/2237#issuecomment-2910805438 Looks good. Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] misc(groovy-ginq): fix spelling [groovy]

2025-05-26 Thread via GitHub
paulk-asert merged PR #2237: URL: https://github.com/apache/groovy/pull/2237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] misc(groovy-ginq): fix spelling [groovy]

2025-05-26 Thread via GitHub
codecov-commenter commented on PR #2237: URL: https://github.com/apache/groovy/pull/2237#issuecomment-2910758083 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2237?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] misc(groovy-ginq): fix spelling [groovy]

2025-05-26 Thread via GitHub
jbampton opened a new pull request, #2237: URL: https://github.com/apache/groovy/pull/2237 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954170#comment-17954170 ] ASF GitHub Bot commented on GROOVY-11680: - daniellansun commented on PR #2235:

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
daniellansun commented on PR #2235: URL: https://github.com/apache/groovy/pull/2235#issuecomment-2910731804 No good deed is too small to do; no evil deed is too small to avoid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954169#comment-17954169 ] ASF GitHub Bot commented on GROOVY-11680: - paulk-asert commented on code in PR

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
paulk-asert commented on code in PR #2235: URL: https://github.com/apache/groovy/pull/2235#discussion_r2107900529 ## src/test/groovy/org/codehaus/groovy/tools/stubgenerator/ClassWithPrimitiveFieldsStubTest.groovy: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954168#comment-17954168 ] ASF GitHub Bot commented on GROOVY-11680: - paulk-asert commented on code in PR

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
paulk-asert commented on code in PR #2235: URL: https://github.com/apache/groovy/pull/2235#discussion_r2107900529 ## src/test/groovy/org/codehaus/groovy/tools/stubgenerator/ClassWithPrimitiveFieldsStubTest.groovy: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] misc(groovy-console): fix spelling [groovy]

2025-05-26 Thread via GitHub
paulk-asert commented on PR #2236: URL: https://github.com/apache/groovy/pull/2236#issuecomment-2910721936 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] misc(groovy-console): fix spelling [groovy]

2025-05-26 Thread via GitHub
paulk-asert closed pull request #2236: misc(groovy-console): fix spelling URL: https://github.com/apache/groovy/pull/2236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
daniellansun commented on code in PR #2235: URL: https://github.com/apache/groovy/pull/2235#discussion_r2107891897 ## src/test/groovy/org/codehaus/groovy/tools/stubgenerator/ClassWithPrimitiveFieldsStubTest.groovy: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Fou

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954165#comment-17954165 ] ASF GitHub Bot commented on GROOVY-11680: - daniellansun commented on code in PR

Re: [PR] misc(groovy-console): fix spelling [groovy]

2025-05-26 Thread via GitHub
jbampton commented on PR #2236: URL: https://github.com/apache/groovy/pull/2236#issuecomment-2910702370 Thanks @paulk-asert I am happy for a merge now. Perhaps you can tweak it after then I can see the format going forwards -- This is an automated message from the Apache Git Servi

Re: [PR] misc(groovy-console): fix spelling [groovy]

2025-05-26 Thread via GitHub
paulk-asert commented on PR #2236: URL: https://github.com/apache/groovy/pull/2236#issuecomment-2910699905 Nice catch. To avoid breaking existing code, we'd keep the old accessor method and mark it as deprecated. Did you want to adjust your PR, or are you happy for us to tweak it after merg

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954162#comment-17954162 ] ASF GitHub Bot commented on GROOVY-11680: - paulk-asert commented on code in PR

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
paulk-asert commented on code in PR #2235: URL: https://github.com/apache/groovy/pull/2235#discussion_r2107875163 ## src/test/groovy/org/codehaus/groovy/tools/stubgenerator/ClassWithPrimitiveFieldsStubTest.groovy: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954161#comment-17954161 ] ASF GitHub Bot commented on GROOVY-11680: - paulk-asert commented on PR #2235: U

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
paulk-asert commented on PR #2235: URL: https://github.com/apache/groovy/pull/2235#issuecomment-2910670526 The Grails build messages are cluttered with many of these: > /Users/paulk/working/grails-core/grails-gradle/model/build/tmp/compileGroovy/groovy-java-stubs/grails/util/BuildSett

Re: [PR] misc(groovy-console): fix spelling [groovy]

2025-05-26 Thread via GitHub
codecov-commenter commented on PR #2236: URL: https://github.com/apache/groovy/pull/2236#issuecomment-2910557140 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2236?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[PR] misc(groovy-console): fix spelling [groovy]

2025-05-26 Thread via GitHub
jbampton opened a new pull request, #2236: URL: https://github.com/apache/groovy/pull/2236 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
eric-milles commented on code in PR #2235: URL: https://github.com/apache/groovy/pull/2235#discussion_r2107780392 ## src/main/java/org/codehaus/groovy/tools/javac/JavaStubGenerator.java: ## @@ -475,8 +476,8 @@ private void printField(final PrintWriter out, final FieldNode field

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954148#comment-17954148 ] ASF GitHub Bot commented on GROOVY-11680: - eric-milles commented on code in PR

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954147#comment-17954147 ] ASF GitHub Bot commented on GROOVY-11680: - eric-milles commented on PR #2235: U

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
eric-milles commented on PR #2235: URL: https://github.com/apache/groovy/pull/2235#issuecomment-2910495445 The constructors are indeed deprecated, but are they scheduled for removal? Was this a concern for someone? As long as you generate something that javac accepts but does not inline,

[jira] [Commented] (GROOVY-11676) Method reference using class name results in bogus error message

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954146#comment-17954146 ] ASF GitHub Bot commented on GROOVY-11676: - eric-milles merged PR #2232: URL: ht

Re: [PR] GROOVY-11676: object expression type in `MethodClosure` error message [groovy]

2025-05-26 Thread via GitHub
eric-milles merged PR #2232: URL: https://github.com/apache/groovy/pull/2232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954144#comment-17954144 ] Eric Milles commented on GROOVY-11680: -- Re: Boolean.FALSE, you want a value that

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954142#comment-17954142 ] Eric Milles commented on GROOVY-11680: -- They use new to prevent inlining. Does val

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954097#comment-17954097 ] ASF GitHub Bot commented on GROOVY-11680: - daniellansun commented on code in PR

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
daniellansun commented on code in PR #2235: URL: https://github.com/apache/groovy/pull/2235#discussion_r2107390948 ## src/test/groovy/org/codehaus/groovy/tools/stubgenerator/ClassWithPrimitiveFieldsStubTest.groovy: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
codecov-commenter commented on PR #2235: URL: https://github.com/apache/groovy/pull/2235#issuecomment-2909293576 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2235?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954071#comment-17954071 ] ASF GitHub Bot commented on GROOVY-11680: - codecov-commenter commented on PR #2

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
paulk-asert commented on PR #2235: URL: https://github.com/apache/groovy/pull/2235#issuecomment-2909288050 @eric-milles I removed the special handling for String constants and it didn't seem to have any negative consequences. I'd be interested in your thoughts since you have done a few rece

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954070#comment-17954070 ] ASF GitHub Bot commented on GROOVY-11680: - paulk-asert commented on PR #2235: U

[jira] [Commented] (GROOVY-11676) Method reference using class name results in bogus error message

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954000#comment-17954000 ] ASF GitHub Bot commented on GROOVY-11676: - sbglasius commented on PR #2232: URL

[jira] [Created] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread Paul King (Jira)
Paul King created GROOVY-11680: -- Summary: Java stubs use deprecated constant constructors in some cases Key: GROOVY-11680 URL: https://issues.apache.org/jira/browse/GROOVY-11680 Project: Groovy

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954064#comment-17954064 ] ASF GitHub Bot commented on GROOVY-11680: - paulk-asert opened a new pull reques

[jira] [Commented] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954065#comment-17954065 ] ASF GitHub Bot commented on GROOVY-11680: - Copilot commented on code in PR #223

Re: [PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
Copilot commented on code in PR #2235: URL: https://github.com/apache/groovy/pull/2235#discussion_r2107024682 ## src/main/java/org/codehaus/groovy/tools/javac/JavaStubGenerator.java: ## @@ -475,8 +476,8 @@ private void printField(final PrintWriter out, final FieldNode field, fi

[PR] GROOVY-11680: Java stubs use deprecated constant constructors in some… [groovy]

2025-05-26 Thread via GitHub
paulk-asert opened a new pull request, #2235: URL: https://github.com/apache/groovy/pull/2235 … cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[jira] [Updated] (GROOVY-11680) Java stubs use deprecated constant constructors in some cases

2025-05-26 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-11680: --- Description: In stub code for static constants in classes, generated code uses the deprecated (from

Re: [PR] GROOVY-11678: Create DGM#subList(IntRange) method [groovy]

2025-05-26 Thread via GitHub
paulk-asert merged PR #2234: URL: https://github.com/apache/groovy/pull/2234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[jira] [Commented] (GROOVY-11578) Services loaded via the service loader not working in (some) OSGi contexts for Groovy 4+

2025-05-26 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954007#comment-17954007 ] Roy Teeuwen commented on GROOVY-11578: -- [~paulk]  which test cases specifically? N