[jira] [Updated] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-11263: Description: Groovy allows dead code after {{throw}}, {{return}}, {{break}} and {{continue}}, e.

[jira] [Commented] (GROOVY-11264) Bump jarjar to 1.13.1

2023-12-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801500#comment-17801500 ] ASF GitHub Bot commented on GROOVY-11264: - daniellansun commented on PR #2024:

Re: [PR] GROOVY-11264: Bump jarjar to 1.13.1 [groovy]

2023-12-31 Thread via GitHub
daniellansun commented on PR #2024: URL: https://github.com/apache/groovy/pull/2024#issuecomment-1873133471 `com.eed3si9n.jarjar.JarJarTask` is missing in jarjar 1.13.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Commented] (GROOVY-11264) Bump jarjar to 1.13.1

2023-12-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801499#comment-17801499 ] ASF GitHub Bot commented on GROOVY-11264: - daniellansun commented on PR #2024:

Re: [PR] GROOVY-11264: Bump jarjar to 1.13.1 [groovy]

2023-12-31 Thread via GitHub
daniellansun commented on PR #2024: URL: https://github.com/apache/groovy/pull/2024#issuecomment-1873127529 Let's check if the latest jarjar still leaves empty META-INF/services files. https://github.com/apache/groovy/blob/80e92ec31a6afe2d8b1260a1452b698fbec9c963/versions.properties#L

[jira] [Commented] (GROOVY-11264) Bump jarjar to 1.13.1

2023-12-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801498#comment-17801498 ] ASF GitHub Bot commented on GROOVY-11264: - daniellansun opened a new pull reque

[jira] [Created] (GROOVY-11264) Bump jarjar to 1.13.1

2023-12-31 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-11264: --- Summary: Bump jarjar to 1.13.1 Key: GROOVY-11264 URL: https://issues.apache.org/jira/browse/GROOVY-11264 Project: Groovy Issue Type: Dependency upgrade

[jira] [Updated] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-11263: Fix Version/s: 5.x > Analyze dead code > - > > Key: GROOVY-11263

[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801496#comment-17801496 ] ASF GitHub Bot commented on GROOVY-11263: - daniellansun commented on code in PR

Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2023-12-31 Thread via GitHub
daniellansun commented on code in PR #2023: URL: https://github.com/apache/groovy/pull/2023#discussion_r1438949628 ## src/main/java/org/codehaus/groovy/classgen/DeadCodeAnalyzer.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801490#comment-17801490 ] ASF GitHub Bot commented on GROOVY-11263: - blackdrag commented on code in PR #2

Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2023-12-31 Thread via GitHub
blackdrag commented on code in PR #2023: URL: https://github.com/apache/groovy/pull/2023#discussion_r1438940188 ## src/main/java/org/codehaus/groovy/classgen/DeadCodeAnalyzer.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801471#comment-17801471 ] ASF GitHub Bot commented on GROOVY-11263: - daniellansun opened a new pull reque

[jira] [Updated] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-11263: Labels: breaking_change (was: ) > Analyze dead code > - > > Key:

[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801469#comment-17801469 ] Daniel Sun commented on GROOVY-11263: - [~blackdrag] We could use the following code

[jira] [Updated] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-11263: Description: Groovy allows dead code after {{return}}, {{break}} and {{continue}}, e.g. {code:ja

[jira] [Commented] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Jochen Theodorou (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801466#comment-17801466 ] Jochen Theodorou commented on GROOVY-11263: --- [~daniel_sun] "It's better to av

[jira] [Created] (GROOVY-11263) Analyze dead code

2023-12-31 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-11263: --- Summary: Analyze dead code Key: GROOVY-11263 URL: https://issues.apache.org/jira/browse/GROOVY-11263 Project: Groovy Issue Type: Improvement Report

[jira] [Commented] (GROOVY-11138) Bump gradle to 8.5

2023-12-31 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801449#comment-17801449 ] Daniel Sun commented on GROOVY-11138: - https://github.com/apache/groovy/commit/6e8b

[jira] (GROOVY-11138) Bump gradle to 8.5

2023-12-31 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11138 ] Daniel Sun deleted comment on GROOVY-11138: - was (Author: daniel_sun): https://github.com/apache/groovy/actions/runs/5701869495/job/15452991059 {code:java} FAILURE: Build failed with an exc

[jira] [Updated] (GROOVY-11138) Bump gradle to 8.5

2023-12-31 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-11138: Summary: Bump gradle to 8.5 (was: Bump gradle to 8.2.1) > Bump gradle to 8.5 > -