[jira] [Commented] (GROOVY-11194) groovyc missing features from the library compiler

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789758#comment-17789758 ] ASF GitHub Bot commented on GROOVY-11194: - keeganwitt merged PR #1992: URL: htt

[jira] [Commented] (GROOVY-11194) groovyc missing features from the library compiler

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789760#comment-17789760 ] ASF GitHub Bot commented on GROOVY-11194: - keeganwitt merged PR #1977: URL: htt

[jira] [Commented] (GROOVY-11194) groovyc missing features from the library compiler

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789759#comment-17789759 ] ASF GitHub Bot commented on GROOVY-11194: - keeganwitt merged PR #1976: URL: htt

Re: [PR] GROOVY-11194 (Groovy 2.5) [groovy]

2023-11-25 Thread via GitHub
keeganwitt merged PR #1977: URL: https://github.com/apache/groovy/pull/1977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@gr

Re: [PR] GROOVY-11194 (Groovy 3.0) [groovy]

2023-11-25 Thread via GitHub
keeganwitt merged PR #1976: URL: https://github.com/apache/groovy/pull/1976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@gr

Re: [PR] GROOVY-11194 (Groovy 4.0) [groovy]

2023-11-25 Thread via GitHub
keeganwitt merged PR #1992: URL: https://github.com/apache/groovy/pull/1992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@gr

Re: [PR] Update GitHub runners [groovy]

2023-11-25 Thread via GitHub
keeganwitt merged PR #1996: URL: https://github.com/apache/groovy/pull/1996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@gr

Re: [PR] Fix Groovy 4.0.x pipeline [groovy]

2023-11-25 Thread via GitHub
keeganwitt merged PR #1995: URL: https://github.com/apache/groovy/pull/1995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@gr

Re: [PR] Fix Groovy 4.0.x pipeline [groovy]

2023-11-25 Thread via GitHub
codecov-commenter commented on PR #1995: URL: https://github.com/apache/groovy/pull/1995#issuecomment-1826461358 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/1995?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Re

[jira] [Commented] (GROOVY-11229) Support pattern matching for `instanceof`

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789727#comment-17789727 ] ASF GitHub Bot commented on GROOVY-11229: - daniellansun commented on PR #1994:

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
daniellansun commented on PR #1994: URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826414813 Closed. I misunderstood the usage of draft pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
daniellansun closed pull request #1994: GROOVY-11229: Support pattern matching for `instanceof` URL: https://github.com/apache/groovy/pull/1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (GROOVY-11229) Support pattern matching for `instanceof`

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789725#comment-17789725 ] ASF GitHub Bot commented on GROOVY-11229: - daniellansun closed pull request #19

[jira] [Commented] (GROOVY-11229) Support pattern matching for `instanceof`

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789710#comment-17789710 ] ASF GitHub Bot commented on GROOVY-11229: - eric-milles commented on PR #1994: U

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
eric-milles commented on PR #1994: URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826398019 It would have been better to state in the original issue ticket that the goal is to support `instanceof` and `switch` pattern matching. It is still not clear from this where your plan

[jira] [Commented] (GROOVY-11229) Support pattern matching for `instanceof`

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789701#comment-17789701 ] ASF GitHub Bot commented on GROOVY-11229: - daniellansun commented on PR #1994:

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
daniellansun commented on PR #1994: URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826386161 I am looking for better AST for pattern matching for both `instanceof` and `switch`. The PR is just for `instanceof`, but I try to make flexible to change easily for other pattern

[jira] [Commented] (GROOVY-11229) Support pattern matching for `instanceof`

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789693#comment-17789693 ] ASF GitHub Bot commented on GROOVY-11229: - eric-milles commented on PR #1994: U

Re: [PR] GROOVY-11229: Support pattern matching for `instanceof` [groovy]

2023-11-25 Thread via GitHub
eric-milles commented on PR #1994: URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826377223 Do you have some description how this will be integrated? Adding something to `ClassExpression` without changing its `transformExpression` or `visit` does not make it clear where this

[jira] [Commented] (GROOVY-11229) Support pattern matching for `instanceof`

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789685#comment-17789685 ] ASF GitHub Bot commented on GROOVY-11229: - daniellansun opened a new pull reque